From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Michal Marek <mmarek@suse.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Kbuild: enable -Wunused-macros warning for "make W=1"
Date: Fri, 25 Aug 2017 01:19:39 +0900 [thread overview]
Message-ID: <CAK7LNATUHBZYMA7Bv4T4bM2ygzCZ5v2yLtyWYLATvR+hLCKAdg@mail.gmail.com> (raw)
In-Reply-To: <20170803100924.8791-1-jthumshirn@suse.de>
Hi Johannes,
2017-08-03 19:09 GMT+09:00 Johannes Thumshirn <jthumshirn@suse.de>:
> We have lots of dead defines and macros in drivers, lets offer users a way
> to detect and eventually remove them.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> scripts/Makefile.extrawarn | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index fb3522fd8702..8ab8bc91da55 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -25,6 +25,7 @@ warning-1 += -Wold-style-definition
> warning-1 += $(call cc-option, -Wmissing-include-dirs)
> warning-1 += $(call cc-option, -Wunused-but-set-variable)
> warning-1 += $(call cc-option, -Wunused-const-variable)
> +warning-1 += $(call cc-option, -Wunused-macros)
> warning-1 += $(call cc-disable-warning, missing-field-initializers)
> warning-1 += $(call cc-disable-warning, sign-compare)
This makes W=1 too noisy.
For example, drivers often define unused register macros
for completeness. I do not think it is too bad in my opinion.
Perhaps, should it be moved to warning-2 ?
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2017-08-24 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 10:09 [PATCH] Kbuild: enable -Wunused-macros warning for "make W=1" Johannes Thumshirn
2017-08-24 16:19 ` Masahiro Yamada [this message]
2017-08-28 6:53 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATUHBZYMA7Bv4T4bM2ygzCZ5v2yLtyWYLATvR+hLCKAdg@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=jthumshirn@suse.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).