From: Masahiro Yamada <masahiroy@kernel.org>
To: Vasily Gorbik <gor@linux.ibm.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Joe Lawrence <joe.lawrence@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sumanth Korikkar <sumanthk@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/2] s390/nospec: remove unneeded header includes
Date: Sat, 18 Mar 2023 08:36:27 +0900 [thread overview]
Message-ID: <CAK7LNATWTfsbhjp0z6JgXWPT8vogsOF=o09gQJzBsHWf9b7HcA@mail.gmail.com> (raw)
In-Reply-To: <your-ad-here.call-01679051845-ext-2019@work.hours>
On Fri, Mar 17, 2023 at 8:17 PM Vasily Gorbik <gor@linux.ibm.com> wrote:
>
> On Thu, Mar 16, 2023 at 12:14:27PM +0100, Jiri Slaby wrote:
> > On 27. 06. 22, 14:50, Vasily Gorbik wrote:
> > > With that, expoline.S doesn't require asm-offsets.h and
> > > expoline_prepare target dependency could be removed.
> > >
> > > +++ b/arch/s390/Makefile
> > > @@ -166,7 +166,7 @@ vdso_prepare: prepare0
> > > ifdef CONFIG_EXPOLINE_EXTERN
> > > modules_prepare: expoline_prepare
> > > -expoline_prepare: prepare0
> > > +expoline_prepare:
> >
> > this likely broke s390 build as expolines still depend on
> > scripts/basic/fixdep. And build of expolines can now race with fixdep build:
> > make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
> > /bin/sh: line 1: scripts/basic/fixdep: Permission denied
> > make[1]: *** [../scripts/Makefile.build:385:
> > arch/s390/lib/expoline/expoline.o] Error 126
> > make: *** [../arch/s390/Makefile:166: expoline_prepare] Error 2
> >
> > I returned there:
> > expoline_prepare: prepare0
> > and it looks good so far. Maybe even:
> > expoline_prepare: scripts
> > would be enough.
>
> Hi Jiri, thanks for looking into this!
>
> Probably even scripts_basic would be enough to add explicit dependency
> to fixdep. But I just couldn't reproduce missing scripts/basic/fixdep
> neither with modules_prepare nor expoline_prepare targets.
>
> With which specific build command were you able to get those error
> messages? I wonder where
> make[1]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
> is coming from. Could it be smth like?
>
> make ARCH=s390 CROSS_COMPILE=s390x-12.2.0- -j64 arch/s390/lib/expoline/expoline.o
>
> Playing around with this build target I found it is broken:
>
> AS arch/s390/lib/expoline/expoline.o
> AS arch/s390/lib/expoline/expoline.o
> fixdep: error opening file: arch/s390/lib/expoline/.expoline.o.d: No such file or directory
> make[3]: *** [scripts/Makefile.build:374: arch/s390/lib/expoline/expoline.o] Error 2
> make[3]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
> make[2]: *** [scripts/Makefile.build:494: arch/s390/lib/expoline] Error 2
> make[1]: *** [scripts/Makefile.build:494: arch/s390/lib] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:2028: .] Error 2
>
> Notice dup AS call, which is probably causing this:
> make[3]: *** Deleting file 'arch/s390/lib/expoline/expoline.o'
>
> But that would be a different issue from the one you are trying to fix.
Kbuild is able to build a single object that is built
in a normal descending.
Since you built arch/s390/lib/expoline/expoline.o
from the special target 'expoline_prepare',
two different threads simultaneously built
arch/s390/lib/expoline/expoline.o
(one from the normal descending, the other
from 'expoline_prepare')
That's why.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2023-03-17 23:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8417373c-9dba-54bd-ce08-2d36d0a2af04@redhat.com>
2022-06-07 17:26 ` Fwd: s390/nospec: add an option to use thunk-extern Joe Lawrence
2022-06-27 12:50 ` Vasily Gorbik
2022-06-27 12:50 ` [PATCH 1/2] s390/nospec: build expoline.o for modules_prepare target Vasily Gorbik
2022-06-27 12:50 ` [PATCH 2/2] s390/nospec: remove unneeded header includes Vasily Gorbik
2023-03-16 11:14 ` Jiri Slaby
2023-03-17 10:58 ` Masahiro Yamada
2023-03-17 11:17 ` Vasily Gorbik
2023-03-17 11:32 ` Jiri Slaby
2023-03-17 23:36 ` Masahiro Yamada [this message]
2022-06-29 15:16 ` s390/nospec: add an option to use thunk-extern Joe Lawrence
[not found] ` <CAPQ7N1RFyZRCJZc84UxjSQj44ksa6f6ib5B=dVwoqMU9_=s8QA@mail.gmail.com>
2022-07-01 21:39 ` Joe Lawrence
2022-07-17 13:11 ` Sumanth Korikkar
2022-08-17 13:59 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATWTfsbhjp0z6JgXWPT8vogsOF=o09gQJzBsHWf9b7HcA@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jirislaby@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=sumanthk@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).