From: Masahiro Yamada <masahiroy@kernel.org>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] scripts: kconfig: fix HOSTCC call
Date: Wed, 27 Jan 2021 03:16:59 +0900 [thread overview]
Message-ID: <CAK7LNATbnm+M4STsNFHrnNymA75G96aLQOMO22mXxsC8chEwtA@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNARE2nGgRGgux9jRcv1ogfFBgBzxKygHxeHwy_GcnZO7sg@mail.gmail.com>
On Fri, Jan 15, 2021 at 4:00 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Thu, Jan 14, 2021 at 7:05 PM Enrico Weigelt, metux IT consult
> <info@metux.net> wrote:
> >
>
> Thanks for catching this.
>
>
> > The change c0f975af1745391749e4306aa8081b9a4d2cced8 introduces a bug when
>
> Please use 12-digit hash ("subject") style.
>
>
> Commit c0f975af1745 ("kconfig: Support building mconf with vendor
> sysroot ncurses")
>
>
>
> > HOSTCC contains parameters: the whole command line is treated as the program
> > name (with spaces in it). Therefore, we have to remove the quotes.
> >
> > Fixes: c0f975af1745391749e4306aa8081b9a4d2cced8
>
> Ditto.
>
> Fixes: c0f975af1745 ("kconfig: Support building mconf with vendor
> sysroot ncurses")
>
>
>
> > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> > ---
> > scripts/kconfig/mconf-cfg.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/kconfig/mconf-cfg.sh b/scripts/kconfig/mconf-cfg.sh
> > index fcd4acd4e9cb..40fa449ed049 100755
> > --- a/scripts/kconfig/mconf-cfg.sh
> > +++ b/scripts/kconfig/mconf-cfg.sh
> > @@ -35,7 +35,7 @@ fi
> >
> > # As a final fallback before giving up, check if $HOSTCC knows of a default
> > # ncurses installation (e.g. from a vendor-specific sysroot).
> > -if echo '#include <ncurses.h>' | "${HOSTCC}" -E - >/dev/null 2>&1; then
> > +if echo '#include <ncurses.h>' | ${HOSTCC} -E - >/dev/null ; then
>
>
> Please keep 2>&1.
>
> This script will display the enough error message at the end.
>
>
>
> > echo cflags=\"-D_GNU_SOURCE\"
> > echo libs=\"-lncurses\"
> > exit 0
> > --
> > 2.11.0
> >
>
>
> --
> Best Regards
> Masahiro Yamada
I did not get v2.
I fixed them up by myself and applied it to linux-kbuild/fixes.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2021-01-26 23:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 10:02 [PATCH] scripts: kconfig: fix HOSTCC call Enrico Weigelt, metux IT consult
2021-01-14 19:00 ` Masahiro Yamada
2021-01-26 18:16 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNATbnm+M4STsNFHrnNymA75G96aLQOMO22mXxsC8chEwtA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=info@metux.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).