From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04DFDC77B7A for ; Thu, 25 May 2023 17:24:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232800AbjEYRYU (ORCPT ); Thu, 25 May 2023 13:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230502AbjEYRYT (ORCPT ); Thu, 25 May 2023 13:24:19 -0400 Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DD6C1BB for ; Thu, 25 May 2023 10:23:53 -0700 (PDT) Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-625bf433abfso3902036d6.2 for ; Thu, 25 May 2023 10:23:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685035432; x=1687627432; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VC9d8VClaITWEwUqcZuECdjYIAHc9o2yDDJtZ/g64PQ=; b=2N4wtctLmAyqgk6QelqOPqcr11aEX0XTiLh40tSKsZu79Sy4COrVl2Z8K24JocwdoW dYrKrwaD8bN2bpiI4Nj8B8J4QwFK0synUuMU+eXYSC7SVFXmh6xLIxPgyRADyiXO08qx XyqvzzB8Dlo3mUzMgMDiq69NcrW8vZIPXnVsTbx5a5ptd2l4gwXbTlCim583CyqVBudU nhQukbeip9nqQca6/H9rHUZnTOcIB12CDWbVikX1CXeKx1z5ztrqgpo/9/JWZ/0M1u1Q FbEXGOMuolY08JM1UdQRy7aokre5tRBznwdrNNHpmlM/GI3wUxk8x85j7+WvWasJ3M1f BcHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685035432; x=1687627432; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VC9d8VClaITWEwUqcZuECdjYIAHc9o2yDDJtZ/g64PQ=; b=WeJ5lE5NnGGdCro7Lzf+8/HsDGx8mcaZFKNHp5TjVAc1PI8XcyrKtdiPdPN9ZTv/+l brzKczTotewsDcMheWJW7LKyUMCEAGXxkv4W5hWEnsjBEHxrDshXkIxESUyVMHow0n6W SoRrcC+a13ckncxi2JmEQ6TZ3WKVvqaRIcGTgOzJfnWbvBXl+1/GK5soO06sdas8aAfU 8LVxW73/5oAgj2khizQLsHLaoEqcT2wodCi/L/X059DNsNGJ5QFM4RPK39bv+LrXFd80 zf+tQvm2kQR6e4mkgGvvwsifSBxILGZ7hC1cZq/ThdxQc+xgNYlL9jiYNBOEWiTavRso JAkw== X-Gm-Message-State: AC+VfDwoegKou/dshK/+wmdDB9sRYQ5Pk+rj0NKYAjNSthq/EQ5PObWV bNz4gmf/QdQXLPBDp7zy+koIj+pKQMoBZ7pqR8f4+g== X-Google-Smtp-Source: ACHHUZ4qe1nrt/7Y3nnUpJTssvtLZ9Ax5aXY+A9hbBKo1yMUqtOd2FwROyCyhdET7piu/JRXMZMAooTYMsxLsncG8LQ= X-Received: by 2002:ad4:5bcf:0:b0:5ed:d3d:405 with SMTP id t15-20020ad45bcf000000b005ed0d3d0405mr1730001qvt.34.1685035431606; Thu, 25 May 2023 10:23:51 -0700 (PDT) MIME-Version: 1.0 References: <20230521160426.1881124-1-masahiroy@kernel.org> <20230521160426.1881124-10-masahiroy@kernel.org> In-Reply-To: <20230521160426.1881124-10-masahiroy@kernel.org> From: Nick Desaulniers Date: Thu, 25 May 2023 10:23:40 -0700 Message-ID: Subject: Re: [PATCH v6 09/20] modpost: pass struct module pointer to check_section_mismatch() To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nicolas Schier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Sun, May 21, 2023 at 9:05=E2=80=AFAM Masahiro Yamada wrote: > > The next commit will use it. > > Signed-off-by: Masahiro Yamada Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > > scripts/mod/modpost.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c > index 40fac4f64fcd..378fb9649545 100644 > --- a/scripts/mod/modpost.c > +++ b/scripts/mod/modpost.c > @@ -1229,7 +1229,7 @@ static void default_mismatch_handler(const char *mo= dname, struct elf_info *elf, > } > } > > -static void check_section_mismatch(const char *modname, struct elf_info = *elf, > +static void check_section_mismatch(struct module *mod, struct elf_info *= elf, > Elf_Sym *sym, > unsigned int fsecndx, const char *from= sec, > Elf_Addr faddr, Elf_Addr taddr) > @@ -1240,7 +1240,7 @@ static void check_section_mismatch(const char *modn= ame, struct elf_info *elf, > if (!mismatch) > return; > > - default_mismatch_handler(modname, elf, mismatch, sym, > + default_mismatch_handler(mod->name, elf, mismatch, sym, > fsecndx, fromsec, faddr, > tosec, taddr); > } > @@ -1358,7 +1358,7 @@ static int addend_mips_rel(struct elf_info *elf, El= f_Shdr *sechdr, Elf_Rela *r) > #define R_LARCH_SUB32 55 > #endif > > -static void section_rela(const char *modname, struct elf_info *elf, > +static void section_rela(struct module *mod, struct elf_info *elf, > Elf_Shdr *sechdr) > { > Elf_Rela *rela; > @@ -1404,12 +1404,12 @@ static void section_rela(const char *modname, str= uct elf_info *elf, > break; > } > > - check_section_mismatch(modname, elf, elf->symtab_start + = r_sym, > + check_section_mismatch(mod, elf, elf->symtab_start + r_sy= m, > fsecndx, fromsec, r.r_offset, r.r_= addend); > } > } > > -static void section_rel(const char *modname, struct elf_info *elf, > +static void section_rel(struct module *mod, struct elf_info *elf, > Elf_Shdr *sechdr) > { > Elf_Rel *rel; > @@ -1459,7 +1459,7 @@ static void section_rel(const char *modname, struct= elf_info *elf, > fatal("Please add code to calculate addend for th= is architecture\n"); > } > > - check_section_mismatch(modname, elf, elf->symtab_start + = r_sym, > + check_section_mismatch(mod, elf, elf->symtab_start + r_sy= m, > fsecndx, fromsec, r.r_offset, r.r_= addend); > } > } > @@ -1476,19 +1476,19 @@ static void section_rel(const char *modname, stru= ct elf_info *elf, > * to find all references to a section that reference a section that wil= l > * be discarded and warns about it. > **/ > -static void check_sec_ref(const char *modname, struct elf_info *elf) > +static void check_sec_ref(struct module *mod, struct elf_info *elf) > { > int i; > Elf_Shdr *sechdrs =3D elf->sechdrs; > > /* Walk through all sections */ > for (i =3D 0; i < elf->num_sections; i++) { > - check_section(modname, elf, &elf->sechdrs[i]); > + check_section(mod->name, elf, &elf->sechdrs[i]); > /* We want to process only relocation sections and not .i= nit */ > if (sechdrs[i].sh_type =3D=3D SHT_RELA) > - section_rela(modname, elf, &elf->sechdrs[i]); > + section_rela(mod, elf, &elf->sechdrs[i]); > else if (sechdrs[i].sh_type =3D=3D SHT_REL) > - section_rel(modname, elf, &elf->sechdrs[i]); > + section_rel(mod, elf, &elf->sechdrs[i]); > } > } > > @@ -1659,7 +1659,7 @@ static void read_symbols(const char *modname) > sym_get_data(&info, sym)); > } > > - check_sec_ref(modname, &info); > + check_sec_ref(mod, &info); > > if (!mod->is_vmlinux) { > version =3D get_modinfo(&info, "version"); > -- > 2.39.2 > --=20 Thanks, ~Nick Desaulniers