From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ED50C433F5 for ; Thu, 9 Sep 2021 16:22:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81476611CA for ; Thu, 9 Sep 2021 16:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233932AbhIIQYB (ORCPT ); Thu, 9 Sep 2021 12:24:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:58306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233698AbhIIQYB (ORCPT ); Thu, 9 Sep 2021 12:24:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 71811611CA; Thu, 9 Sep 2021 16:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631204571; bh=4I5qNtFV3fFaY9KGvcMMXKDeg8djcA9vyBIRdTx5RfU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=L2jiRGNyqbNgYSS5tFb/URcYneH9PHH0S1ckdfHbLiSBMTdeAD5pgcNEGglUC6lgp UTTJJ65kmU3UQexh3ABoK5iXAc1XlGdVtLWSm5Vc7OGvvCtAAmmuo7psgor/A1rPqx y/464eot2n32AC9O16F6vP6Qfwpl8setqOUQ7CFrAJRbAwcceA2ozyvRJoCJfgUDOw dXd3sz21NsLIksusCcaESwiEZSG/bplO3jeG1lT8oZDGBG6N9WkPECntlFn8g1kAAL j3LQ8ND5RuNbJzburOr8YLUP0MEe1IlZpZ568ZxHpBvvRbBMm1e1sqkGzADI77MEZq Yj7TDmtB35YAA== Received: by mail-ej1-f46.google.com with SMTP id me10so4717877ejb.11; Thu, 09 Sep 2021 09:22:51 -0700 (PDT) X-Gm-Message-State: AOAM5300sQqlSSHa/+VNhBei9gGCYPC+rrIzXWuNABwTcUFT7YdRYB3E SXfze0gPN3JVklHLuIL3u1d5K6UYwN9/+OYD4A== X-Google-Smtp-Source: ABdhPJyYmirRxOMx/nkH5R0TN8ujUXKi8h/ubE2E96R+jKgo81BsMpD1j5g4ryjgyCeJ1PiNDEhi53QjrYrJil3MHLs= X-Received: by 2002:a17:906:7250:: with SMTP id n16mr4205561ejk.147.1631204570030; Thu, 09 Sep 2021 09:22:50 -0700 (PDT) MIME-Version: 1.0 References: <20210903155201.3004567-1-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Thu, 9 Sep 2021 11:22:38 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: Enable DT schema checks for %.dtb targets To: Masahiro Yamada Cc: DTML , Dmitry Baryshkov , Tom Rini , Linux Kbuild mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Thu, Sep 9, 2021 at 8:05 AM Masahiro Yamada wrote: > > On Sat, Sep 4, 2021 at 12:52 AM Rob Herring wrote: > > > > It is possible to build a single dtb, but not with DT schema validation > > enabled. Enable the schema validation to run for %.dtb targets. Anyone > > building a dtb for a specific platform *should* pay attention to schema > > warnings. > > > > This could be supported with a separate %.dt.yaml target instead. > > However, the .dt.yaml format is considered an intermediate format and > > could possibly go away at some point if schema checking is integrated > > into dtc. Also, the plan is to enable the schema checks by default once > > platforms are free of warnings, and this is a move in that direction. > > > > Cc: Dmitry Baryshkov > > Cc: Tom Rini > > Cc: Masahiro Yamada > > Cc: linux-kbuild@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > Makefile | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index ec9e8a0fe298..01b888cfe1dc 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -1399,8 +1399,8 @@ endif > > > > ifneq ($(dtstree),) > > > > -%.dtb: include/config/kernel.release scripts_dtc > > - $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > +%.dtb: dt_binding_check include/config/kernel.release scripts_dtc > > + $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ $(dtstree)/$*.dt.yaml > > > > %.dtbo: include/config/kernel.release scripts_dtc > > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > > Why didn't you change the %.dtbo part? Right, it should. Rob