From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3F5C433E2 for ; Mon, 31 Aug 2020 15:00:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 456CC207EA for ; Mon, 31 Aug 2020 15:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598886033; bh=+TU+gwRio8JWgglRL++C4eb2K+Sd3krTX7+AJtYIW3s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=cq/WlKCtWSG63wz/PISzpDCS0FbItZOLLG+joy+f3MEI3YJS2nq5m5WQqRYw46w1y aw5z7LAz7qnQLBbFD62CiYChZkp7UPAydIiMsVeO3qaYQL8nkTEThQ34kwr6TMyX9l 0z2Ho/M4KsS4xgNiW+71TqgLZee36QkaS1c+4l2Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728158AbgHaPAc (ORCPT ); Mon, 31 Aug 2020 11:00:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbgHaPAb (ORCPT ); Mon, 31 Aug 2020 11:00:31 -0400 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F40E720936; Mon, 31 Aug 2020 15:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598886030; bh=+TU+gwRio8JWgglRL++C4eb2K+Sd3krTX7+AJtYIW3s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ThPCkcLBkEYvALiOwUx25L2kmKURkIZKvpC8gWkOw7kBM3dnmuFUw4OqT5wBbXaAu rZ7nIJZnBOCT/Y69TldJ2Fx8d0R64XI8rjdQoIEMnsrL9xRv1UcHP/YEUJPGEAS5jb I5eLg4kSWNKxy2LkPgcNO7WqHJamai6r2IKsS1Lg= Received: by mail-ot1-f41.google.com with SMTP id t7so5595231otp.0; Mon, 31 Aug 2020 08:00:29 -0700 (PDT) X-Gm-Message-State: AOAM5334sCx4C+aS/s7Wcgw7ZMKq900clJRH8utBrO7i7CURiAcVkJos 8/YQMMeG5SGtk9k4+6DD8xftaYuyd8YMNJEPwpE= X-Google-Smtp-Source: ABdhPJwVGGb+gngLstrqLW0PFlbTXrG0TJiMbmlJ0aUDpEVAWF0OCWbFZD7MokZPg8Qes14uTkPbWeYCU0wBhXRJVO4= X-Received: by 2002:a9d:774d:: with SMTP id t13mr1176717otl.108.1598886029308; Mon, 31 Aug 2020 08:00:29 -0700 (PDT) MIME-Version: 1.0 References: <20200829051524.706585-1-masahiroy@kernel.org> <20200829051524.706585-3-masahiroy@kernel.org> In-Reply-To: <20200829051524.706585-3-masahiroy@kernel.org> From: Ard Biesheuvel Date: Mon, 31 Aug 2020 18:00:18 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] ia64: remove unneeded header includes from To: Masahiro Yamada Cc: Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org, Randy Dunlap , linux-kbuild@vger.kernel.org, Andrew Morton , Dmitry Safonov <0x7f454c46@gmail.com>, afzal mohammed , linux-efi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Sat, 29 Aug 2020 at 08:16, Masahiro Yamada wrote: > > includes too many unneeded headers. > > This commit cuts off a lot of header includes. > > What we need to include are: > > - for DECLARE_PER_CPU(u64, ia64_mca_pal_base) > - for NR_CPUS > - for u8, u64, size_t, etc. > - for KERNEL_STACK_SIZE > > The other header includes are actually unneeded. > > previously included 436 headers, and now it includes > only 138. I confirmed is still self-contained. > > Signed-off-by: Masahiro Yamada Acked-by: Ard Biesheuvel > --- > > arch/ia64/include/asm/mca.h | 9 +++------ > arch/ia64/kernel/efi.c | 1 + > arch/ia64/kernel/mca.c | 1 + > 3 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/arch/ia64/include/asm/mca.h b/arch/ia64/include/asm/mca.h > index c92b9c15962c..05805249296c 100644 > --- a/arch/ia64/include/asm/mca.h > +++ b/arch/ia64/include/asm/mca.h > @@ -14,13 +14,10 @@ > > #if !defined(__ASSEMBLY__) > > -#include > +#include > +#include > #include > - > -#include > -#include > -#include > -#include > +#include > > #define IA64_MCA_RENDEZ_TIMEOUT (20 * 1000) /* value in milliseconds - 20 seconds */ > > diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c > index f932b25fb817..b6bb718ed1ff 100644 > --- a/arch/ia64/kernel/efi.c > +++ b/arch/ia64/kernel/efi.c > @@ -39,6 +39,7 @@ > #include > #include > #include > +#include > #include > #include > > diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c > index 17151269d655..3911c561d2bb 100644 > --- a/arch/ia64/kernel/mca.c > +++ b/arch/ia64/kernel/mca.c > @@ -96,6 +96,7 @@ > #include > #include > #include > +#include > #include > > #include > -- > 2.25.1 >