From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: "Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>,
"Nicolas Pitre" <nico@fluxnic.net>,
"Nathan Chancellor" <nathan@kernel.org>,
"Bernhard Rosenkränzer" <bero@lindev.ch>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Will Deacon" <will@kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: collect minimum tool versions into scripts/min-tool-version.sh
Date: Thu, 11 Mar 2021 11:18:09 +0100 [thread overview]
Message-ID: <CANiq72m1e9MD83sP5iZCfzoCR0qLz2HQj_VVkE4X-56vf6e7fw@mail.gmail.com> (raw)
In-Reply-To: <20210311094624.923913-1-masahiroy@kernel.org>
On Thu, Mar 11, 2021 at 10:47 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> +# When you raise the minimum version, please update
> +# Documentation/process/changes.rst as well.
> +min_gcc_version=4.9.0
> +min_llvm_version=10.0.1
> +min_icc_version=16.0.3 # temporary
> +min_binutils_version=2.23.0
+1 to creating a central place for all minimum versions.
Acked-by: Miguel Ojeda <ojeda@kernel.org>
I wonder if you considered creating a folder with files like
`scripts/min_versions/gcc` containing the version string. That would
make it easier for reading from other languages or even importing them
dynamically into the documentation, thus removing even more
duplication.
Cheers,
Miguel
next prev parent reply other threads:[~2021-03-11 10:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 9:46 [PATCH] kbuild: collect minimum tool versions into scripts/min-tool-version.sh Masahiro Yamada
2021-03-11 10:18 ` Miguel Ojeda [this message]
2021-03-11 10:33 ` Masahiro Yamada
2021-03-11 11:15 ` Miguel Ojeda
2021-03-12 1:19 ` Nicolas Pitre
2021-03-12 11:10 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72m1e9MD83sP5iZCfzoCR0qLz2HQj_VVkE4X-56vf6e7fw@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=bero@lindev.ch \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nico@fluxnic.net \
--cc=ojeda@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).