From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2F27C433E9 for ; Mon, 8 Feb 2021 10:54:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B037864E45 for ; Mon, 8 Feb 2021 10:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232757AbhBHKyf (ORCPT ); Mon, 8 Feb 2021 05:54:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:47518 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232333AbhBHKuO (ORCPT ); Mon, 8 Feb 2021 05:50:14 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B3F9C64E8A; Mon, 8 Feb 2021 10:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612781242; bh=aEmETdAAaqlh641eroVBM3hnbdYUk9TPTg1/0fBiOdg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KoBZknK/t/arwDGGPinIqqLC5St7DRWfxSLKxzuC558dyJ+cvOVjamOGOZWxtAt9I Fnp6lqlbJiuFbz7XJG68VsKN6EjOgQHWjsBxKvY07Pe4CH8PIUoWlPNMYiXd6lDsDT Jedu9uJU1lZURZGGODarxd/SWVYCOvADEzIyrChE= Date: Mon, 8 Feb 2021 11:47:19 +0100 From: Greg KH To: Yicong Yang Cc: jdelvare@suse.com, linux@roeck-us.net, giometti@enneenne.com, abbotti@mev.co.uk, hsweeten@visionengravers.com, kw@linux.com, helgaas@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hwmon@vger.kernel.org, devel@driverdev.osuosl.org, linux-kbuild@vger.kernel.org, masahiroy@kernel.org, michal.lkml@markovi.net, linuxarm@openeuler.org, prime.zeng@huawei.com Subject: Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag Message-ID: References: <1612518255-23052-1-git-send-email-yangyicong@hisilicon.com> <1612518255-23052-2-git-send-email-yangyicong@hisilicon.com> <08017751-a1be-ea07-50de-73d14ab6d57e@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08017751-a1be-ea07-50de-73d14ab6d57e@hisilicon.com> Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Mon, Feb 08, 2021 at 06:44:52PM +0800, Yicong Yang wrote: > Hi Greg, > > On 2021/2/5 17:53, Greg KH wrote: > > On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > >> From: Junhao He > >> > >> Use subdir-ccflags-* instead of ccflags-* to inherit the debug > >> settings from Kconfig when traversing subdirectories. > > > > That says what you do, but not _why_ you are doing it. > > i'll illustrate the reason and reword the commit. > > > > > What does this offer in benefit of the existing way? What is it fixing? > > Why do this "churn"? > > currently we have added ccflags-$(CONFIG_DEBUG_DRIVER) := -DDEBUG in the Makefile > of driver/base and driver/base/power, but not in the subdirectory > driver/base/firmware_loader. we cannot turn the debug on for subdirectory > firmware_loader if we config DEBUG_DRIVER and there is no kconfig option > for the it. Is that necessary? Does that directory need it? thanks, greg k-h