From: Christoph Hellwig <hch@infradead.org>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: bhelgaas@google.com, corbet@lwn.net, alex.williamson@redhat.com,
diana.craciun@oss.nxp.com, kwankhede@nvidia.com,
eric.auger@redhat.com, masahiroy@kernel.org,
michal.lkml@markovi.net, linux-pci@vger.kernel.org,
linux-doc@vger.kernel.org, kvm@vger.kernel.org,
linux-s390@vger.kernel.org, linux-kbuild@vger.kernel.org,
mgurtovoy@nvidia.com, jgg@nvidia.com, maorg@nvidia.com,
leonro@nvidia.com
Subject: Re: [PATCH V4 06/13] vfio/pci: Split the pci_driver code out of vfio_pci_core.c
Date: Thu, 26 Aug 2021 10:31:49 +0100 [thread overview]
Message-ID: <YSdfhVK2LYBfMWiT@infradead.org> (raw)
In-Reply-To: <20210825135139.79034-7-yishaih@nvidia.com>
On Wed, Aug 25, 2021 at 04:51:32PM +0300, Yishai Hadas wrote:
> From: Max Gurtovoy <mgurtovoy@nvidia.com>
>
> Split the vfio_pci driver into two logical parts, the 'struct
> pci_driver' (vfio_pci.c) which implements "Generic VFIO support for any
> PCI device" and a library of code (vfio_pci_core.c) that helps
> implementing a struct vfio_device on top of a PCI device.
>
> vfio_pci.ko continues to present the same interface under sysfs and this
> change should have no functional impact.
>
> Following patches will turn vfio_pci and vfio_pci_core into a separate
> module.
>
> This is a preparation for allowing another module to provide the
> pci_driver and allow that module to customize how VFIO is setup, inject
> its own operations, and easily extend vendor specific functionality.
>
> At this point the vfio_pci_core still contains a lot of vfio_pci
> functionality mixed into it. Following patches will move more of the large
> scale items out, but another cleanup series will be needed to get
> everything.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> ---
> drivers/vfio/pci/Makefile | 2 +-
> drivers/vfio/pci/vfio_pci.c | 223 +++++++++++++++++++++++++
> drivers/vfio/pci/vfio_pci_core.c | 271 +++++++------------------------
> drivers/vfio/pci/vfio_pci_core.h | 23 +++
> 4 files changed, 304 insertions(+), 215 deletions(-)
> create mode 100644 drivers/vfio/pci/vfio_pci.c
>
> diff --git a/drivers/vfio/pci/Makefile b/drivers/vfio/pci/Makefile
> index 66a40488e967..8aa517b4b671 100644
> --- a/drivers/vfio/pci/Makefile
> +++ b/drivers/vfio/pci/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -vfio-pci-y := vfio_pci_core.o vfio_pci_intrs.o vfio_pci_rdwr.o vfio_pci_config.o
> +vfio-pci-y := vfio_pci.o vfio_pci_core.o vfio_pci_intrs.o vfio_pci_rdwr.o vfio_pci_config.o
Please avoid the overly long line.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-08-26 9:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 13:51 [PATCH V4 00/13] Introduce vfio_pci_core subsystem Yishai Hadas
2021-08-25 13:51 ` [PATCH V4 01/13] vfio/pci: Rename vfio_pci.c to vfio_pci_core.c Yishai Hadas
2021-08-26 9:15 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 02/13] vfio/pci: Rename vfio_pci_private.h to vfio_pci_core.h Yishai Hadas
2021-08-26 9:17 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 03/13] vfio/pci: Rename vfio_pci_device to vfio_pci_core_device Yishai Hadas
2021-08-26 9:22 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 04/13] vfio/pci: Rename ops functions to fit core namings Yishai Hadas
2021-08-26 9:25 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 05/13] vfio/pci: Include vfio header in vfio_pci_core.h Yishai Hadas
2021-08-26 9:27 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 06/13] vfio/pci: Split the pci_driver code out of vfio_pci_core.c Yishai Hadas
2021-08-26 9:31 ` Christoph Hellwig [this message]
2021-08-25 13:51 ` [PATCH V4 07/13] vfio/pci: Move igd initialization to vfio_pci.c Yishai Hadas
2021-08-26 9:34 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 08/13] vfio/pci: Move module parameters " Yishai Hadas
2021-08-26 9:36 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 09/13] PCI: Add 'override_only' field to struct pci_device_id Yishai Hadas
2021-08-25 15:54 ` Bjorn Helgaas
2021-08-25 21:25 ` Alex Williamson
2021-08-25 13:51 ` [PATCH V4 10/13] PCI / VFIO: Add 'override_only' support for VFIO PCI sub system Yishai Hadas
2021-08-25 15:55 ` Bjorn Helgaas
2021-08-25 22:05 ` Alex Williamson
2021-08-25 22:24 ` Jason Gunthorpe
2021-08-25 22:33 ` Alex Williamson
2021-08-25 13:51 ` [PATCH V4 11/13] vfio: Use select for eventfd Yishai Hadas
2021-08-26 9:06 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 12/13] vfio: Use kconfig if XX/endif blocks instead of repeating 'depends on' Yishai Hadas
2021-08-26 9:09 ` Christoph Hellwig
2021-08-25 13:51 ` [PATCH V4 13/13] vfio/pci: Introduce vfio_pci_core.ko Yishai Hadas
2021-08-26 9:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSdfhVK2LYBfMWiT@infradead.org \
--to=hch@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=diana.craciun@oss.nxp.com \
--cc=eric.auger@redhat.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=masahiroy@kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=michal.lkml@markovi.net \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).