From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] kbuild: use $(obj)/ instead of $(src)/ for pattern rules for %.[cS]
Date: Fri, 19 Apr 2024 17:09:28 +0200 [thread overview]
Message-ID: <ZiKJKFiJ1rtJyHjM@bergen.fjasle.eu> (raw)
In-Reply-To: <20240416121838.95427-4-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Tue 16 Apr 2024 21:18:37 GMT, Masahiro Yamada wrote:
> Kbuild conventionally uses $(obj)/ for generated files, and $(src)/ for
> checked-in source files. It is merely a convention without any functional
> difference. In fact, $(obj) and $(src) are exactly the same, as defined
> in scripts/Makefile.build:
>
> src := $(obj)
>
> Before changing the semantics of $(src) in the next commit, this commit
> replaces $(obj)/ with $(src)/ in pattern rules where the prerequisite
> might be a generated file.
thanks. That's a good idea to split both steps.
> C and assembly files are sometimes generated by tools, so they could
> be either generated files or real sources. The $(obj)/ prefix works
> for both cases with the help of VPATH.
>
> As mentioned above, $(obj) and $(src) are the same at this point, hence
> this commit has no functional change.
>
> I did not modify scripts/Makefile.userprogs because there is no use
> case where userspace C files are generated.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-04-19 15:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 12:18 [PATCH 0/4] kbuild: replace $(srctree)/$(src) with $(src) in Makefiles Masahiro Yamada
2024-04-16 12:18 ` [PATCH 1/4] arch: use $(obj)/ instead of $(src)/ for preprocessed linker scripts Masahiro Yamada
2024-04-19 14:59 ` Nicolas Schier
2024-04-16 12:18 ` [PATCH 2/4] Makefile: remove some unnecessary header include paths Masahiro Yamada
2024-04-19 15:07 ` Nicolas Schier
2024-04-20 7:46 ` Masahiro Yamada
2024-04-16 12:18 ` [PATCH 3/4] kbuild: use $(obj)/ instead of $(src)/ for pattern rules for %.[cS] Masahiro Yamada
2024-04-19 15:09 ` Nicolas Schier [this message]
2024-04-16 12:18 ` [PATCH 4/4] kbuild: use $(src) instead of $(srctree)/$(src) for source directory Masahiro Yamada
2024-04-16 22:45 ` kernel test robot
2024-04-17 4:19 ` kernel test robot
2024-04-18 13:43 ` Rob Herring
2024-04-19 15:09 ` Nicolas Schier
2024-04-20 8:56 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiKJKFiJ1rtJyHjM@bergen.fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).