linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@infradead.org>, Greg KH <greg@kroah.com>,
	"Luis R. Rodriguez" <mcgrof@gmail.com>,
	zippel@linux-m68k.org, linux-kbuild@vger.kernel.org,
	Sam Ravnborg <sam@ravnborg.org>, Jonathan Corbet <corbet@lwn.net>,
	Alan Jenkins <sourcejedi.lkml@googlemail.com>,
	Andi Kleen <andi@firstfloor.org>
Subject: [PATCH] kconfig: add missing dependency of conf to localyesconfig
Date: Fri, 21 Aug 2009 12:52:48 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.00.0908211251360.30182@gandalf.stny.rr.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0908211200160.30182@gandalf.stny.rr.com>


The following patch is in:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-kconfig.git

    branch: for-next


Steven Rostedt (1):
      kconfig: add missing dependency of conf to localyesconfig

----
 scripts/kconfig/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---------------------------
commit 48586218b6515b9bd70694e3cd8c901a6a6ee69c
Author: Steven Rostedt <srostedt@redhat.com>
Date:   Fri Aug 21 12:42:20 2009 -0400

    kconfig: add missing dependency of conf to localyesconfig
    
    There's a dependency missing.
    
    $ make localyesconfig
      HOSTCC  scripts/basic/fixdep
      HOSTCC  scripts/basic/docproc
      HOSTCC  scripts/basic/hash
    using config: '/boot/config-2.6.27.25-78.2.56.fc9.x86_64'
    /bin/sh: line 8: scripts/kconfig/conf: No such file or directory
    make[1]: *** [localyesconfig] Error 127
    make: *** [localyesconfig] Error 2
    
    Thus the script failed to run. But the sed command that converts the '=m'
    to '=y' still ran. This gives us a distro config with all modules
    converted to built in!
    
    The missing dependency was for conf for localyesconfig. This
    dependency was already set for localmodconfig.
    
    Reported-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 915a39a..6d69c7c 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -43,7 +43,7 @@ localmodconfig: $(obj)/streamline_config.pl $(obj)/conf
 	fi
 	$(Q)rm -f .tmp.config
 
-localyesconfig: $(obj)/streamline_config.pl
+localyesconfig: $(obj)/streamline_config.pl $(obj)/conf
 	$(Q)perl $< $(Kconfig) > .tmp.config
 	$(Q)sed -i s/=m/=y/ .tmp.config
 	$(Q)if [ -f .config ]; then 				\



      parent reply	other threads:[~2009-08-21 16:52 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19  2:56 [PATCH 00/14] kconfig: streamline distro configs for testers Steven Rostedt
2009-08-19  2:56 ` [PATCH 01/14] kconfig: add streamline_config.pl to scripts Steven Rostedt
2009-08-19  2:56 ` [PATCH 02/14] kconfig: make localmodconfig to run streamline_config.pl Steven Rostedt
2009-08-19  2:56 ` [PATCH 03/14] kconfig: add make localyesconfig option Steven Rostedt
2009-08-19  2:56 ` [PATCH 04/14] kconfig: streamline_config.pl do not stop with no depends Steven Rostedt
2009-08-19  2:56 ` [PATCH 05/14] kconfig: do not warn about modules built in Steven Rostedt
2009-08-19  2:56 ` [PATCH 06/14] kconfig: enable CONFIG_IKCONFIG from streamline_config.pl Steven Rostedt
2009-08-19  2:56 ` [PATCH 07/14] kconfig: add check if end exists in extract-ikconfig Steven Rostedt
2009-08-19  2:56 ` [PATCH 08/14] kconfig: have extract-ikconfig read ELF files Steven Rostedt
2009-08-19  2:56 ` [PATCH 09/14] kconfig: keep config.gz around even if CONFIG_IKCONFIG_PROC is not set Steven Rostedt
2009-08-19  2:56 ` [PATCH 10/14] kconfig: search for a config to base the local(mod|yes)config on Steven Rostedt
2009-08-19  2:56 ` [PATCH 11/14] kconfig: unset IKCONFIG_PROC and clean up nesting Steven Rostedt
2009-08-19  2:56 ` [PATCH 12/14] kconfig: test for /boot/config-uname after /proc/config.gz in localconfig Steven Rostedt
2009-08-19  2:56 ` [PATCH 13/14] kconfig: make local .config default for streamline_config Steven Rostedt
2009-08-19  2:56 ` [PATCH 14/14] kconfig: test if a .config already exists Steven Rostedt
2009-08-19 14:29 ` [PATCH 00/14] kconfig: streamline distro configs for testers Greg KH
2009-08-20 21:30 ` Andrew Morton
2009-08-20 21:43   ` Steven Rostedt
2009-08-20 22:13     ` Andrew Morton
2009-08-21 13:52       ` Ingo Molnar
2009-08-21 15:08         ` Steven Rostedt
2009-08-21 16:32           ` Ingo Molnar
2009-08-21 17:39             ` Steven Rostedt
2009-08-21 21:39   ` Sam Ravnborg
2009-08-21  9:21 ` Amerigo Wang
2009-08-21 14:35 ` Ingo Molnar
2009-08-21 14:50   ` Steven Rostedt
2009-08-21 14:54     ` Ingo Molnar
2009-08-21 16:03       ` Steven Rostedt
2009-08-21 16:05         ` Steven Rostedt
2009-08-21 16:28           ` Ingo Molnar
2009-08-21 16:55             ` Steven Rostedt
2009-08-21 19:51               ` Ingo Molnar
2009-08-21 20:12                 ` Steven Rostedt
2009-08-21 20:32                   ` Greg KH
2009-08-21 20:34                   ` Steven Rostedt
2009-08-21 20:39                     ` Ingo Molnar
2009-08-21 20:52                       ` Steven Rostedt
2009-08-21 21:02                         ` Ingo Molnar
2009-08-21 21:17                           ` Steven Rostedt
2009-08-21 16:52         ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.00.0908211251360.30182@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arjan@infradead.org \
    --cc=corbet@lwn.net \
    --cc=greg@kroah.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sam@ravnborg.org \
    --cc=sourcejedi.lkml@googlemail.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).