From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:50212 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbZHUQws (ORCPT ); Fri, 21 Aug 2009 12:52:48 -0400 Date: Fri, 21 Aug 2009 12:52:48 -0400 (EDT) From: Steven Rostedt Subject: [PATCH] kconfig: add missing dependency of conf to localyesconfig In-Reply-To: Message-ID: References: <20090819025634.987354707@goodmis.org> <20090821143525.GH11098@elte.hu> <20090821145406.GA3659@elte.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: LKML Cc: Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Linus Torvalds , Theodore Tso , Arjan van de Ven , Greg KH , "Luis R. Rodriguez" , zippel@linux-m68k.org, linux-kbuild@vger.kernel.org, Sam Ravnborg , Jonathan Corbet , Alan Jenkins , Andi Kleen The following patch is in: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-kconfig.git branch: for-next Steven Rostedt (1): kconfig: add missing dependency of conf to localyesconfig ---- scripts/kconfig/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --------------------------- commit 48586218b6515b9bd70694e3cd8c901a6a6ee69c Author: Steven Rostedt Date: Fri Aug 21 12:42:20 2009 -0400 kconfig: add missing dependency of conf to localyesconfig There's a dependency missing. $ make localyesconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/basic/docproc HOSTCC scripts/basic/hash using config: '/boot/config-2.6.27.25-78.2.56.fc9.x86_64' /bin/sh: line 8: scripts/kconfig/conf: No such file or directory make[1]: *** [localyesconfig] Error 127 make: *** [localyesconfig] Error 2 Thus the script failed to run. But the sed command that converts the '=m' to '=y' still ran. This gives us a distro config with all modules converted to built in! The missing dependency was for conf for localyesconfig. This dependency was already set for localmodconfig. Reported-by: Ingo Molnar Signed-off-by: Steven Rostedt diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 915a39a..6d69c7c 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -43,7 +43,7 @@ localmodconfig: $(obj)/streamline_config.pl $(obj)/conf fi $(Q)rm -f .tmp.config -localyesconfig: $(obj)/streamline_config.pl +localyesconfig: $(obj)/streamline_config.pl $(obj)/conf $(Q)perl $< $(Kconfig) > .tmp.config $(Q)sed -i s/=m/=y/ .tmp.config $(Q)if [ -f .config ]; then \