From: Boris Kolpackov <boris@codesynthesis.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "James Morris" <jmorris@namei.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
"Serge E . Hallyn" <serge@hallyn.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Nicolas Iooss" <nicolas.iooss@m4x.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Mickaël Salaün" <mic@linux.microsoft.com>
Subject: Re: [PATCH v1 2/3] kconfig: Ask user if string needs to be changed when dependency changed
Date: Mon, 15 Feb 2021 16:13:28 +0200 [thread overview]
Message-ID: <boris.20210215155804@codesynthesis.com> (raw)
In-Reply-To: <20210215122513.1773897-3-mic@digikod.net>
Mickaël Salaün <mic@digikod.net> writes:
> Content of string configuration may depend on related kernel
> configurations. Modify oldconfig and syncconfig to inform users about
> possible required configuration update and give them the opportunity to
> update it:
> * if dependencies of this string has changed (e.g. enabled or disabled),
> * and if the current value of this string is different than the (new)
> default one.
I have a number of questions:
1. Why is a change in dependencies necessarily means that the dependent's
value must be revised? Here is a specific example (to make sure we are
talking about the same things):
config FOO
string "Foo value"
depends on BAR || BAZ
Why, in the general case, when I disable BAR and enable BAZ I must
also revise the value of FOO?
2. How do you know that what's in the user's .config is the old default
and in Kconfig -- the new default value? What if in the user's .config
is a custom value (with which the user is perfectly happy) and what's
in Kconfig is the old default (which the user has already seen)?
3. Why limit this to strings only?
> This is particularly relevant for CONFIG_LSM which contains a list of
> LSMs enabled at boot, but users will not have a chance to update this
> list with a make oldconfig.
If my understanding above is correct, this feels like it's been purpose-
made to address whatever issue you are having with CONFIG_LSM. If so,
what about potential numerous other options that don't have this issue
but will now be presented to the user for modification?
next prev parent reply other threads:[~2021-02-15 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 12:25 [PATCH v1 0/3] Kconfig oldconfig string update Mickaël Salaün
2021-02-15 12:25 ` [PATCH v1 1/3] kconfig: Remove duplicate call to sym_get_string_value() Mickaël Salaün
2021-02-15 12:25 ` [PATCH v1 2/3] kconfig: Ask user if string needs to be changed when dependency changed Mickaël Salaün
2021-02-15 14:13 ` Boris Kolpackov [this message]
2021-02-15 15:40 ` Mickaël Salaün
2021-02-15 12:25 ` [PATCH v1 3/3] security: Add LSMs dependencies to CONFIG_LSM Mickaël Salaün
2021-02-15 17:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=boris.20210215155804@codesynthesis.com \
--to=boris@codesynthesis.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mic@digikod.net \
--cc=mic@linux.microsoft.com \
--cc=nicolas.iooss@m4x.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).