Re: [PATCH] virt: sev-guest: Mark driver struct with __refdata to prevent section mismatch - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Tom Lendacky <thomas.lendacky@amd.com>,
	 Dan Williams <dan.j.williams@intel.com>,
	 Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	"Borislav Petkov (AMD)" <bp@alien8.de>
Cc: kernel@pengutronix.de, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] virt: sev-guest: Mark driver struct with __refdata to prevent section mismatch
Date: Mon, 15 Apr 2024 16:39:32 +0200	[thread overview]
Message-ID: <cy6wxmcdr6o5nm3q2ze3otkmaeekwum4ob3cotxllp2l2km3np@fkljzlvxabyz> (raw)
In-Reply-To: <4a81b0e87728a58904283e2d1f18f73abc69c2a1.1711748999.git.u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

Hello,

On Fri, Mar 29, 2024 at 10:54:41PM +0100, Uwe Kleine-König wrote:
> As described in the added code comment, a reference to .exit.text is ok
> for drivers registered via module_platform_driver_probe(). Make this
> explicit to prevent the following section mismatch warning
> 
> 	WARNING: modpost: drivers/virt/coco/sev-guest/sev-guest: section mismatch in reference: sev_guest_driver+0x10 (section: .data) -> sev_guest_remove (section: .exit.text)
> 
> that triggers on an allmodconfig W=1 build.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

I'd like to enable these warnings even for W=0 builds, so it would be
great to get it into the main line soon.

If you apply it, please notice that I fat-fingered the parameters to git
send-email and it was sent in a thread. So (assuming you're using b4)
you'd need:

        b4 am -P _ 4a81b0e87728a58904283e2d1f18f73abc69c2a1.1711748999.git.u.kleine-koenig@pengutronix.de

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]