linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: con3270.o is built twice, leading to errors
Date: Mon, 17 Jul 2023 10:30:52 +0200	[thread overview]
Message-ID: <d57ba55f-20a3-b836-783d-b49c8a161b6e@kernel.org> (raw)
In-Reply-To: <CAK7LNAQhORSPEuB=XFa_i5EcQfsJ6uXy0MM5YWo_84eLGcoxNQ@mail.gmail.com>

On 15. 07. 23, 7:04, Masahiro Yamada wrote:
> On Fri, Jul 14, 2023 at 3:33 PM Jiri Slaby <jirislaby@kernel.org> wrote:
>>
>> Hi,
>>
>> if I create an s390 defconfig:
>> mkdir /tmp/s390/
>> make O=/tmp/s390/ ARCH=s390 CROSS_COMPILE=s390x-suse-linux- defconfig
>>
>> And then if I try for a couple times:
>> make O=/tmp/s390/ -j17 ARCH=s390 CROSS_COMPILE=s390x-suse-linux-
>> drivers/s390/char/con3270.o
>>
>> Most of the time, I get:
>> make[1]: Entering directory '/tmp/s390'
>>     GEN     Makefile
>>     CALL    /home/latest/linux/scripts/checksyscalls.sh
>>     CC      drivers/s390/char/con3270.o
>>     CC      drivers/s390/char/con3270.o
>>
>> I.e. it is built twice.
>>
>> Sometimes, I also get an error:
>> fixdep: error opening file: drivers/s390/char/.con3270.o.d: No such file
>> or directory
>> make[4]: *** [/home/latest/linux/scripts/Makefile.build:243:
>> drivers/s390/char/con3270.o] Error 2
>> make[4]: *** Deleting file 'drivers/s390/char/con3270.o'
>> make[3]: *** [/home/latest/linux/scripts/Makefile.build:477: drivers]
>>
>> Obviously due to some race.
>>
>> Any ideas what is going on?
> 
> 
> 
> The reason is because ARCH=s390 descends into
> drivers/s390/ in a non-standard way.
> 
> See arch/s390/Makefile line 122.
> 
> 
> 
> This is a corner case in single builds, and I
> do not know how to make it work.
> 
> 
> 
> I really hope arch maintainers will follow the standard
> obj-y syntax unless there is a strong reason to opt out.
> 
> 
> The following patch will fix the issue.

Tested-by: Jiri Slaby <jirislaby@kernel.org>

Will you send it as a patch?

> diff --git a/arch/s390/Makefile b/arch/s390/Makefile
> index 5ed242897b0d..a53a36ee0731 100644
> --- a/arch/s390/Makefile
> +++ b/arch/s390/Makefile
> @@ -119,7 +119,6 @@ export KBUILD_CFLAGS_DECOMPRESSOR
>   OBJCOPYFLAGS   := -O binary
> 
>   libs-y         += arch/s390/lib/
> -drivers-y      += drivers/s390/
> 
>   boot           := arch/s390/boot
>   syscalls       := arch/s390/kernel/syscalls
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 7241d80a7b29..a7459e77df37 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -195,3 +195,5 @@ obj-$(CONFIG_PECI)          += peci/
>   obj-$(CONFIG_HTE)              += hte/
>   obj-$(CONFIG_DRM_ACCEL)                += accel/
>   obj-$(CONFIG_CDX_BUS)          += cdx/
> +
> +obj-$(CONFIG_S390)             += s390/


thanks,
-- 
js
suse labs


  reply	other threads:[~2023-07-17  8:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14  6:33 con3270.o is built twice, leading to errors Jiri Slaby
2023-07-14 20:01 ` Nicolas Schier
2023-07-15  5:04 ` Masahiro Yamada
2023-07-17  8:30   ` Jiri Slaby [this message]
2023-07-19  8:30 ` arch/um's ssl.o [was: con3270.o] " Jiri Slaby
2023-07-21 13:37   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d57ba55f-20a3-b836-783d-b49c8a161b6e@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=nicolas@fjasle.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).