From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, Jarod Wilson <jarod@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] kbuild: touch autoksyms.h when it is really missing
Date: Wed, 14 Mar 2018 13:26:35 -0400 (EDT) [thread overview]
Message-ID: <nycvar.YSQ.7.76.1803141324420.28583@knanqh.ubzr> (raw)
In-Reply-To: <1521045861-22418-3-git-send-email-yamada.masahiro@socionext.com>
On Thu, 15 Mar 2018, Masahiro Yamada wrote:
> From the comment, I expect this code creates autoksyms.h in case it
> is missing, but it actually touches it when it does exists.
Oops, indeed.
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> I do not know when this code is useful...
>
> If autoksyms.h were missing, build should have already failed because
> include/{linux,asm-generic}/export.h need it.
>
> Maybe for standalone test?
> Or, in order to make this script self-contained?
I agree it isn't very useful. Proof: it was wrong and wouldn't have
worked as intended. So the best fix might be to simply remove that line.
>
>
> scripts/adjust_autoksyms.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/adjust_autoksyms.sh b/scripts/adjust_autoksyms.sh
> index 513da1a..a52210b 100755
> --- a/scripts/adjust_autoksyms.sh
> +++ b/scripts/adjust_autoksyms.sh
> @@ -49,7 +49,7 @@ case "${KCONFIG_CONFIG}" in
> esac
>
> # In case it doesn't exist yet...
> -if [ -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
> +if [ ! -e "$cur_ksyms_file" ]; then touch "$cur_ksyms_file"; fi
>
> # Generate a new ksym list file with symbols needed by the current
> # set of modules.
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2018-03-14 17:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 16:44 [PATCH 0/7] kbuild: various fix, clean-up, improvements of CONFIG_TRIM_UNUSED_KSYMS Masahiro Yamada
2018-03-14 16:44 ` [PATCH 1/7] kbuild: clear LDFLAGS in the top Makefile Masahiro Yamada
2018-03-14 16:44 ` [PATCH 2/7] kbuild: touch autoksyms.h when it is really missing Masahiro Yamada
2018-03-14 17:26 ` Nicolas Pitre [this message]
2018-03-15 6:26 ` Masahiro Yamada
2018-03-14 16:44 ` [PATCH 3/7] kbuild: move 'scripts' target below Masahiro Yamada
2018-03-16 7:13 ` kbuild test robot
2018-03-16 7:20 ` Masahiro Yamada
2018-03-14 16:44 ` [PATCH 4/7] kbuild: restore touching autoksyms.h to the top Makefile Masahiro Yamada
2018-03-14 17:52 ` Nicolas Pitre
2018-03-14 16:44 ` [PATCH 5/7] kbuild: hide CONFIG_TRIM_UNUSED_KSYMS code from external module building Masahiro Yamada
2018-03-14 18:32 ` Nicolas Pitre
2018-03-15 6:36 ` Masahiro Yamada
2018-03-15 18:30 ` Nicolas Pitre
2018-03-14 16:44 ` [PATCH 6/7] kbuild: move include/config/ksym/* to include/ksym/* Masahiro Yamada
2018-03-14 18:47 ` Nicolas Pitre
2018-03-15 10:04 ` Masahiro Yamada
2018-03-15 11:01 ` Masahiro Yamada
2018-03-15 18:59 ` Nicolas Pitre
2018-03-14 16:44 ` [PATCH 7/7] kbuild: link vmlinux just once for CONFIG_TRIM_UNUSED_KSYMS Masahiro Yamada
2018-03-14 19:06 ` Nicolas Pitre
2018-03-15 8:00 ` Masahiro Yamada
2018-03-15 18:50 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YSQ.7.76.1803141324420.28583@knanqh.ubzr \
--to=nicolas.pitre@linaro.org \
--cc=jarod@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).