From: Hans Verkuil <hverkuil@xs4all.nl> To: Vaibhav Gupta <vaibhavgupta40@gmail.com>, Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, bjorn@helgaas.com, Vaibhav Gupta <vaibhav.varodek@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org> Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH v1 3/6] [media] cx25821: use generic power management Date: Mon, 13 Jul 2020 12:03:21 +0200 [thread overview] Message-ID: <126d8fe6-1480-137c-ac64-d828a32b99f9@xs4all.nl> (raw) In-Reply-To: <20200629073604.205478-4-vaibhavgupta40@gmail.com> On 29/06/2020 09:36, Vaibhav Gupta wrote: > The .suspend() and .resume() callbacks are not defined for this driver. > Still, their power managemgement stucture can be easily upgraded to > gemeric, without affecting its normal behaviour. > > Hence, define them NULL and use struct dev_pm_ops type to bind them. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> > --- > drivers/media/pci/cx25821/cx25821-core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/pci/cx25821/cx25821-core.c b/drivers/media/pci/cx25821/cx25821-core.c > index 41be22ce66f3..59501939d741 100644 > --- a/drivers/media/pci/cx25821/cx25821-core.c > +++ b/drivers/media/pci/cx25821/cx25821-core.c > @@ -1369,14 +1369,18 @@ static const struct pci_device_id cx25821_pci_tbl[] = { > > MODULE_DEVICE_TABLE(pci, cx25821_pci_tbl); > > +#define cx25821_suspend NULL > +#define cx25821_resume NULL > + > +static SIMPLE_DEV_PM_OPS(cx25821_pm_ops, cx25821_suspend, cx25821_resume); > + > static struct pci_driver cx25821_pci_driver = { > .name = "cx25821", > .id_table = cx25821_pci_tbl, > .probe = cx25821_initdev, > .remove = cx25821_finidev, > /* TODO */ > - .suspend = NULL, > - .resume = NULL, > + .driver.pm = &cx25821_pm_ops, > }; Same question as for 2/6. Regards, Hans > > static int __init cx25821_init(void) > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-13 10:03 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-29 7:35 [Linux-kernel-mentees] [PATCH v1 0/6] [media] pci: " Vaibhav Gupta 2020-06-29 7:35 ` [Linux-kernel-mentees] [PATCH v1 1/6] [media] sta2x11: " Vaibhav Gupta 2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 2/6] [media] cx23885: " Vaibhav Gupta 2020-07-13 10:01 ` Hans Verkuil 2020-07-14 0:38 ` Bjorn Helgaas 2020-07-14 10:52 ` Vaibhav Gupta 2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 3/6] [media] cx25821: " Vaibhav Gupta 2020-07-13 10:03 ` Hans Verkuil [this message] 2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 4/6] [media] cx88: " Vaibhav Gupta 2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 5/6] [media] meye: " Vaibhav Gupta 2020-06-29 7:36 ` [Linux-kernel-mentees] [PATCH v1 6/6] [media] tw68: " Vaibhav Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=126d8fe6-1480-137c-ac64-d828a32b99f9@xs4all.nl \ --to=hverkuil@xs4all.nl \ --cc=bhelgaas@google.com \ --cc=bjorn@helgaas.com \ --cc=helgaas@kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=vaibhav.varodek@gmail.com \ --cc=vaibhavgupta40@gmail.com \ --subject='Re: [Linux-kernel-mentees] [PATCH v1 3/6] [media] cx25821: use generic power management' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).