From: "Deucher, Alexander" <Alexander.Deucher@amd.com>
To: Jaskaran Singh <jaskaransingh7654321@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Zhou, David\(ChunMing\)" <David1.Zhou@amd.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"Kuehling, Felix" <Felix.Kuehling@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"linux-kernel-mentees@lists.linuxfoundation.org"
<linux-kernel-mentees@lists.linuxfoundation.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation
Date: Fri, 1 Nov 2019 18:18:56 +0000 [thread overview]
Message-ID: <BN6SPR00MB1824AA701FC65A47786A30CF7620@BN6SPR00MB182.namprd12.prod.outlook.com> (raw)
Message-ID: <20191101181856.vxXLY5LYfhOW5put5CDf8g6TFZG3aYVQKTA0xWZo9-I@z> (raw)
In-Reply-To: <20191101163856.GA13800@localhost.localdomain>
[-- Attachment #1.1: Type: text/plain, Size: 1714 bytes --]
Thanks for the patch. This has already been fixed.
Alex
________________________________
From: Jaskaran Singh <jaskaransingh7654321@gmail.com>
Sent: Friday, November 1, 2019 12:38 PM
To: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org <linux-kernel-mentees@lists.linuxfoundation.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch>; Kuehling, Felix <Felix.Kuehling@amd.com>; Huang, Ray <Ray.Huang@amd.com>
Subject: [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation
The documentation for this function is missing the function parameter
"level", so add it. This fixes the following warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821:
warning: Function parameter or member 'level'
not described in 'amdgpu_vm_bo_param'
Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 5251352f5922..6f6a9be11d84 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev,
*
* @adev: amdgpu_device pointer
* @vm: requesting vm
+ * @level: VMPT level
* @bp: resulting BO allocation parameters
*/
static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm,
--
2.21.0
[-- Attachment #1.2: Type: text/html, Size: 3094 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2019-11-01 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 16:38 [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation jaskaransingh7654321
2019-11-01 16:38 ` Jaskaran Singh
2019-11-01 16:38 ` Jaskaran Singh
2019-11-01 18:18 ` Alexander.Deucher [this message]
2019-11-01 18:18 ` Deucher, Alexander
2019-11-01 18:18 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6SPR00MB1824AA701FC65A47786A30CF7620@BN6SPR00MB182.namprd12.prod.outlook.com \
--to=alexander.deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Ray.Huang@amd.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=jaskaransingh7654321@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).