* [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation
@ 2019-11-01 16:38 jaskaransingh7654321
2019-11-01 16:38 ` Jaskaran Singh
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: jaskaransingh7654321 @ 2019-11-01 16:38 UTC (permalink / raw)
The documentation for this function is missing the function parameter
"level", so add it. This fixes the following warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821:
warning: Function parameter or member 'level'
not described in 'amdgpu_vm_bo_param'
Signed-off-by: Jaskaran Singh <jaskaransingh7654321 at gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 5251352f5922..6f6a9be11d84 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev,
*
* @adev: amdgpu_device pointer
* @vm: requesting vm
+ * @level: VMPT level
* @bp: resulting BO allocation parameters
*/
static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm,
--
2.21.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation 2019-11-01 16:38 [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation jaskaransingh7654321 @ 2019-11-01 16:38 ` Jaskaran Singh 2019-11-01 16:38 ` Jaskaran Singh 2019-11-01 18:18 ` Alexander.Deucher 2 siblings, 0 replies; 6+ messages in thread From: Jaskaran Singh @ 2019-11-01 16:38 UTC (permalink / raw) The documentation for this function is missing the function parameter "level", so add it. This fixes the following warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' Signed-off-by: Jaskaran Singh <jaskaransingh7654321 at gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 5251352f5922..6f6a9be11d84 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev, * * @adev: amdgpu_device pointer * @vm: requesting vm + * @level: VMPT level * @bp: resulting BO allocation parameters */ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm, -- 2.21.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation 2019-11-01 16:38 [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation jaskaransingh7654321 2019-11-01 16:38 ` Jaskaran Singh @ 2019-11-01 16:38 ` Jaskaran Singh 2019-11-01 18:18 ` Alexander.Deucher 2 siblings, 0 replies; 6+ messages in thread From: Jaskaran Singh @ 2019-11-01 16:38 UTC (permalink / raw) To: linux-kernel Cc: David1.Zhou, airlied, Felix.Kuehling, ray.huang, daniel, alexander.deucher, linux-kernel-mentees, christian.koenig The documentation for this function is missing the function parameter "level", so add it. This fixes the following warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 5251352f5922..6f6a9be11d84 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev, * * @adev: amdgpu_device pointer * @vm: requesting vm + * @level: VMPT level * @bp: resulting BO allocation parameters */ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm, -- 2.21.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation 2019-11-01 16:38 [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation jaskaransingh7654321 2019-11-01 16:38 ` Jaskaran Singh 2019-11-01 16:38 ` Jaskaran Singh @ 2019-11-01 18:18 ` Alexander.Deucher 2019-11-01 18:18 ` Deucher, Alexander 2019-11-01 18:18 ` Deucher, Alexander 2 siblings, 2 replies; 6+ messages in thread From: Alexander.Deucher @ 2019-11-01 18:18 UTC (permalink / raw) Thanks for the patch. This has already been fixed. Alex ________________________________ From: Jaskaran Singh <jaskaransingh7654321 at gmail.com> Sent: Friday, November 1, 2019 12:38 PM To: linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org> Cc: linux-kernel-mentees at lists.linuxfoundation.org <linux-kernel-mentees at lists.linuxfoundation.org>; Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; airlied at linux.ie <airlied at linux.ie>; daniel at ffwll.ch <daniel at ffwll.ch>; Kuehling, Felix <Felix.Kuehling at amd.com>; Huang, Ray <Ray.Huang at amd.com> Subject: [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation The documentation for this function is missing the function parameter "level", so add it. This fixes the following warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' Signed-off-by: Jaskaran Singh <jaskaransingh7654321 at gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 5251352f5922..6f6a9be11d84 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev, * * @adev: amdgpu_device pointer * @vm: requesting vm + * @level: VMPT level * @bp: resulting BO allocation parameters */ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm, -- 2.21.0 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linuxfoundation.org/pipermail/linux-kernel-mentees/attachments/20191101/f71538de/attachment.html> ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation 2019-11-01 18:18 ` Alexander.Deucher @ 2019-11-01 18:18 ` Deucher, Alexander 2019-11-01 18:18 ` Deucher, Alexander 1 sibling, 0 replies; 6+ messages in thread From: Deucher, Alexander @ 2019-11-01 18:18 UTC (permalink / raw) To: Jaskaran Singh, linux-kernel Cc: Zhou, David(ChunMing), airlied, Kuehling, Felix, Huang, Ray, daniel, linux-kernel-mentees, Koenig, Christian [-- Attachment #1.1: Type: text/plain, Size: 1714 bytes --] Thanks for the patch. This has already been fixed. Alex ________________________________ From: Jaskaran Singh <jaskaransingh7654321@gmail.com> Sent: Friday, November 1, 2019 12:38 PM To: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> Cc: linux-kernel-mentees@lists.linuxfoundation.org <linux-kernel-mentees@lists.linuxfoundation.org>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie <airlied@linux.ie>; daniel@ffwll.ch <daniel@ffwll.ch>; Kuehling, Felix <Felix.Kuehling@amd.com>; Huang, Ray <Ray.Huang@amd.com> Subject: [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation The documentation for this function is missing the function parameter "level", so add it. This fixes the following warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' Signed-off-by: Jaskaran Singh <jaskaransingh7654321@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 5251352f5922..6f6a9be11d84 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev, * * @adev: amdgpu_device pointer * @vm: requesting vm + * @level: VMPT level * @bp: resulting BO allocation parameters */ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm, -- 2.21.0 [-- Attachment #1.2: Type: text/html, Size: 3094 bytes --] [-- Attachment #2: Type: text/plain, Size: 201 bytes --] _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation 2019-11-01 18:18 ` Alexander.Deucher 2019-11-01 18:18 ` Deucher, Alexander @ 2019-11-01 18:18 ` Deucher, Alexander 1 sibling, 0 replies; 6+ messages in thread From: Deucher, Alexander @ 2019-11-01 18:18 UTC (permalink / raw) Thanks for the patch. This has already been fixed. Alex ________________________________ From: Jaskaran Singh <jaskaransingh7654321@gmail.com> Sent: Friday, November 1, 2019 12:38 PM To: linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org> Cc: linux-kernel-mentees at lists.linuxfoundation.org <linux-kernel-mentees at lists.linuxfoundation.org>; Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhou, David(ChunMing) <David1.Zhou at amd.com>; airlied at linux.ie <airlied at linux.ie>; daniel at ffwll.ch <daniel at ffwll.ch>; Kuehling, Felix <Felix.Kuehling at amd.com>; Huang, Ray <Ray.Huang at amd.com> Subject: [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation The documentation for this function is missing the function parameter "level", so add it. This fixes the following warning: ./drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param' Signed-off-by: Jaskaran Singh <jaskaransingh7654321 at gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 5251352f5922..6f6a9be11d84 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c @@ -813,6 +813,7 @@ static int amdgpu_vm_clear_bo(struct amdgpu_device *adev, * * @adev: amdgpu_device pointer * @vm: requesting vm + * @level: VMPT level * @bp: resulting BO allocation parameters */ static void amdgpu_vm_bo_param(struct amdgpu_device *adev, struct amdgpu_vm *vm, -- 2.21.0 -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.linuxfoundation.org/pipermail/linux-kernel-mentees/attachments/20191101/f71538de/attachment.html> ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-01 18:19 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-01 16:38 [Linux-kernel-mentees] [PATCH] drivers: gpu: drm: amd: amdgpu: Add @level to amdgpu_vm_bo_param documentation jaskaransingh7654321 2019-11-01 16:38 ` Jaskaran Singh 2019-11-01 16:38 ` Jaskaran Singh 2019-11-01 18:18 ` Alexander.Deucher 2019-11-01 18:18 ` Deucher, Alexander 2019-11-01 18:18 ` Deucher, Alexander
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).