From: Joel Fernandes <joel@joelfernandes.org>
To: madhuparnabhowmik04@gmail.com
Cc: linux-nfs@vger.kernel.org, paulmck@kernel.org,
linux-kernel@vger.kernel.org, anna.schumaker@netapp.com,
rcu@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
trond.myklebust@hammerspace.com
Subject: Re: [Linux-kernel-mentees] [PATCH 2/2] fs: nfs: dir.c: Fix sparse error
Date: Fri, 6 Dec 2019 11:00:02 -0500 [thread overview]
Message-ID: <20191206160002.GB15547@google.com> (raw)
In-Reply-To: <20191206151640.10966-1-madhuparnabhowmik04@gmail.com>
+Paul, here is the dependent patch for the list_prev_rcu() patch Madhuparna
posted.
On Fri, Dec 06, 2019 at 08:46:40PM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> This patch fixes the following errors:
> fs/nfs/dir.c:2353:14: error: incompatible types in comparison expression (different address spaces):
> fs/nfs/dir.c:2353:14: struct list_head [noderef] <asn:4> *
> fs/nfs/dir.c:2353:14: struct list_head *
>
> caused due to directly accessing the prev pointer of
> a RCU protected list.
> Accessing the pointer using the macro list_prev_rcu() fixes this error.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> ---
> fs/nfs/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index e180033e35cf..2035254cc283 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -2350,7 +2350,7 @@ static int nfs_access_get_cached_rcu(struct inode *inode, const struct cred *cre
> rcu_read_lock();
> if (nfsi->cache_validity & NFS_INO_INVALID_ACCESS)
> goto out;
> - lh = rcu_dereference(nfsi->access_cache_entry_lru.prev);
> + lh = rcu_dereference(list_prev_rcu(&nfsi->access_cache_entry_lru));
> cache = list_entry(lh, struct nfs_access_entry, lru);
> if (lh == &nfsi->access_cache_entry_lru ||
> cred != cache->cred)
> --
> 2.17.1
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2019-12-06 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 15:16 [Linux-kernel-mentees] [PATCH 2/2] fs: nfs: dir.c: Fix sparse error madhuparnabhowmik04
2019-12-06 16:00 ` Joel Fernandes [this message]
2019-12-06 16:12 ` Paul E. McKenney
2019-12-06 16:02 ` Paul E. McKenney
2019-12-06 17:52 ` Trond Myklebust
2019-12-06 18:24 ` Paul E. McKenney
2019-12-06 18:28 ` Trond Myklebust
2019-12-06 18:45 ` Paul E. McKenney
2019-12-12 21:55 ` Joel Fernandes
2019-12-13 1:16 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206160002.GB15547@google.com \
--to=joel@joelfernandes.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=madhuparnabhowmik04@gmail.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).