Linux Kernel Mentees Archive on lore.kernel.org
 help / color / Atom feed
From: Jan Kara <jack@suse.cz>
To: Joel Fernandes <joel@joelfernandes.org>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	stable <stable@vger.kernel.org>, rcu <rcu@vger.kernel.org>,
	adilger.kernel@dilger.ca, Jan Kara <jack@suse.cz>,
	linux-ext4@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH V2] ext4: use rcu API in debug_print_tree
Date: Fri, 13 Dec 2019 20:49:43 +0100
Message-ID: <20191213194943.GA959@quack2.suse.cz> (raw)
In-Reply-To: <CAEXW_YQwrM6=u1gsij-5SL5+2n9Pk9HFEYdF_JWYjitLvr7Dcg@mail.gmail.com>

On Fri 13-12-19 10:11:50, Joel Fernandes wrote:
> On Fri, Dec 13, 2019 at 7:39 AM Phong Tran <tranmanphong@gmail.com> wrote:
> >
> > struct ext4_sb_info.system_blks was marked __rcu.
> > But access the pointer without using RCU lock and dereference.
> > Sparse warning with __rcu notation:
> >
> > block_validity.c:139:29: warning: incorrect type in argument 1 (different address spaces)
> > block_validity.c:139:29:    expected struct rb_root const *
> > block_validity.c:139:29:    got struct rb_root [noderef] <asn:4> *
> >
> > Reviewed-by: Jan Kara <jack@suse.cz>
> > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
> 
> Thanks Phong! Looks like a real bug fix caught thanks to Sparse. So
> let us mark for stable as well?

Well, not really. The code is active only with CONFIG_EXT4_DEBUG enabled
and in this case there's no race with remount (and thus sbi->system_blks
changing) possible. So the change is really only to silence the sparse
warning.

								Honza

> 
> - Joel
> 
> > ---
> >  fs/ext4/block_validity.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > ---
> > change log:
> > V2: Add Reviewed-by: Jan Kara <jack@suse.cz>
> >
> > diff --git a/fs/ext4/block_validity.c b/fs/ext4/block_validity.c
> > index d4d4fdfac1a6..1ee04e76bbe0 100644
> > --- a/fs/ext4/block_validity.c
> > +++ b/fs/ext4/block_validity.c
> > @@ -133,10 +133,13 @@ static void debug_print_tree(struct ext4_sb_info *sbi)
> >  {
> >         struct rb_node *node;
> >         struct ext4_system_zone *entry;
> > +       struct ext4_system_blocks *system_blks;
> >         int first = 1;
> >
> >         printk(KERN_INFO "System zones: ");
> > -       node = rb_first(&sbi->system_blks->root);
> > +       rcu_read_lock();
> > +       system_blks = rcu_dereference(sbi->system_blks);
> > +       node = rb_first(&system_blks->root);
> >         while (node) {
> >                 entry = rb_entry(node, struct ext4_system_zone, node);
> >                 printk(KERN_CONT "%s%llu-%llu", first ? "" : ", ",
> > @@ -144,6 +147,7 @@ static void debug_print_tree(struct ext4_sb_info *sbi)
> >                 first = 0;
> >                 node = rb_next(node);
> >         }
> > +       rcu_read_unlock();
> >         printk(KERN_CONT "\n");
> >  }
> >
> > --
> > 2.20.1
> >
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01  3:51 [Linux-kernel-mentees] [PATCH] " Phong Tran
2019-12-13 11:35 ` Jan Kara
2019-12-13 15:33   ` [Linux-kernel-mentees] [PATCH V2] " Phong Tran
2019-12-13 18:11     ` Joel Fernandes
2019-12-13 19:49       ` Jan Kara [this message]
2019-12-13 23:19         ` Joel Fernandes
2019-12-16  2:41     ` Theodore Y. Ts'o

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213194943.GA959@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=adilger.kernel@dilger.ca \
    --cc=joel@joelfernandes.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Kernel Mentees Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kernel-mentees/0 linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ https://lore.kernel.org/linux-kernel-mentees \
		linux-kernel-mentees@lists.linuxfoundation.org
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxfoundation.lists.linux-kernel-mentees


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git