From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59377C2D0DD for ; Tue, 31 Dec 2019 10:12:37 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E362206D9 for ; Tue, 31 Dec 2019 10:12:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E362206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mess.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 048CC85755; Tue, 31 Dec 2019 10:12:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RcWDIAfi0s2H; Tue, 31 Dec 2019 10:12:36 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id A06A6842CF; Tue, 31 Dec 2019 10:12:36 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8D04EC1D81; Tue, 31 Dec 2019 10:12:36 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id D4434C077D for ; Tue, 31 Dec 2019 10:12:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C113C85B5D for ; Tue, 31 Dec 2019 10:12:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RVlGV8S0YtaP for ; Tue, 31 Dec 2019 10:12:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from gofer.mess.org (gofer.mess.org [88.97.38.141]) by whitealder.osuosl.org (Postfix) with ESMTPS id 7E30B8559F for ; Tue, 31 Dec 2019 10:12:33 +0000 (UTC) Received: by gofer.mess.org (Postfix, from userid 1000) id 3DF4B11A001; Tue, 31 Dec 2019 10:12:31 +0000 (GMT) Date: Tue, 31 Dec 2019 10:12:31 +0000 From: Sean Young To: "Daniel W. S. Almeida" Message-ID: <20191231101230.GF24469@gofer.mess.org> References: <20191201161542.69535-1-dwlsalmeida@gmail.com> <20191201161542.69535-7-dwlsalmeida@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191201161542.69535-7-dwlsalmeida@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org, rfontana@redhat.com, tglx@linutronix.de, mchehab@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-media@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH 6/6] media: dvb_dummy_frontend: remove 'extern' keyword from declaration X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Hi Daniel, On Sun, Dec 01, 2019 at 01:15:42PM -0300, Daniel W. S. Almeida wrote: > From: "Daniel W. S. Almeida" > > Fix CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files > by removing it. > > Signed-off-by: Daniel W. S. Almeida > --- > drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.h b/drivers/media/dvb-frontends/dvb_dummy_fe.h > index 35efe2ce1a88..1c82338e0c8a 100644 > --- a/drivers/media/dvb-frontends/dvb_dummy_fe.h > +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.h > @@ -12,9 +12,9 @@ > #include > > #if IS_REACHABLE(CONFIG_DVB_DUMMY_FE) > -extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void); > -extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void); > -extern struct dvb_frontend *dvb_dummy_fe_qam_attach(void); > +struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void); > +struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void); > +struct dvb_frontend *dvb_dummy_fe_qam_attach(void); Please add these changes to your patch: "media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION" Every patch should pass the checkpatch --strict test by itself; you cannot fix checkpatch errors in a patch in a subsequent patch. Thanks, Sean > #else > static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void) > { > -- > 2.24.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees