Linux Kernel Mentees Archive on lore.kernel.org
 help / color / Atom feed
* [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
@ 2020-01-07 19:29 madhuparnabhowmik04
  2020-01-07 20:33 ` Jason Gunthorpe
  0 siblings, 1 reply; 20+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-07 19:29 UTC (permalink / raw)
  To: dennis.dalessandro, mike.marciniszyn, dledford, paulmck
  Cc: linux-rdma, linux-kernel, rcu, joel, linux-kernel-mentees

From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>

list_for_each_entry_rcu has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu.

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
---
 drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index 089e201d7550..e6abdbcb4ffb 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
 				       opa_get_lid(packet->dlid, 9B));
 		if (!mcast)
 			goto drop;
-		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
+		list_for_each_entry_rcu(p, &mcast->qp_list, list,
+					lock_is_held(&(ibp->rvp.lock).dep_map)) {
 			packet->qp = p->qp;
 			if (hfi1_do_pkey_check(packet))
 				goto drop;
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 19:29 [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking madhuparnabhowmik04
@ 2020-01-07 20:33 ` Jason Gunthorpe
  2020-01-08  8:05   ` madhuparnabhowmik04
                     ` (3 more replies)
  0 siblings, 4 replies; 20+ messages in thread
From: Jason Gunthorpe @ 2020-01-07 20:33 UTC (permalink / raw)
  To: madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, dledford, joel, linux-kernel-mentees

On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
>  				       opa_get_lid(packet->dlid, 9B));
>  		if (!mcast)
>  			goto drop;
> -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> +		list_for_each_entry_rcu(p, &mcast->qp_list, list,
> +					lock_is_held(&(ibp->rvp.lock).dep_map)) {

Why .dep_map? Does this compile?

Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 20:33 ` Jason Gunthorpe
@ 2020-01-08  8:05   ` madhuparnabhowmik04
  2020-01-08  8:08   ` madhuparnabhowmik04
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 20+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-08  8:05 UTC (permalink / raw)
  To: jgg, madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, dledford, joel, linux-kernel-mentees

From: Jason Gunthorpe <jgg@ziepe.ca>

On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
>  				       opa_get_lid(packet->dlid, 9B));
>  		if (!mcast)
>  			goto drop;
> -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> +		list_for_each_entry_rcu(p, &mcast->qp_list, list,
> +					lock_is_held(&(ibp->rvp.lock).dep_map)) {

Why .dep_map? Does this compile?

Alternatively, it can be lockdep_is_held(ibp->rvp.lock).
Please refer to the macro(link below) and let me know if the usage of lock_is_held()
in the patch is correct.

https://elixir.bootlin.com/linux/v5.5-rc2/source/include/linux/lockdep.h#L364

Thanks,
Madhuparna
Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 20:33 ` Jason Gunthorpe
  2020-01-08  8:05   ` madhuparnabhowmik04
@ 2020-01-08  8:08   ` madhuparnabhowmik04
  2020-01-09 18:10   ` Jason Gunthorpe
  2020-01-10 15:54   ` Joel Fernandes
  3 siblings, 0 replies; 20+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-08  8:08 UTC (permalink / raw)
  To: jgg, madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, dledford, joel, linux-kernel-mentees

From: madhuparnabhowmik04@gmail.com

From: Jason Gunthorpe <jgg@ziepe.ca>

On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..e6abdbcb4ffb 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
>  				       opa_get_lid(packet->dlid, 9B));
>  		if (!mcast)
>  			goto drop;
> -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> +		list_for_each_entry_rcu(p, &mcast->qp_list, list,
> +					lock_is_held(&(ibp->rvp.lock).dep_map)) {

Why .dep_map? Does this compile?

Yes, it compiles.

Alternatively, it can be lockdep_is_held(ibp->rvp.lock).
Please refer to the macro(link below) and let me know if the usage of lock_is_held()
in the patch is correct.

https://elixir.bootlin.com/linux/v5.5-rc2/source/include/linux/lockdep.h#L364

Thanks,
Madhuparna

Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 20:33 ` Jason Gunthorpe
  2020-01-08  8:05   ` madhuparnabhowmik04
  2020-01-08  8:08   ` madhuparnabhowmik04
@ 2020-01-09 18:10   ` Jason Gunthorpe
  2020-01-10 15:54   ` Joel Fernandes
  3 siblings, 0 replies; 20+ messages in thread
From: Jason Gunthorpe @ 2020-01-09 18:10 UTC (permalink / raw)
  To: madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, dledford, joel, linux-kernel-mentees

On Wed, Jan 08, 2020 at 01:38:50PM +0530, madhuparnabhowmik04@gmail.com wrote:

> Alternatively, it can be lockdep_is_held(ibp->rvp.lock).
> Please refer to the macro(link below) and let me know if the usage of lock_is_held()
> in the patch is correct.

lock_is_held is the normal way to write this

Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 20:33 ` Jason Gunthorpe
                     ` (2 preceding siblings ...)
  2020-01-09 18:10   ` Jason Gunthorpe
@ 2020-01-10 15:54   ` Joel Fernandes
  3 siblings, 0 replies; 20+ messages in thread
From: Joel Fernandes @ 2020-01-10 15:54 UTC (permalink / raw)
  To: madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, jgg, dledford, linux-kernel-mentees

On Wed, Jan 08, 2020 at 01:35:07PM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Jason Gunthorpe <jgg@ziepe.ca>
> 
> On Wed, Jan 08, 2020 at 12:59:12AM +0530, madhuparnabhowmik04@gmail.com wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> > 
> > list_for_each_entry_rcu has built-in RCU and lock checking.
> > Pass cond argument to list_for_each_entry_rcu.
> > 
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> >  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> > index 089e201d7550..e6abdbcb4ffb 100644
> > +++ b/drivers/infiniband/hw/hfi1/verbs.c
> > @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
> >  				       opa_get_lid(packet->dlid, 9B));
> >  		if (!mcast)
> >  			goto drop;
> > -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> > +		list_for_each_entry_rcu(p, &mcast->qp_list, list,
> > +					lock_is_held(&(ibp->rvp.lock).dep_map)) {
> 
> Why .dep_map? Does this compile?

Yeah, have you really compiled this? Don't send patches without at least
compile testing !!

> Alternatively, it can be lockdep_is_held(ibp->rvp.lock).
> Please refer to the macro(link below) and let me know if the usage of lock_is_held()
> in the patch is correct.
> 
> https://elixir.bootlin.com/linux/v5.5-rc2/source/include/linux/lockdep.h#L364

Please use lockdep_is_held(). Thanks.

thanks,

 - Joel

> 
> Thanks,
> Madhuparna
> Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-02-14 17:24         ` Dennis Dalessandro
@ 2020-02-14 17:32           ` Madhuparna Bhowmik
  0 siblings, 0 replies; 20+ messages in thread
From: Madhuparna Bhowmik @ 2020-02-14 17:32 UTC (permalink / raw)
  To: Dennis Dalessandro
  Cc: mike.marciniszyn, Paul E. McKenney, linux-rdma, linux-kernel,
	rcu, Jason Gunthorpe, Joel Fernandes, linux-kernel-mentees

[-- Attachment #1.1: Type: text/plain, Size: 3188 bytes --]

On Fri, Feb 14, 2020 at 10:55 PM Dennis Dalessandro <
dennis.dalessandro@intel.com> wrote:

> On 2/14/2020 10:43 AM, Madhuparna Bhowmik wrote:
> >
> >
> > On Wed, Jan 15, 2020 at 12:05 AM <madhuparnabhowmik04@gmail.com
> > <mailto:madhuparnabhowmik04@gmail.com>> wrote:
> >
> >     From: Dennis Dalessandro <dennis.dalessandro@intel.com
> >     <mailto:dennis.dalessandro@intel.com>>
> >
> >     On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
> >      > On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
> >      >> On Tue, Jan 14, 2020 at 09:53:45PM +0530,
> >      >> madhuparnabhowmik04@gmail.com
> >     <mailto:madhuparnabhowmik04@gmail.com> wrote:
> >      >>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com
> >     <mailto:madhuparnabhowmik04@gmail.com>>
> >      >>>
> >      >>> list_for_each_entry_rcu has built-in RCU and lock checking.
> >      >>> Pass cond argument to list_for_each_entry_rcu.
> >      >>>
> >      >>> Signed-off-by: Madhuparna Bhowmik
> >     <madhuparnabhowmik04@gmail.com <mailto:madhuparnabhowmik04@gmail.com
> >>
> >      >>>   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
> >      >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >      >>>
> >      >>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c
> >      >>> b/drivers/infiniband/hw/hfi1/verbs.c
> >      >>> index 089e201d7550..22f2d4fd2577 100644
> >      >>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> >      >>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct
> >      >>> hfi1_packet *packet,
> >      >>>                          opa_get_lid(packet->dlid, 9B));
> >      >>>           if (!mcast)
> >      >>>               goto drop;
> >      >>> -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> >      >>> +        list_for_each_entry_rcu(p, &mcast->qp_list, list,
> >      >>> lockdep_is_held(&(ibp->rvp.lock))) {
> >      >>
> >      >> Okay, this looks reasonable
> >      >>
> >      >> Mike, Dennis, is this the right lock to test?
> >      >>
> >      >
> >      > I'm looking at that right now actually, I don't think this is
> >     correct.
> >      > Wanted to talk to Mike before I send a response though.
> >      >
> >      > -Denny
> >
> >     That's definitely going to throw a ton of lock dep messages. It's not
> >     really the right lock either. Instead what we probably need to do is
> >     what we do in the non-multicast part of the code and take the
> >     rcu_read_lock().
> >
> >     I'd say hold off on this and we'll fix it right. Same goes for the
> >     qib one.
> >
> >     Alright, thank you for reviewing.
> >
> >     The rdmavt one though looks to be OK. I'll give it a test.
> >
> > Hi,
> > I just wanted to follow up on this.
> > Any updates?
> > Also, is the bug fixed now?
> >
> > Thank you,
> > Madhuparna
> >
> >     Thank you,
> >     Madhuparna
> >
> >     -Denny
> >
>
> I've got a patch going through internal discussion and testing for
> adding rcu read locking.
>
> The RDMAVT patch, I was OK with going in, I guess I just mentioned that
> in a reply rather than adding an RB tag. Let me go ahead and do that.
>
> Thank you very much for the update and Reviewed By.

Regards,
Madhuparna

-Denny
>

[-- Attachment #1.2: Type: text/html, Size: 5418 bytes --]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Feb 14, 2020 at 10:55 PM Dennis Dalessandro &lt;<a href="mailto:dennis.dalessandro@intel.com">dennis.dalessandro@intel.com</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 2/14/2020 10:43 AM, Madhuparna Bhowmik wrote:<br>
&gt; <br>
&gt; <br>
&gt; On Wed, Jan 15, 2020 at 12:05 AM &lt;<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a> <br>
&gt; &lt;mailto:<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>&gt;&gt; wrote:<br>
&gt; <br>
&gt;     From: Dennis Dalessandro &lt;<a href="mailto:dennis.dalessandro@intel.com" target="_blank">dennis.dalessandro@intel.com</a><br>
&gt;     &lt;mailto:<a href="mailto:dennis.dalessandro@intel.com" target="_blank">dennis.dalessandro@intel.com</a>&gt;&gt;<br>
&gt; <br>
&gt;     On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:<br>
&gt;      &gt; On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:<br>
&gt;      &gt;&gt; On Tue, Jan 14, 2020 at 09:53:45PM +0530,<br>
&gt;      &gt;&gt; <a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a><br>
&gt;     &lt;mailto:<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>&gt; wrote:<br>
&gt;      &gt;&gt;&gt; From: Madhuparna Bhowmik &lt;<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a><br>
&gt;     &lt;mailto:<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>&gt;&gt;<br>
&gt;      &gt;&gt;&gt;<br>
&gt;      &gt;&gt;&gt; list_for_each_entry_rcu has built-in RCU and lock checking.<br>
&gt;      &gt;&gt;&gt; Pass cond argument to list_for_each_entry_rcu.<br>
&gt;      &gt;&gt;&gt;<br>
&gt;      &gt;&gt;&gt; Signed-off-by: Madhuparna Bhowmik<br>
&gt;     &lt;<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a> &lt;mailto:<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>&gt;&gt;<br>
&gt;      &gt;&gt;&gt;   drivers/infiniband/hw/hfi1/verbs.c | 2 +-<br>
&gt;      &gt;&gt;&gt;   1 file changed, 1 insertion(+), 1 deletion(-)<br>
&gt;      &gt;&gt;&gt;<br>
&gt;      &gt;&gt;&gt; diff --git a/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt;      &gt;&gt;&gt; b/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt;      &gt;&gt;&gt; index 089e201d7550..22f2d4fd2577 100644<br>
&gt;      &gt;&gt;&gt; +++ b/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt;      &gt;&gt;&gt; @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct<br>
&gt;      &gt;&gt;&gt; hfi1_packet *packet,<br>
&gt;      &gt;&gt;&gt;                          opa_get_lid(packet-&gt;dlid, 9B));<br>
&gt;      &gt;&gt;&gt;           if (!mcast)<br>
&gt;      &gt;&gt;&gt;               goto drop;<br>
&gt;      &gt;&gt;&gt; -        list_for_each_entry_rcu(p, &amp;mcast-&gt;qp_list, list) {<br>
&gt;      &gt;&gt;&gt; +        list_for_each_entry_rcu(p, &amp;mcast-&gt;qp_list, list,<br>
&gt;      &gt;&gt;&gt; lockdep_is_held(&amp;(ibp-&gt;rvp.lock))) {<br>
&gt;      &gt;&gt;<br>
&gt;      &gt;&gt; Okay, this looks reasonable<br>
&gt;      &gt;&gt;<br>
&gt;      &gt;&gt; Mike, Dennis, is this the right lock to test?<br>
&gt;      &gt;&gt;<br>
&gt;      &gt;<br>
&gt;      &gt; I&#39;m looking at that right now actually, I don&#39;t think this is<br>
&gt;     correct.<br>
&gt;      &gt; Wanted to talk to Mike before I send a response though.<br>
&gt;      &gt;<br>
&gt;      &gt; -Denny<br>
&gt; <br>
&gt;     That&#39;s definitely going to throw a ton of lock dep messages. It&#39;s not<br>
&gt;     really the right lock either. Instead what we probably need to do is<br>
&gt;     what we do in the non-multicast part of the code and take the<br>
&gt;     rcu_read_lock().<br>
&gt; <br>
&gt;     I&#39;d say hold off on this and we&#39;ll fix it right. Same goes for the<br>
&gt;     qib one.<br>
&gt; <br>
&gt;     Alright, thank you for reviewing.<br>
&gt; <br>
&gt;     The rdmavt one though looks to be OK. I&#39;ll give it a test.<br>
&gt; <br>
&gt; Hi,<br>
&gt; I just wanted to follow up on this.<br>
&gt; Any updates?<br>
&gt; Also, is the bug fixed now?<br>
&gt; <br>
&gt; Thank you,<br>
&gt; Madhuparna<br>
&gt; <br>
&gt;     Thank you,<br>
&gt;     Madhuparna<br>
&gt; <br>
&gt;     -Denny<br>
&gt; <br>
<br>
I&#39;ve got a patch going through internal discussion and testing for <br>
adding rcu read locking.<br>
<br>
The RDMAVT patch, I was OK with going in, I guess I just mentioned that <br>
in a reply rather than adding an RB tag. Let me go ahead and do that.<br>
<br></blockquote><div>Thank you very much for the update and Reviewed By.</div><div><br></div><div>Regards,</div><div>Madhuparna</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-Denny<br>
</blockquote></div></div>

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-02-14 15:43       ` Madhuparna Bhowmik
@ 2020-02-14 17:24         ` Dennis Dalessandro
  2020-02-14 17:32           ` Madhuparna Bhowmik
  0 siblings, 1 reply; 20+ messages in thread
From: Dennis Dalessandro @ 2020-02-14 17:24 UTC (permalink / raw)
  To: Madhuparna Bhowmik, Jason Gunthorpe
  Cc: mike.marciniszyn, Paul E. McKenney, linux-rdma, linux-kernel,
	rcu, Joel Fernandes, linux-kernel-mentees

On 2/14/2020 10:43 AM, Madhuparna Bhowmik wrote:
> 
> 
> On Wed, Jan 15, 2020 at 12:05 AM <madhuparnabhowmik04@gmail.com 
> <mailto:madhuparnabhowmik04@gmail.com>> wrote:
> 
>     From: Dennis Dalessandro <dennis.dalessandro@intel.com
>     <mailto:dennis.dalessandro@intel.com>>
> 
>     On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
>      > On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
>      >> On Tue, Jan 14, 2020 at 09:53:45PM +0530,
>      >> madhuparnabhowmik04@gmail.com
>     <mailto:madhuparnabhowmik04@gmail.com> wrote:
>      >>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com
>     <mailto:madhuparnabhowmik04@gmail.com>>
>      >>>
>      >>> list_for_each_entry_rcu has built-in RCU and lock checking.
>      >>> Pass cond argument to list_for_each_entry_rcu.
>      >>>
>      >>> Signed-off-by: Madhuparna Bhowmik
>     <madhuparnabhowmik04@gmail.com <mailto:madhuparnabhowmik04@gmail.com>>
>      >>>   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
>      >>>   1 file changed, 1 insertion(+), 1 deletion(-)
>      >>>
>      >>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c
>      >>> b/drivers/infiniband/hw/hfi1/verbs.c
>      >>> index 089e201d7550..22f2d4fd2577 100644
>      >>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
>      >>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct
>      >>> hfi1_packet *packet,
>      >>>                          opa_get_lid(packet->dlid, 9B));
>      >>>           if (!mcast)
>      >>>               goto drop;
>      >>> -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
>      >>> +        list_for_each_entry_rcu(p, &mcast->qp_list, list,
>      >>> lockdep_is_held(&(ibp->rvp.lock))) {
>      >>
>      >> Okay, this looks reasonable
>      >>
>      >> Mike, Dennis, is this the right lock to test?
>      >>
>      >
>      > I'm looking at that right now actually, I don't think this is
>     correct.
>      > Wanted to talk to Mike before I send a response though.
>      >
>      > -Denny
> 
>     That's definitely going to throw a ton of lock dep messages. It's not
>     really the right lock either. Instead what we probably need to do is
>     what we do in the non-multicast part of the code and take the
>     rcu_read_lock().
> 
>     I'd say hold off on this and we'll fix it right. Same goes for the
>     qib one.
> 
>     Alright, thank you for reviewing.
> 
>     The rdmavt one though looks to be OK. I'll give it a test.
> 
> Hi,
> I just wanted to follow up on this.
> Any updates?
> Also, is the bug fixed now?
> 
> Thank you,
> Madhuparna
> 
>     Thank you,
>     Madhuparna
> 
>     -Denny
> 

I've got a patch going through internal discussion and testing for 
adding rcu read locking.

The RDMAVT patch, I was OK with going in, I guess I just mentioned that 
in a reply rather than adding an RB tag. Let me go ahead and do that.

-Denny
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 18:24     ` Dennis Dalessandro
                         ` (2 preceding siblings ...)
  2020-01-14 19:41       ` Jason Gunthorpe
@ 2020-02-14 15:43       ` Madhuparna Bhowmik
  2020-02-14 17:24         ` Dennis Dalessandro
  3 siblings, 1 reply; 20+ messages in thread
From: Madhuparna Bhowmik @ 2020-02-14 15:43 UTC (permalink / raw)
  To: dennis.dalessandro, Jason Gunthorpe, madhuparna bhowmik
  Cc: mike.marciniszyn, Paul E. McKenney, linux-rdma, linux-kernel,
	rcu, Joel Fernandes, linux-kernel-mentees

[-- Attachment #1.1: Type: text/plain, Size: 2096 bytes --]

On Wed, Jan 15, 2020 at 12:05 AM <madhuparnabhowmik04@gmail.com> wrote:

> From: Dennis Dalessandro <dennis.dalessandro@intel.com>
>
> On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
> > On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
> >> On Tue, Jan 14, 2020 at 09:53:45PM +0530,
> >> madhuparnabhowmik04@gmail.com wrote:
> >>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> >>>
> >>> list_for_each_entry_rcu has built-in RCU and lock checking.
> >>> Pass cond argument to list_for_each_entry_rcu.
> >>>
> >>> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> >>>   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
> >>>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c
> >>> b/drivers/infiniband/hw/hfi1/verbs.c
> >>> index 089e201d7550..22f2d4fd2577 100644
> >>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> >>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct
> >>> hfi1_packet *packet,
> >>>                          opa_get_lid(packet->dlid, 9B));
> >>>           if (!mcast)
> >>>               goto drop;
> >>> -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> >>> +        list_for_each_entry_rcu(p, &mcast->qp_list, list,
> >>> lockdep_is_held(&(ibp->rvp.lock))) {
> >>
> >> Okay, this looks reasonable
> >>
> >> Mike, Dennis, is this the right lock to test?
> >>
> >
> > I'm looking at that right now actually, I don't think this is correct.
> > Wanted to talk to Mike before I send a response though.
> >
> > -Denny
>
> That's definitely going to throw a ton of lock dep messages. It's not
> really the right lock either. Instead what we probably need to do is
> what we do in the non-multicast part of the code and take the
> rcu_read_lock().
>
> I'd say hold off on this and we'll fix it right. Same goes for the qib one.
>
> Alright, thank you for reviewing.
>
> The rdmavt one though looks to be OK. I'll give it a test.
>
> Hi,
I just wanted to follow up on this.
Any updates?
Also, is the bug fixed now?

Thank you,
Madhuparna



> Thank you,
> Madhuparna
>
> -Denny
>

[-- Attachment #1.2: Type: text/html, Size: 3465 bytes --]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div class="gmail_attr" dir="ltr">On Wed, Jan 15, 2020 at 12:05 AM &lt;<a href="mailto:madhuparnabhowmik04@gmail.com">madhuparnabhowmik04@gmail.com</a>&gt; wrote:<br></div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">From: Dennis Dalessandro &lt;<a target="_blank" href="mailto:dennis.dalessandro@intel.com">dennis.dalessandro@intel.com</a>&gt;<br>
<br>
On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:<br>
&gt; On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:<br>
&gt;&gt; On Tue, Jan 14, 2020 at 09:53:45PM +0530, <br>
&gt;&gt; <a target="_blank" href="mailto:madhuparnabhowmik04@gmail.com">madhuparnabhowmik04@gmail.com</a> wrote:<br>
&gt;&gt;&gt; From: Madhuparna Bhowmik &lt;<a target="_blank" href="mailto:madhuparnabhowmik04@gmail.com">madhuparnabhowmik04@gmail.com</a>&gt;<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; list_for_each_entry_rcu has built-in RCU and lock checking.<br>
&gt;&gt;&gt; Pass cond argument to list_for_each_entry_rcu.<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; Signed-off-by: Madhuparna Bhowmik &lt;<a target="_blank" href="mailto:madhuparnabhowmik04@gmail.com">madhuparnabhowmik04@gmail.com</a>&gt;<br>
&gt;&gt;&gt;   drivers/infiniband/hw/hfi1/verbs.c | 2 +-<br>
&gt;&gt;&gt;   1 file changed, 1 insertion(+), 1 deletion(-)<br>
&gt;&gt;&gt;<br>
&gt;&gt;&gt; diff --git a/drivers/infiniband/hw/hfi1/verbs.c <br>
&gt;&gt;&gt; b/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt;&gt;&gt; index 089e201d7550..22f2d4fd2577 100644<br>
&gt;&gt;&gt; +++ b/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt;&gt;&gt; @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct <br>
&gt;&gt;&gt; hfi1_packet *packet,<br>
&gt;&gt;&gt;                          opa_get_lid(packet-&gt;dlid, 9B));<br>
&gt;&gt;&gt;           if (!mcast)<br>
&gt;&gt;&gt;               goto drop;<br>
&gt;&gt;&gt; -        list_for_each_entry_rcu(p, &amp;mcast-&gt;qp_list, list) {<br>
&gt;&gt;&gt; +        list_for_each_entry_rcu(p, &amp;mcast-&gt;qp_list, list, <br>
&gt;&gt;&gt; lockdep_is_held(&amp;(ibp-&gt;rvp.lock))) {<br>
&gt;&gt;<br>
&gt;&gt; Okay, this looks reasonable<br>
&gt;&gt;<br>
&gt;&gt; Mike, Dennis, is this the right lock to test?<br>
&gt;&gt;<br>
&gt; <br>
&gt; I&#39;m looking at that right now actually, I don&#39;t think this is correct. <br>
&gt; Wanted to talk to Mike before I send a response though.<br>
&gt; <br>
&gt; -Denny<br>
<br>
That&#39;s definitely going to throw a ton of lock dep messages. It&#39;s not <br>
really the right lock either. Instead what we probably need to do is <br>
what we do in the non-multicast part of the code and take the <br>
rcu_read_lock().<br>
<br>
I&#39;d say hold off on this and we&#39;ll fix it right. Same goes for the qib one.<br>
<br>
Alright, thank you for reviewing.<br>
<br>
The rdmavt one though looks to be OK. I&#39;ll give it a test.<br>
<br></blockquote><div>Hi,</div><div>I just wanted to follow up on this.</div><div>Any updates?</div><div>Also, is the bug fixed now?</div><div><br></div><div>Thank you,</div><div>Madhuparna</div><div><br></div><div> </div><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote">
Thank you,<br>
Madhuparna<br>
<br>
-Denny<br>
</blockquote></div></div>

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 19:41       ` Jason Gunthorpe
@ 2020-01-14 19:46         ` Dennis Dalessandro
  0 siblings, 0 replies; 20+ messages in thread
From: Dennis Dalessandro @ 2020-01-14 19:46 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: mike.marciniszyn, paulmck, linux-rdma, linux-kernel, rcu, joel,
	linux-kernel-mentees

On 1/14/2020 2:41 PM, Jason Gunthorpe wrote:
> On Tue, Jan 14, 2020 at 01:24:00PM -0500, Dennis Dalessandro wrote:
>> On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
>>> On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
>>>> On Tue, Jan 14, 2020 at 09:53:45PM +0530,
>>>> madhuparnabhowmik04@gmail.com wrote:
>>>>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>>>>
>>>>> list_for_each_entry_rcu has built-in RCU and lock checking.
>>>>> Pass cond argument to list_for_each_entry_rcu.
>>>>>
>>>>> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>>>>    drivers/infiniband/hw/hfi1/verbs.c | 2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c
>>>>> b/drivers/infiniband/hw/hfi1/verbs.c
>>>>> index 089e201d7550..22f2d4fd2577 100644
>>>>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
>>>>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct
>>>>> hfi1_packet *packet,
>>>>>                           opa_get_lid(packet->dlid, 9B));
>>>>>            if (!mcast)
>>>>>                goto drop;
>>>>> -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
>>>>> +        list_for_each_entry_rcu(p, &mcast->qp_list, list,
>>>>> lockdep_is_held(&(ibp->rvp.lock))) {
>>>>
>>>> Okay, this looks reasonable
>>>>
>>>> Mike, Dennis, is this the right lock to test?
>>>>
>>>
>>> I'm looking at that right now actually, I don't think this is correct.
>>> Wanted to talk to Mike before I send a response though.
>>>
>>> -Denny
>>
>> That's definitely going to throw a ton of lock dep messages. It's not really
>> the right lock either. Instead what we probably need to do is what we do in
>> the non-multicast part of the code and take the rcu_read_lock().
> 
> Uh.. why is this using the _rcu varient without holding the rcu lock?
> That is quite wrong already.
>

Yep, seems like a bug to me. Patch forthcoming.

-Denny

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 18:24     ` Dennis Dalessandro
  2020-01-14 18:34       ` madhuparnabhowmik04
  2020-01-14 19:17       ` Joel Fernandes
@ 2020-01-14 19:41       ` Jason Gunthorpe
  2020-01-14 19:46         ` Dennis Dalessandro
  2020-02-14 15:43       ` Madhuparna Bhowmik
  3 siblings, 1 reply; 20+ messages in thread
From: Jason Gunthorpe @ 2020-01-14 19:41 UTC (permalink / raw)
  To: Dennis Dalessandro
  Cc: mike.marciniszyn, paulmck, linux-rdma, linux-kernel, rcu, joel,
	linux-kernel-mentees

On Tue, Jan 14, 2020 at 01:24:00PM -0500, Dennis Dalessandro wrote:
> On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
> > On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
> > > On Tue, Jan 14, 2020 at 09:53:45PM +0530,
> > > madhuparnabhowmik04@gmail.com wrote:
> > > > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> > > > 
> > > > list_for_each_entry_rcu has built-in RCU and lock checking.
> > > > Pass cond argument to list_for_each_entry_rcu.
> > > > 
> > > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> > > >   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/infiniband/hw/hfi1/verbs.c
> > > > b/drivers/infiniband/hw/hfi1/verbs.c
> > > > index 089e201d7550..22f2d4fd2577 100644
> > > > +++ b/drivers/infiniband/hw/hfi1/verbs.c
> > > > @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct
> > > > hfi1_packet *packet,
> > > >                          opa_get_lid(packet->dlid, 9B));
> > > >           if (!mcast)
> > > >               goto drop;
> > > > -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> > > > +        list_for_each_entry_rcu(p, &mcast->qp_list, list,
> > > > lockdep_is_held(&(ibp->rvp.lock))) {
> > > 
> > > Okay, this looks reasonable
> > > 
> > > Mike, Dennis, is this the right lock to test?
> > > 
> > 
> > I'm looking at that right now actually, I don't think this is correct.
> > Wanted to talk to Mike before I send a response though.
> > 
> > -Denny
> 
> That's definitely going to throw a ton of lock dep messages. It's not really
> the right lock either. Instead what we probably need to do is what we do in
> the non-multicast part of the code and take the rcu_read_lock().

Uh.. why is this using the _rcu varient without holding the rcu lock?
That is quite wrong already.

Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 18:24     ` Dennis Dalessandro
  2020-01-14 18:34       ` madhuparnabhowmik04
@ 2020-01-14 19:17       ` Joel Fernandes
  2020-01-14 19:41       ` Jason Gunthorpe
  2020-02-14 15:43       ` Madhuparna Bhowmik
  3 siblings, 0 replies; 20+ messages in thread
From: Joel Fernandes @ 2020-01-14 19:17 UTC (permalink / raw)
  To: madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, Jason Gunthorpe, linux-kernel-mentees

On Wed, Jan 15, 2020 at 12:04:58AM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Dennis Dalessandro <dennis.dalessandro@intel.com>
> 
> On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
> > On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
> > > On Tue, Jan 14, 2020 at 09:53:45PM +0530,
> > > madhuparnabhowmik04@gmail.com wrote:
> > > > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> > > > 
> > > > list_for_each_entry_rcu has built-in RCU and lock checking.
> > > > Pass cond argument to list_for_each_entry_rcu.
> > > > 
> > > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> > > >   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
> > > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/infiniband/hw/hfi1/verbs.c
> > > > b/drivers/infiniband/hw/hfi1/verbs.c
> > > > index 089e201d7550..22f2d4fd2577 100644
> > > > +++ b/drivers/infiniband/hw/hfi1/verbs.c
> > > > @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct
> > > > hfi1_packet *packet,
> > > >                          opa_get_lid(packet->dlid, 9B));
> > > >           if (!mcast)
> > > >               goto drop;
> > > > -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> > > > +        list_for_each_entry_rcu(p, &mcast->qp_list, list,
> > > > lockdep_is_held(&(ibp->rvp.lock))) {
> > > 
> > > Okay, this looks reasonable
> > > 
> > > Mike, Dennis, is this the right lock to test?
> > > 
> > 
> > I'm looking at that right now actually, I don't think this is correct.
> > Wanted to talk to Mike before I send a response though.
> > 
> > -Denny
> 
> That's definitely going to throw a ton of lock dep messages. It's not really
> the right lock either. Instead what we probably need to do is what we do in
> the non-multicast part of the code and take the rcu_read_lock().
> 
> I'd say hold off on this and we'll fix it right. Same goes for the qib one.
> 
> Alright, thank you for reviewing.
> 
> The rdmavt one though looks to be OK. I'll give it a test.

Madhuparna, there seems to be an issue with your mail client where it is not
quoting text correctly, either there is a '>' missing or there are too many.
Can you look into it and figure what's wrong with it?

thanks,

 - Joel

> 
> Thank you,
> Madhuparna
> 
> -Denny
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 18:24     ` Dennis Dalessandro
@ 2020-01-14 18:34       ` madhuparnabhowmik04
  2020-01-14 19:17       ` Joel Fernandes
                         ` (2 subsequent siblings)
  3 siblings, 0 replies; 20+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-14 18:34 UTC (permalink / raw)
  To: dennis.dalessandro, Jason Gunthorpe, madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, linux-kernel, rcu, joel,
	linux-kernel-mentees

From: Dennis Dalessandro <dennis.dalessandro@intel.com>

On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
> On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
>> On Tue, Jan 14, 2020 at 09:53:45PM +0530, 
>> madhuparnabhowmik04@gmail.com wrote:
>>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>>
>>> list_for_each_entry_rcu has built-in RCU and lock checking.
>>> Pass cond argument to list_for_each_entry_rcu.
>>>
>>> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>>   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c 
>>> b/drivers/infiniband/hw/hfi1/verbs.c
>>> index 089e201d7550..22f2d4fd2577 100644
>>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
>>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct 
>>> hfi1_packet *packet,
>>>                          opa_get_lid(packet->dlid, 9B));
>>>           if (!mcast)
>>>               goto drop;
>>> -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
>>> +        list_for_each_entry_rcu(p, &mcast->qp_list, list, 
>>> lockdep_is_held(&(ibp->rvp.lock))) {
>>
>> Okay, this looks reasonable
>>
>> Mike, Dennis, is this the right lock to test?
>>
> 
> I'm looking at that right now actually, I don't think this is correct. 
> Wanted to talk to Mike before I send a response though.
> 
> -Denny

That's definitely going to throw a ton of lock dep messages. It's not 
really the right lock either. Instead what we probably need to do is 
what we do in the non-multicast part of the code and take the 
rcu_read_lock().

I'd say hold off on this and we'll fix it right. Same goes for the qib one.

Alright, thank you for reviewing.

The rdmavt one though looks to be OK. I'll give it a test.

Thank you,
Madhuparna

-Denny
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 17:00   ` Dennis Dalessandro
@ 2020-01-14 18:24     ` Dennis Dalessandro
  2020-01-14 18:34       ` madhuparnabhowmik04
                         ` (3 more replies)
  0 siblings, 4 replies; 20+ messages in thread
From: Dennis Dalessandro @ 2020-01-14 18:24 UTC (permalink / raw)
  To: Jason Gunthorpe, madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, linux-kernel, rcu, joel,
	linux-kernel-mentees

On 1/14/2020 12:00 PM, Dennis Dalessandro wrote:
> On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
>> On Tue, Jan 14, 2020 at 09:53:45PM +0530, 
>> madhuparnabhowmik04@gmail.com wrote:
>>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>>
>>> list_for_each_entry_rcu has built-in RCU and lock checking.
>>> Pass cond argument to list_for_each_entry_rcu.
>>>
>>> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>>   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c 
>>> b/drivers/infiniband/hw/hfi1/verbs.c
>>> index 089e201d7550..22f2d4fd2577 100644
>>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
>>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct 
>>> hfi1_packet *packet,
>>>                          opa_get_lid(packet->dlid, 9B));
>>>           if (!mcast)
>>>               goto drop;
>>> -        list_for_each_entry_rcu(p, &mcast->qp_list, list) {
>>> +        list_for_each_entry_rcu(p, &mcast->qp_list, list, 
>>> lockdep_is_held(&(ibp->rvp.lock))) {
>>
>> Okay, this looks reasonable
>>
>> Mike, Dennis, is this the right lock to test?
>>
> 
> I'm looking at that right now actually, I don't think this is correct. 
> Wanted to talk to Mike before I send a response though.
> 
> -Denny

That's definitely going to throw a ton of lock dep messages. It's not 
really the right lock either. Instead what we probably need to do is 
what we do in the non-multicast part of the code and take the 
rcu_read_lock().

I'd say hold off on this and we'll fix it right. Same goes for the qib one.

The rdmavt one though looks to be OK. I'll give it a test.

-Denny
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 16:57 ` Jason Gunthorpe
@ 2020-01-14 17:00   ` Dennis Dalessandro
  2020-01-14 18:24     ` Dennis Dalessandro
  0 siblings, 1 reply; 20+ messages in thread
From: Dennis Dalessandro @ 2020-01-14 17:00 UTC (permalink / raw)
  To: Jason Gunthorpe, madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, linux-kernel, rcu, joel,
	linux-kernel-mentees

On 1/14/2020 11:57 AM, Jason Gunthorpe wrote:
> On Tue, Jan 14, 2020 at 09:53:45PM +0530, madhuparnabhowmik04@gmail.com wrote:
>> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>
>> list_for_each_entry_rcu has built-in RCU and lock checking.
>> Pass cond argument to list_for_each_entry_rcu.
>>
>> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>>   drivers/infiniband/hw/hfi1/verbs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
>> index 089e201d7550..22f2d4fd2577 100644
>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
>> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
>>   				       opa_get_lid(packet->dlid, 9B));
>>   		if (!mcast)
>>   			goto drop;
>> -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
>> +		list_for_each_entry_rcu(p, &mcast->qp_list, list, lockdep_is_held(&(ibp->rvp.lock))) {
> 
> Okay, this looks reasonable
> 
> Mike, Dennis, is this the right lock to test?
> 

I'm looking at that right now actually, I don't think this is correct. 
Wanted to talk to Mike before I send a response though.

-Denny
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-14 16:23 madhuparnabhowmik04
@ 2020-01-14 16:57 ` Jason Gunthorpe
  2020-01-14 17:00   ` Dennis Dalessandro
  0 siblings, 1 reply; 20+ messages in thread
From: Jason Gunthorpe @ 2020-01-14 16:57 UTC (permalink / raw)
  To: madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, joel, linux-kernel-mentees

On Tue, Jan 14, 2020 at 09:53:45PM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>  drivers/infiniband/hw/hfi1/verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..22f2d4fd2577 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
>  				       opa_get_lid(packet->dlid, 9B));
>  		if (!mcast)
>  			goto drop;
> -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> +		list_for_each_entry_rcu(p, &mcast->qp_list, list, lockdep_is_held(&(ibp->rvp.lock))) {

Okay, this looks reasonable

Mike, Dennis, is this the right lock to test?

Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
@ 2020-01-14 16:23 madhuparnabhowmik04
  2020-01-14 16:57 ` Jason Gunthorpe
  0 siblings, 1 reply; 20+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-14 16:23 UTC (permalink / raw)
  To: mike.marciniszyn, dennis.dalessandro, jgg, paulmck
  Cc: linux-rdma, linux-kernel, rcu, joel, linux-kernel-mentees

From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>

list_for_each_entry_rcu has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu.

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
---
 drivers/infiniband/hw/hfi1/verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index 089e201d7550..22f2d4fd2577 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -515,7 +515,7 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
 				       opa_get_lid(packet->dlid, 9B));
 		if (!mcast)
 			goto drop;
-		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
+		list_for_each_entry_rcu(p, &mcast->qp_list, list, lockdep_is_held(&(ibp->rvp.lock))) {
 			packet->qp = p->qp;
 			if (hfi1_do_pkey_check(packet))
 				goto drop;
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 18:26 ` Jason Gunthorpe
@ 2020-01-07 18:35   ` Madhuparna Bhowmik
  0 siblings, 0 replies; 20+ messages in thread
From: Madhuparna Bhowmik @ 2020-01-07 18:35 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: mike.marciniszyn, Paul E. McKenney, linux-rdma,
	dennis.dalessandro, linux-kernel, rcu, dledford, Joel Fernandes,
	linux-kernel-mentees

[-- Attachment #1.1: Type: text/plain, Size: 1433 bytes --]

On Tue, Jan 7, 2020 at 11:56 PM Jason Gunthorpe <jgg@ziepe.ca> wrote:

> On Tue, Jan 07, 2020 at 11:05:08PM +0530, madhuparnabhowmik04@gmail.com
> wrote:
> > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> >
> > list_for_each_entry_rcu has built-in RCU and lock checking.
> > Pass cond argument to list_for_each_entry_rcu.
> >
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> >  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/verbs.c
> b/drivers/infiniband/hw/hfi1/verbs.c
> > index 089e201d7550..cab2ff185240 100644
> > +++ b/drivers/infiniband/hw/hfi1/verbs.c
> > @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct
> hfi1_packet *packet,
> >                                      opa_get_lid(packet->dlid, 9B));
> >               if (!mcast)
> >                       goto drop;
> > -             list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> > +             list_for_each_entry_rcu(p, &mcast->qp_list, list
> > +
>  lock_is_held(&(ibp->rvp.lock).dep_map)) {
>
> This is missing a ',' and isn't indented properly. Does it even
> compile?
>
> I am really sorry about this, I will resend this patch.
Yes, it compiles, though I guess after testing I edited it by mistake.

Thanks,
Madhuparna


> The idea seems sound though.
>
> Jason
>
[-- Attachment #1.2: Type: text/html, Size: 2728 bytes --]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jan 7, 2020 at 11:56 PM Jason Gunthorpe &lt;<a href="mailto:jgg@ziepe.ca">jgg@ziepe.ca</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jan 07, 2020 at 11:05:08PM +0530, <a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a> wrote:<br>
&gt; From: Madhuparna Bhowmik &lt;<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>&gt;<br>
&gt; <br>
&gt; list_for_each_entry_rcu has built-in RCU and lock checking.<br>
&gt; Pass cond argument to list_for_each_entry_rcu.<br>
&gt; <br>
&gt; Signed-off-by: Madhuparna Bhowmik &lt;<a href="mailto:madhuparnabhowmik04@gmail.com" target="_blank">madhuparnabhowmik04@gmail.com</a>&gt;<br>
&gt;  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-<br>
&gt;  1 file changed, 2 insertions(+), 1 deletion(-)<br>
&gt; <br>
&gt; diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt; index 089e201d7550..cab2ff185240 100644<br>
&gt; +++ b/drivers/infiniband/hw/hfi1/verbs.c<br>
&gt; @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,<br>
&gt;                                      opa_get_lid(packet-&gt;dlid, 9B));<br>
&gt;               if (!mcast)<br>
&gt;                       goto drop;<br>
&gt; -             list_for_each_entry_rcu(p, &amp;mcast-&gt;qp_list, list) {<br>
&gt; +             list_for_each_entry_rcu(p, &amp;mcast-&gt;qp_list, list<br>
&gt; +                                                             lock_is_held(&amp;(ibp-&gt;rvp.lock).dep_map)) {<br>
<br>
This is missing a &#39;,&#39; and isn&#39;t indented properly. Does it even<br>
compile?<br>
<br></blockquote><div>I am really sorry about this, I will resend this patch.</div><div>Yes, it compiles, though I guess after testing I edited it by mistake.</div><div><br></div><div>Thanks,</div><div>Madhuparna</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
The idea seems sound though.<br>
<br>
Jason<br>
</blockquote></div></div><div hspace="streak-pt-mark" style="max-height:1px"><img alt="" style="width:0px;max-height:0px;overflow:hidden" src="https://mailfoogae.appspot.com/t?sender=abWFkaHVwYXJuYWJob3dtaWswNEBnbWFpbC5jb20%3D&amp;type=zerocontent&amp;guid=1d0a4aad-2a9e-4301-b60e-98b484865aa5"><font color="#ffffff" size="1">ᐧ</font></div>

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
  2020-01-07 17:35 madhuparnabhowmik04
@ 2020-01-07 18:26 ` Jason Gunthorpe
  2020-01-07 18:35   ` Madhuparna Bhowmik
  0 siblings, 1 reply; 20+ messages in thread
From: Jason Gunthorpe @ 2020-01-07 18:26 UTC (permalink / raw)
  To: madhuparnabhowmik04
  Cc: mike.marciniszyn, paulmck, linux-rdma, dennis.dalessandro,
	linux-kernel, rcu, dledford, joel, linux-kernel-mentees

On Tue, Jan 07, 2020 at 11:05:08PM +0530, madhuparnabhowmik04@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>  drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index 089e201d7550..cab2ff185240 100644
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
>  				       opa_get_lid(packet->dlid, 9B));
>  		if (!mcast)
>  			goto drop;
> -		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
> +		list_for_each_entry_rcu(p, &mcast->qp_list, list
> +								lock_is_held(&(ibp->rvp.lock).dep_map)) {

This is missing a ',' and isn't indented properly. Does it even
compile?

The idea seems sound though.

Jason
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

* [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking
@ 2020-01-07 17:35 madhuparnabhowmik04
  2020-01-07 18:26 ` Jason Gunthorpe
  0 siblings, 1 reply; 20+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-07 17:35 UTC (permalink / raw)
  To: dennis.dalessandro, mike.marciniszyn, dledford, paulmck
  Cc: linux-rdma, linux-kernel, rcu, joel, linux-kernel-mentees

From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>

list_for_each_entry_rcu has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu.

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
---
 drivers/infiniband/hw/hfi1/verbs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index 089e201d7550..cab2ff185240 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -515,7 +515,8 @@ static inline void hfi1_handle_packet(struct hfi1_packet *packet,
 				       opa_get_lid(packet->dlid, 9B));
 		if (!mcast)
 			goto drop;
-		list_for_each_entry_rcu(p, &mcast->qp_list, list) {
+		list_for_each_entry_rcu(p, &mcast->qp_list, list
+								lock_is_held(&(ibp->rvp.lock).dep_map)) {
 			packet->qp = p->qp;
 			if (hfi1_do_pkey_check(packet))
 				goto drop;
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, back to index

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-07 19:29 [Linux-kernel-mentees] [PATCH 1/3] infiniband: hw: hfi1: verbs.c: Use built-in RCU list checking madhuparnabhowmik04
2020-01-07 20:33 ` Jason Gunthorpe
2020-01-08  8:05   ` madhuparnabhowmik04
2020-01-08  8:08   ` madhuparnabhowmik04
2020-01-09 18:10   ` Jason Gunthorpe
2020-01-10 15:54   ` Joel Fernandes
  -- strict thread matches above, loose matches on Subject: below --
2020-01-14 16:23 madhuparnabhowmik04
2020-01-14 16:57 ` Jason Gunthorpe
2020-01-14 17:00   ` Dennis Dalessandro
2020-01-14 18:24     ` Dennis Dalessandro
2020-01-14 18:34       ` madhuparnabhowmik04
2020-01-14 19:17       ` Joel Fernandes
2020-01-14 19:41       ` Jason Gunthorpe
2020-01-14 19:46         ` Dennis Dalessandro
2020-02-14 15:43       ` Madhuparna Bhowmik
2020-02-14 17:24         ` Dennis Dalessandro
2020-02-14 17:32           ` Madhuparna Bhowmik
2020-01-07 17:35 madhuparnabhowmik04
2020-01-07 18:26 ` Jason Gunthorpe
2020-01-07 18:35   ` Madhuparna Bhowmik

Linux Kernel Mentees Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kernel-mentees/0 linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ https://lore.kernel.org/linux-kernel-mentees \
		linux-kernel-mentees@lists.linuxfoundation.org
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxfoundation.lists.linux-kernel-mentees


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git