From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 443BBC33CAE for ; Tue, 14 Jan 2020 03:00:44 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C3262084D for ; Tue, 14 Jan 2020 03:00:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VtK5kb1I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C3262084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id D2A9185B7C; Tue, 14 Jan 2020 03:00:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sN6ax0zUCXup; Tue, 14 Jan 2020 03:00:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 1FC50854E5; Tue, 14 Jan 2020 03:00:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0EAADC18DD; Tue, 14 Jan 2020 03:00:43 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 62623C077D for ; Tue, 14 Jan 2020 03:00:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 501A885BDF for ; Tue, 14 Jan 2020 03:00:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NBy9A3IhiYJN for ; Tue, 14 Jan 2020 03:00:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by whitealder.osuosl.org (Postfix) with ESMTPS id 644F584FC0 for ; Tue, 14 Jan 2020 03:00:40 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id s94so459881pjc.1 for ; Mon, 13 Jan 2020 19:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Xw77Nj8XUDXZQNK7NNDsnZyCzzV6HvnWRz+soLowYlo=; b=VtK5kb1IIXzAZGv5xfHcXoUA1l/Ad6CPQ9LUKhr+RoI7TeYws3etYYok+4TRX4ZIJC wDmYyPNesscKL7dJTvpH9NWKzONlXQSHjS/LK+kBhzuHjODJXMK5gUAJ56lBcDYA957F rVNYNjraamPxQlGrJR/UrQuBnJERHHToi6T0q/zZuyohqY5DQn+0WLFUkYv36lzpRoVe WqBgHdLDe9964l4TI+9CM59mxiq+oCrhI6vw4sq7UvS/plJckPHwO6dr6mUVLINMp7kS 0VUkVeQSnKZo/nscboNpuZNw6tXGbRZnPEf+ulBgyjBoJuvhMj2e/nEV5FFA30Yp7JnY kHVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xw77Nj8XUDXZQNK7NNDsnZyCzzV6HvnWRz+soLowYlo=; b=ev9MkXagHsOX2H2NGcLFEOcxnE2Z8/NNQdx4iCb7XWM5Y3AT+t9EaflchwCyXOEUg4 59sg3Qd4Fd2yUwx09WHayxRrFzhCul/LRbMkVif3q3gBJmo5eQ4l/AbAst9HVcQPQ8Ev FCYmEJiZyL8ZOXyPLHUc/FNwrCZ1zV4nPep0sBbgtskuCn0ztRsVEcJwFw3VZXfB4ysQ F5PXOGECDB22MENdYZeVF2DjjnSzUhwbXItc+qR7IUQCeuMaE43GALdWd5761qA8Ja1R GBIzXcDKGNXBc4Mc1muibgU3k5cWc/tz4N5KZTS6txfdDIBXwUOOb6jwTuU1nlTJ2fXY HhDg== X-Gm-Message-State: APjAAAXdZbgf+nPSPso7nIfVIj1EIEUorrrYNysOCZcAPibXUU9n57EQ twwWgAdSgVHPDDI4v77VTBQ= X-Google-Smtp-Source: APXvYqxl7syTqoq0VTOABZalLn1oIB8fgP/NolrZjvoq7aZBcSgtjuvP8BEuWB/LPeAtmsTvGDIaWQ== X-Received: by 2002:a17:902:124:: with SMTP id 33mr17206920plb.115.1578970839903; Mon, 13 Jan 2020 19:00:39 -0800 (PST) Received: from workstation-portable ([103.211.17.159]) by smtp.gmail.com with ESMTPSA id c34sm14721134pgc.61.2020.01.13.19.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 19:00:39 -0800 (PST) Date: Tue, 14 Jan 2020 08:30:30 +0530 From: Amol Grover To: kbuild test robot Message-ID: <20200114030030.GB2559@workstation-portable> References: <20200110164709.26741-1-frextrite@gmail.com> <202001121358.YVbD4V9l%lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202001121358.YVbD4V9l%lkp@intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) Cc: kbuild-all@lists.01.org, Corey Minyard , Arnd Bergmann , "Paul E . McKenney" , linux-kernel@vger.kernel.org, Joel Fernandes , openipmi-developer@lists.sourceforge.net, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH v2] drivers: char: ipmi: ipmi_msghandler: Pass lockdep expression to RCU lists X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Sun, Jan 12, 2020 at 01:25:58PM +0800, kbuild test robot wrote: > Hi Amol, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on char-misc/char-misc-testing] > [also build test WARNING on ipmi/for-next arm-soc/for-next v5.5-rc5] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Amol-Grover/drivers-char-ipmi-ipmi_msghandler-Pass-lockdep-expression-to-RCU-lists/20200111-081002 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 16bb7abc4a6b9defffa294e4dc28383e62a1dbcf > config: x86_64-randconfig-a003-20200109 (attached as .config) > compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All warnings (new ones prefixed by >>): > > In file included from include/linux/export.h:43:0, > from include/linux/linkage.h:7, > from include/linux/kernel.h:8, > from include/linux/list.h:9, > from include/linux/module.h:12, > from drivers/char/ipmi/ipmi_msghandler.c:17: > drivers/char/ipmi/ipmi_msghandler.c: In function 'find_cmd_rcvr': > include/linux/rculist.h:53:25: warning: suggest parentheses around '&&' within '||' [-Wparentheses] > RCU_LOCKDEP_WARN(!cond && !rcu_read_lock_any_held(), \ > ^ As mentioned above, RCU_LOCKDEP_WARN macro is called from __list_check_rcu with 2 parameters 1. !cond && !rcu_read_lock_any_held() 2. The message to display incase there is a lockdep warning. However, if I pass the lockdep checking condition as: list_for_each_entry_rcu(ptr, list, head, lockdep_is_held(&some_lock) || rcu_read_lock_held()) this trickles down to __list_check_rcu and then finally to RCU_LOCKDEP_WARN as (here cond is `lockdep_is_held(&some_lock) || rcu_read_lock_held()`): RCU_LOCKDEP_WARN(!lockdep_is_held(&some_lock) || rcu_read_lock_held() && !rcu_read_lock_any_held()) which according to operator precedence (I hopefully got them right) would always evaluate to true if we are in an RCU read-side critical section (without a lock), and hence, result in a false-positive lockdep warning. This could be easily solved by putting `cond` inside brackets as it is correctly done in RCU_LOCKDEP_WARN macro but not in __list_check_rcu macro. Is that so, or did I miss something? Secondly, since there is already a condition that checks for RCU read-side critical section, the extra `rcu_read_lock_held()` we supply is sort of redundant and can be skipped right? Thanks Amol > include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' > #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) > ^ > >> include/linux/rcupdate.h:263:3: note: in expansion of macro 'if' > if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \ > ^ > >> include/linux/rculist.h:53:2: note: in expansion of macro 'RCU_LOCKDEP_WARN' > RCU_LOCKDEP_WARN(!cond && !rcu_read_lock_any_held(), \ > ^ > include/linux/rculist.h:371:7: note: in expansion of macro '__list_check_rcu' > for (__list_check_rcu(dummy, ## cond, 0), \ > ^ > drivers/char/ipmi/ipmi_msghandler.c:1607:2: note: in expansion of macro 'list_for_each_entry_rcu' > list_for_each_entry_rcu(rcvr, &intf->cmd_rcvrs, link, > ^ > include/linux/rculist.h:53:25: warning: suggest parentheses around '&&' within '||' [-Wparentheses] > RCU_LOCKDEP_WARN(!cond && !rcu_read_lock_any_held(), \ > ^ > include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' > #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) > ^ > >> include/linux/rcupdate.h:263:3: note: in expansion of macro 'if' > if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \ > ^ > >> include/linux/rculist.h:53:2: note: in expansion of macro 'RCU_LOCKDEP_WARN' > RCU_LOCKDEP_WARN(!cond && !rcu_read_lock_any_held(), \ > ^ > include/linux/rculist.h:371:7: note: in expansion of macro '__list_check_rcu' > for (__list_check_rcu(dummy, ## cond, 0), \ > ^ > drivers/char/ipmi/ipmi_msghandler.c:1607:2: note: in expansion of macro 'list_for_each_entry_rcu' > list_for_each_entry_rcu(rcvr, &intf->cmd_rcvrs, link, > ^ > include/linux/rculist.h:53:25: warning: suggest parentheses around '&&' within '||' [-Wparentheses] > RCU_LOCKDEP_WARN(!cond && !rcu_read_lock_any_held(), \ > ^ > include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value' > (cond) ? \ > ^ > include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' > #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) > ^ > >> include/linux/rcupdate.h:263:3: note: in expansion of macro 'if' > if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \ > ^ > >> include/linux/rculist.h:53:2: note: in expansion of macro 'RCU_LOCKDEP_WARN' > RCU_LOCKDEP_WARN(!cond && !rcu_read_lock_any_held(), \ > ^ > include/linux/rculist.h:371:7: note: in expansion of macro '__list_check_rcu' > for (__list_check_rcu(dummy, ## cond, 0), \ > ^ > drivers/char/ipmi/ipmi_msghandler.c:1607:2: note: in expansion of macro 'list_for_each_entry_rcu' > list_for_each_entry_rcu(rcvr, &intf->cmd_rcvrs, link, > ^ > > vim +/if +263 include/linux/rcupdate.h > > 632ee200130899 Paul E. McKenney 2010-02-22 254 > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 255 /** > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 256 * RCU_LOCKDEP_WARN - emit lockdep splat if specified condition is met > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 257 * @c: condition to check > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 258 * @s: informative message > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 259 */ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 260 #define RCU_LOCKDEP_WARN(c, s) \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 261 do { \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 262 static bool __section(.data.unlikely) __warned; \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 @263 if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 264 __warned = true; \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 265 lockdep_rcu_suspicious(__FILE__, __LINE__, s); \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 266 } \ > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 267 } while (0) > f78f5b90c4ffa5 Paul E. McKenney 2015-06-18 268 > > :::::: The code at line 263 was first introduced by commit > :::::: f78f5b90c4ffa559e400c3919a02236101f29f3f rcu: Rename rcu_lockdep_assert() to RCU_LOCKDEP_WARN() > > :::::: TO: Paul E. McKenney > :::::: CC: Paul E. McKenney > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees