From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27317C3F68F for ; Wed, 29 Jan 2020 17:00:24 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF32520732 for ; Wed, 29 Jan 2020 17:00:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HP+tU1Iy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF32520732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id CF9A32156F; Wed, 29 Jan 2020 17:00:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fWbk+FCbeWbS; Wed, 29 Jan 2020 17:00:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 79B3D21FAD; Wed, 29 Jan 2020 17:00:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6995CC0178; Wed, 29 Jan 2020 17:00:22 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2BDC3C0171 for ; Wed, 29 Jan 2020 17:00:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 19D402155E for ; Wed, 29 Jan 2020 17:00:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5snbCIkyaycZ for ; Wed, 29 Jan 2020 17:00:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by silver.osuosl.org (Postfix) with ESMTPS id 39D4521FF6 for ; Wed, 29 Jan 2020 17:00:15 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id k29so6199557pfp.13 for ; Wed, 29 Jan 2020 09:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=E1l6gHXvQ49XV0SVd1Lq576TcvFQ2pyxU0yLbNr7bQg=; b=HP+tU1IyiUVjnOJ7B79aKEO6ztkpxtzfvK5qMtNtjG1+yKXi3m88SECzlPwDDdiZEE diBgW227eiuJXnTCfp532XhTfwdmuTnlH81TFodIjdtzqmoM5h6KN3rnNY/GZRpViH7n CDUeGFTj08OTdTztWiRlHY5dX6Ti77cbR+T90C/RQfl3qgamINwICZziEPEUx8mIKVrx aSbLwmTP42e92L2mSkIAVLON7HJWJ/+hO3AMajFoCevXucIok4K638731DR7+eu4K6bn slIj+ZmfbdQ7tkzGkCnqvfVK7D651qVD5nwgnYn6iL986sdSZhHzEAIm2UXwmVFHCruv oOKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=E1l6gHXvQ49XV0SVd1Lq576TcvFQ2pyxU0yLbNr7bQg=; b=ObiCOYUpif8ZWRof3g+mEUbYRKb9qbXKSWFHZUvHgs5sd9EbeoOMDI1/sxwmfjnani laMkEwNf7i+hZb8wXY05Qvo8gGzBG37Se0tkHWjIEMr2VhoxSnATKQFy1ktcb1s/iDMw 4RLoWsxjVH8bRBwm6fClCbRMvXMStclxxaqk5QCePVNLvQTbyZumLVfgWU+nR74Vu+fq s303Kz77Qk6u063gvYsRQK+BfXc9p2fn23bbRDinZdGHaFPI+k27vDswChc6B3KAb+Z6 SkL6cNLGaHaVhC28n5kATKyelETASSpfuWiYxChFQL3nfzu1RFBDYxMYldGohP9+l7ZW hk+Q== X-Gm-Message-State: APjAAAXTMTt0FLgTlzLTcuAx1XCtrB09W2u+/XZ4dEPX5JN0A4g5gs+H MRoI6a+X4sE1MP8ps0htv2ufhH59YKg= X-Google-Smtp-Source: APXvYqyThZCHWdE0CW86oGgw+CrujFSrifKNQZdrUJVMNMmM1WKWgwv4YL2alEpTIW7CWy1KJT/HmQ== X-Received: by 2002:aa7:92c2:: with SMTP id k2mr487123pfa.93.1580317214793; Wed, 29 Jan 2020 09:00:14 -0800 (PST) Received: from localhost.localdomain ([2405:205:c92f:3ccd:49ce:a9e3:28b5:cf94]) by smtp.gmail.com with ESMTPSA id f8sm3223610pfn.2.2020.01.29.09.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 09:00:14 -0800 (PST) From: Pragat Pandya To: gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu Date: Wed, 29 Jan 2020 22:28:28 +0530 Message-Id: <20200129165832.10574-16-pragat.pandya@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200129165832.10574-1-pragat.pandya@gmail.com> References: <20200129165832.10574-1-pragat.pandya@gmail.com> Cc: devel@driverdev.osuosl.org, Pragat Pandya , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [Linux-kernel-mentees] [PATCH 15/19] staging: exfat: Rename variable 'Attr' to 'attr' X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Fix checkpatch warning: Avoid CamelCase. Change all occurrences of identifier "Attr" to "attr" Signed-off-by: Pragat Pandya --- drivers/staging/exfat/exfat.h | 2 +- drivers/staging/exfat/exfat_super.c | 24 ++++++++++++------------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h index 099730e5b9f1..f1fa4d19a2e2 100644 --- a/drivers/staging/exfat/exfat.h +++ b/drivers/staging/exfat/exfat.h @@ -275,7 +275,7 @@ struct dir_entry_t { /* used only for FAT12/16/32, not used for exFAT */ char short_name[DOS_NAME_LENGTH + 2]; - u32 Attr; + u32 attr; u64 Size; u32 NumSubdirs; struct date_time_t CreateTimestamp; diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index e155079722c8..73d116b8d769 100644 --- a/drivers/staging/exfat/exfat_super.c +++ b/drivers/staging/exfat/exfat_super.c @@ -1457,7 +1457,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info) if (is_dir) { if ((fid->dir.dir == p_fs->root_dir) && (fid->entry == -1)) { - info->Attr = ATTR_SUBDIR; + info->attr = ATTR_SUBDIR; memset((char *)&info->CreateTimestamp, 0, sizeof(struct date_time_t)); memset((char *)&info->ModifyTimestamp, 0, @@ -1502,7 +1502,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info) ep2 = ep + 1; /* set FILE_INFO structure using the acquired struct dentry_t */ - info->Attr = p_fs->fs_func->get_entry_attr(ep); + info->attr = p_fs->fs_func->get_entry_attr(ep); p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE); info->CreateTimestamp.year = tm.year; @@ -1602,7 +1602,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info) } ep2 = ep + 1; - p_fs->fs_func->set_entry_attr(ep, info->Attr); + p_fs->fs_func->set_entry_attr(ep, info->attr); /* set FILE_INFO structure using the acquired struct dentry_t */ tm.sec = info->CreateTimestamp.second; @@ -1922,7 +1922,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry) continue; exfat_buf_lock(sb, sector); - dir_entry->Attr = fs_func->get_entry_attr(ep); + dir_entry->attr = fs_func->get_entry_attr(ep); fs_func->get_entry_time(ep, &tm, TM_CREATE); dir_entry->CreateTimestamp.year = tm.year; @@ -2150,7 +2150,7 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx) } if (!dir_emit(ctx, de.name, strlen(de.name), inum, - (de.Attr & ATTR_SUBDIR) ? DT_DIR : DT_REG)) + (de.attr & ATTR_SUBDIR) ? DT_DIR : DT_REG)) goto out; ctx->pos = cpos; @@ -3159,25 +3159,25 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid) INC_IVERSION(inode); inode->i_generation = prandom_u32(); - if (info.Attr & ATTR_SUBDIR) { /* directory */ + if (info.attr & ATTR_SUBDIR) { /* directory */ inode->i_generation &= ~1; - inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777); + inode->i_mode = exfat_make_mode(sbi, info.attr, 0777); inode->i_op = &exfat_dir_inode_operations; inode->i_fop = &exfat_dir_operations; i_size_write(inode, info.Size); EXFAT_I(inode)->mmu_private = i_size_read(inode); set_nlink(inode, info.NumSubdirs); - } else if (info.Attr & ATTR_SYMLINK) { /* symbolic link */ + } else if (info.attr & ATTR_SYMLINK) { /* symbolic link */ inode->i_generation |= 1; - inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777); + inode->i_mode = exfat_make_mode(sbi, info.attr, 0777); inode->i_op = &exfat_symlink_inode_operations; i_size_write(inode, info.Size); EXFAT_I(inode)->mmu_private = i_size_read(inode); } else { /* regular file */ inode->i_generation |= 1; - inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777); + inode->i_mode = exfat_make_mode(sbi, info.attr, 0777); inode->i_op = &exfat_file_inode_operations; inode->i_fop = &exfat_file_operations; inode->i_mapping->a_ops = &exfat_aops; @@ -3186,7 +3186,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid) i_size_write(inode, info.Size); EXFAT_I(inode)->mmu_private = i_size_read(inode); } - exfat_save_attr(inode, info.Attr); + exfat_save_attr(inode, info.attr); inode->i_blocks = ((i_size_read(inode) + (p_fs->cluster_size - 1)) & ~((loff_t)p_fs->cluster_size - 1)) >> 9; @@ -3259,7 +3259,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc) if (inode->i_ino == EXFAT_ROOT_INO) return 0; - info.Attr = exfat_make_attr(inode); + info.attr = exfat_make_attr(inode); info.Size = i_size_read(inode); exfat_time_unix2fat(&inode->i_mtime, &info.ModifyTimestamp); -- 2.17.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees