From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CD5CA90AF for ; Wed, 13 May 2020 11:54:52 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CCA8206CC for ; Wed, 13 May 2020 11:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="LqN/gv1i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CCA8206CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EA8E788600; Wed, 13 May 2020 11:54:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2b0QVjMCfAtV; Wed, 13 May 2020 11:54:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 14D6B8817F; Wed, 13 May 2020 11:54:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0AA23C0178; Wed, 13 May 2020 11:54:49 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2EC51C016F for ; Wed, 13 May 2020 11:54:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 192452153B for ; Wed, 13 May 2020 11:54:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KYFb-sCovWiC for ; Wed, 13 May 2020 11:54:46 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from ozlabs.org (ozlabs.org [203.11.71.1]) by silver.osuosl.org (Postfix) with ESMTPS id C2DBB2042B for ; Wed, 13 May 2020 11:54:45 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49MY4f6q8Lz9sRK; Wed, 13 May 2020 21:54:42 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1589370883; bh=3T+lgSc67nG88CAar7Vf0TDXY5ZfpVC7nYvqytN5sYA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LqN/gv1iTibO8JXPWWbV654vC1YJxhEggzfdp2qCrZDNYOAJtzYt7KNVpoF2kfkQk R+US6MXwoHV3rGvLzFEWu32dX7LulBk4Pom52Z3zB08weVDLQFSFVIyXgOIGyzgfp8 wQv5o0joI2vSF3Pu4MjOoRBsvDXe8Ty6eXd2hgfAIrDZNN5ut1fnK+oz6Q42TlOGdR trwrkaqHVXtfQxDkP0610r5+WUmUQiCrETUtpTygZKm5bRGAcvCjpBZvZl+CNES3US D3QaxWNUyznpKkowMqAQIK1xGddb2aGSObbGAHeTsbibwPSkk7u9aXlaf6DKOW+od+ HX+tZgm5g2Hew== Date: Wed, 13 May 2020 21:54:41 +1000 From: Stephen Rothwell To: Madhuparna Bhowmik Message-ID: <20200513215441.22653800@canb.auug.org.au> In-Reply-To: <20200512051705.GB9585@madhuparna-HP-Notebook> References: <20200509072243.3141-1-frextrite@gmail.com> <20200509072243.3141-2-frextrite@gmail.com> <20200509141938.028fa959@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200512051705.GB9585@madhuparna-HP-Notebook> MIME-Version: 1.0 Cc: "Paul E . McKenney" , Hideaki YOSHIFUJI , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Kuznetsov , Joel Fernandes , kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, "David S . Miller" Subject: Re: [Linux-kernel-mentees] [PATCH net 2/2 RESEND] ipmr: Add lockdep expression to ipmr_for_each_table macro X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2251546260918386442==" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" --===============2251546260918386442== Content-Type: multipart/signed; boundary="Sig_/G21wR.Rlh9nJMI_uLF+zR.9"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/G21wR.Rlh9nJMI_uLF+zR.9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Tue, 12 May 2020 10:47:05 +0530 Madhuparna Bhowmik wrote: > >=20 > > I think what is happening is this: > >=20 > > ipmr_net_init() -> ipmr_rules_init() -> ipmr_new_table() > >=20 > > ipmr_new_table() returns an existing table if there is one, but > > obviously none can exist at init. So a better fix would be: > >=20 > > #define ipmr_for_each_table(mrt, net) \ > > list_for_each_entry_rcu(mrt, &net->ipv4.mr_tables, list, \ > > lockdep_rtnl_is_held() || \ > > list_empty(&net->ipv4.mr_tables)) > > =20 > (adding Stephen) I have changed the patch in my fixes tree to this. --=20 Cheers, Stephen Rothwell --Sig_/G21wR.Rlh9nJMI_uLF+zR.9 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl674AIACgkQAVBC80lX 0GwJeQf/WMFPCJ/Bcct2RJ78Xar0HrrX2pKIBOUdfYIYHWltb4+jgrHS4s9JUDAr qwpk4IVWSTS/mCCdW3A+GU7wXNfCW5hJtMVprpwJpulGvsTWeHHSFePPESje0uvS OQn8YwYk5a5Qxm6xPgbcmJqLW3b3ud4O+rA4t6EegtDIDMeaI5TUg6xJFpfl42KD AD3w6ukWA0O5iQulxiqTBOTXBCR1QN4plkafmfgYXXaUQfWLMGmLHJRs6OU/f4uJ QTtQlUiNa4yiiyYw6CfDsG5xs7NFjhOKmPydw8LdpzB8WYVBQGTp2kK/1emWUv1f gwDrocR3dPMr8mGcsTF3GdoRFCtc/w== =QuXY -----END PGP SIGNATURE----- --Sig_/G21wR.Rlh9nJMI_uLF+zR.9-- --===============2251546260918386442== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees --===============2251546260918386442==--