From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53EB5C433DF for ; Mon, 20 Jul 2020 21:56:50 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06A70208E4 for ; Mon, 20 Jul 2020 21:56:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06A70208E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=libc.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C118586B48; Mon, 20 Jul 2020 21:56:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q9cV-LTzQ83x; Mon, 20 Jul 2020 21:56:49 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 3275F86B11; Mon, 20 Jul 2020 21:56:49 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0A4D2C089F; Mon, 20 Jul 2020 21:56:49 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B0412C016F for ; Mon, 20 Jul 2020 21:56:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id A81D886B48 for ; Mon, 20 Jul 2020 21:56:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JdRa0Kn1fuDi for ; Mon, 20 Jul 2020 21:56:46 +0000 (UTC) X-Greylist: delayed 00:15:06 by SQLgrey-1.7.6 Received: from brightrain.aerifal.cx (brightrain.aerifal.cx [216.12.86.13]) by whitealder.osuosl.org (Postfix) with ESMTPS id A0EE386B11 for ; Mon, 20 Jul 2020 21:56:45 +0000 (UTC) Date: Mon, 20 Jul 2020 17:41:28 -0400 From: Rich Felker To: "Saheed O. Bolarinwa" Message-ID: <20200720214128.GN14669@brightrain.aerifal.cx> References: <20200713122247.10985-1-refactormyself@gmail.com> <20200713122247.10985-25-refactormyself@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200713122247.10985-25-refactormyself@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Yoshinori Sato , linux-sh@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, helgaas@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [RFC PATCH 24/35] sh: Change PCIBIOS_SUCCESSFUL to 0 X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Jul 13, 2020 at 02:22:36PM +0200, Saheed O. Bolarinwa wrote: > In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept. > Their scope should be limited within arch/x86. > > Change all PCIBIOS_SUCCESSFUL to 0 > > Signed-off-by: "Saheed O. Bolarinwa" > --- > arch/sh/drivers/pci/common.c | 2 +- > arch/sh/drivers/pci/ops-dreamcast.c | 4 ++-- > arch/sh/drivers/pci/ops-sh4.c | 4 ++-- > arch/sh/drivers/pci/ops-sh7786.c | 8 ++++---- > arch/sh/drivers/pci/pci.c | 2 +- > 5 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/arch/sh/drivers/pci/common.c b/arch/sh/drivers/pci/common.c > index fe163ecd0719..ee27cdfd3e68 100644 > --- a/arch/sh/drivers/pci/common.c > +++ b/arch/sh/drivers/pci/common.c > @@ -61,7 +61,7 @@ int __init pci_is_66mhz_capable(struct pci_channel *hose, > continue; > if (early_read_config_word(hose, top_bus, current_bus, > pci_devfn, PCI_VENDOR_ID, &vid) != > - PCIBIOS_SUCCESSFUL) > + 0) > continue; > if (vid == 0xffff) > continue; > diff --git a/arch/sh/drivers/pci/ops-dreamcast.c b/arch/sh/drivers/pci/ops-dreamcast.c > index 517a8a9702f6..431cd006951f 100644 > --- a/arch/sh/drivers/pci/ops-dreamcast.c > +++ b/arch/sh/drivers/pci/ops-dreamcast.c > @@ -56,7 +56,7 @@ static int gapspci_read(struct pci_bus *bus, unsigned int devfn, int where, int > case 4: *val = inl(GAPSPCI_BBA_CONFIG+where); break; > } > > - return PCIBIOS_SUCCESSFUL; > + return 0; > } > > static int gapspci_write(struct pci_bus *bus, unsigned int devfn, int where, int size, u32 val) > @@ -70,7 +70,7 @@ static int gapspci_write(struct pci_bus *bus, unsigned int devfn, int where, int > case 4: outl((u32)val, GAPSPCI_BBA_CONFIG+where); break; > } > > - return PCIBIOS_SUCCESSFUL; > + return 0; > } > > struct pci_ops gapspci_pci_ops = { > diff --git a/arch/sh/drivers/pci/ops-sh4.c b/arch/sh/drivers/pci/ops-sh4.c > index a205be3bfc4a..4d757e5f38c6 100644 > --- a/arch/sh/drivers/pci/ops-sh4.c > +++ b/arch/sh/drivers/pci/ops-sh4.c > @@ -49,7 +49,7 @@ static int sh4_pci_read(struct pci_bus *bus, unsigned int devfn, > return PCIBIOS_FUNC_NOT_SUPPORTED; > } > > - return PCIBIOS_SUCCESSFUL; > + return 0; > } > > /* > @@ -90,7 +90,7 @@ static int sh4_pci_write(struct pci_bus *bus, unsigned int devfn, > > pci_write_reg(chan, data, SH4_PCIPDR); > > - return PCIBIOS_SUCCESSFUL; > + return 0; > } > > struct pci_ops sh4_pci_ops = { > diff --git a/arch/sh/drivers/pci/ops-sh7786.c b/arch/sh/drivers/pci/ops-sh7786.c > index a10f9f4ebd7f..7c329e467360 100644 > --- a/arch/sh/drivers/pci/ops-sh7786.c > +++ b/arch/sh/drivers/pci/ops-sh7786.c > @@ -52,7 +52,7 @@ static int sh7786_pcie_config_access(unsigned char access_type, > else > pci_write_reg(chan, *data, PCI_REG(reg)); > > - return PCIBIOS_SUCCESSFUL; > + return 0; > } else if (dev > 1) > return PCIBIOS_DEVICE_NOT_FOUND; > } > @@ -83,7 +83,7 @@ static int sh7786_pcie_config_access(unsigned char access_type, > /* Disable the configuration access */ > pci_write_reg(chan, 0, SH4A_PCIEPCTLR); > > - return PCIBIOS_SUCCESSFUL; > + return 0; > } > > static int sh7786_pcie_read(struct pci_bus *bus, unsigned int devfn, > @@ -101,7 +101,7 @@ static int sh7786_pcie_read(struct pci_bus *bus, unsigned int devfn, > raw_spin_lock_irqsave(&pci_config_lock, flags); > ret = sh7786_pcie_config_access(PCI_ACCESS_READ, bus, > devfn, where, &data); > - if (ret != PCIBIOS_SUCCESSFUL) { > + if (ret != 0) { > *val = 0xffffffff; > goto out; > } > @@ -137,7 +137,7 @@ static int sh7786_pcie_write(struct pci_bus *bus, unsigned int devfn, > raw_spin_lock_irqsave(&pci_config_lock, flags); > ret = sh7786_pcie_config_access(PCI_ACCESS_READ, bus, > devfn, where, &data); > - if (ret != PCIBIOS_SUCCESSFUL) > + if (ret != 0) > goto out; > > dev_dbg(&bus->dev, "pcie-config-write: bus=%3d devfn=0x%04x " > diff --git a/arch/sh/drivers/pci/pci.c b/arch/sh/drivers/pci/pci.c > index c7784e156964..77130f035fdd 100644 > --- a/arch/sh/drivers/pci/pci.c > +++ b/arch/sh/drivers/pci/pci.c > @@ -204,7 +204,7 @@ pcibios_bus_report_status_early(struct pci_channel *hose, > continue; > ret = early_read_config_word(hose, top_bus, current_bus, > pci_devfn, PCI_STATUS, &status); > - if (ret != PCIBIOS_SUCCESSFUL) > + if (ret != 0) > continue; > if (status == 0xffff) > continue; > -- > 2.18.2 Acked-by: Rich Felker (for both this and the following one in the series) _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees