From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D02C433E5 for ; Mon, 27 Jul 2020 13:09:40 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01D1A206D8 for ; Mon, 27 Jul 2020 13:09:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MIlJM9Xz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01D1A206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id DD46020481; Mon, 27 Jul 2020 13:09:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aULU5S2mJL1z; Mon, 27 Jul 2020 13:09:38 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 414E6203F4; Mon, 27 Jul 2020 13:09:38 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 27A74C004F; Mon, 27 Jul 2020 13:09:38 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 496BAC004D for ; Mon, 27 Jul 2020 13:09:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 2DF1E203F4 for ; Mon, 27 Jul 2020 13:09:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zH+MsvAVZ9Sq for ; Mon, 27 Jul 2020 13:09:35 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by silver.osuosl.org (Postfix) with ESMTPS id 155FC203B5 for ; Mon, 27 Jul 2020 13:09:35 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id l2so2706329pff.0 for ; Mon, 27 Jul 2020 06:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=V2H1tlMLXxYxucqE7fzBGTDFcMq1gtGJ4rquGrh2ZhI=; b=MIlJM9Xzo58AFvW6Fy6A5plY/aankHz0/bF/5QpI8pCOSRwmmQKZQgxfbewFXSFRqq auBb7mhhQlZ6SBlipvkDLaKNatoNYi+OTmFFv9YmJhx6iUvtJ4Qn/XTafA9G3Q+cNVZm 4pal2Pq4R9UPMuXTZT6yQuuRw8TB9VCAsuExrFjE/wa3sCCEljimv6dXXE1vkwwvoVrr nEY9rFTTZjQZqXAYSxxioJGLu/42ONwmbgUqAAi2pujPg8HIv9Br8V3AHMEE5eZjeSkm HK6v7wGsRcT0pi5nrfdHcHOX24htw+bi3aGtXFG2jcESmlrz3qWpqR+RviABgdKwns7W alHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=V2H1tlMLXxYxucqE7fzBGTDFcMq1gtGJ4rquGrh2ZhI=; b=sNCKE1CNt1syBO9n+y2mzxLrUFCjfJyV4kPxAFQaRTDsZ1Gz9RDtbLPGBe00K0CxRO tDYnSFjmXgcKErFqigU5nFoCQwIF9MTz9xHhEIy0F4I/HkqKhGk/nehR3iAEWVTet+qP ndbvLdEwhCsGPae27rsUGxiC5u7+YXFv4omEjt4Q8a08EkpLnclMcV1ndVW3rRLzBLDh cy5B5O4rP+O7V4wjBVADRoKo7qu0kSHB2XUYgWs0MLZ+phLbQbJFhb/XTXrcJ71hqdzm CMMtckkA2uej3/NOzzJDenewUK5TlrZ6cWK4knOepvp6/jRy2dmrFmpQA9kRhgqG+kQH 8t0w== X-Gm-Message-State: AOAM5307wCpiDi/YQtey4PGIrci17rS3MvvNTiLBJRB7/dkTtatJUlLa y6fn2ZnN8FM10uuwlri4liU= X-Google-Smtp-Source: ABdhPJzmW4MB+8kyEVPNT2dKVYcXMow76EuwUPI+GPmwmKEC003b4GlrTMTumZ3rTmpPvjb2voj96Q== X-Received: by 2002:a63:7b15:: with SMTP id w21mr20524655pgc.386.1595855374446; Mon, 27 Jul 2020 06:09:34 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id 186sm14925807pfe.1.2020.07.27.06.09.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 06:09:33 -0700 (PDT) Date: Mon, 27 Jul 2020 18:38:09 +0530 From: Vaibhav Gupta To: Andy Shevchenko Message-ID: <20200727130809.GA82098@gmail.com> References: <20200720113740.353479-1-vaibhavgupta40@gmail.com> <20200727085621.GL12965@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: dmaengine , Linux Kernel Mailing List , Vinod Koul , Bjorn Helgaas , Bjorn Helgaas , Dan Williams , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH v1] dmaengine: pch_dma: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Mon, Jul 27, 2020 at 02:19:14PM +0300, Andy Shevchenko wrote: > On Mon, Jul 27, 2020 at 1:16 PM Vinod Koul wrote: > > On 20-07-20, 17:07, Vaibhav Gupta wrote: > > > Drivers using legacy PM have to manage PCI states and device's PM states > > > themselves. They also need to take care of configuration registers. > > > > > > With improved and powerful support of generic PM, PCI Core takes care of > > > above mentioned, device-independent, jobs. > > > > > > This driver makes use of PCI helper functions like > > > pci_save/restore_state(), pci_enable/disable_device(), > > > and pci_set_power_state() to do required operations. In generic mode, they > > > are no longer needed. > > > > > > Change function parameter in both .suspend() and .resume() to > > > "struct device*" type. Use dev_get_drvdata() to get drv data. > > > > You are doing too many things in One patch. Do consider splitting them > > up to a change per patch. for example using __maybe could be one patch, > > removing code is suspend-resume callbacks would be other one. > > Vinod, while I completely agree with you in general, in this case it > would make more unnecessary churn and will be rather unhelpful in all > ways: for the contributor to do this work, for the reader to collect > all the pieces. It also will be a bisectability issue, because the > #ifdeffery replacement (IIRC you need to move from CONFIG_PM to > CONFIG_PM_SLEEP). I really don't see any advantages of the splitting > here. > > > > Compile-tested only. > > > > I would like to see some testing before we merge this > > I have hardware to test (Intel Minnowboard v1) but have no time. And > taking into account that I did similar changes for many other drivers, > I can give my > Reviewed-by: Andy Shevchenko > and take responsibility if somebody complains in the future (I don't > believe it will be one). > Thanks! :D > P.S. Another scenario if Vaibhav can find that board (there were > dozens of thousands at least produced and floating on the second hand > market) and test himself. It may be good since he touches the full lot > of PCH (EGT20) drivers. > I cannot promise, but surely will try to get my hands on it :) Thanks Vaibhav Gupta > > > Signed-off-by: Vaibhav Gupta > > > --- > > > drivers/dma/pch_dma.c | 35 +++++++++-------------------------- > > > 1 file changed, 9 insertions(+), 26 deletions(-) > > > > > > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c > > > index a3b0b4c56a19..e93005837e3f 100644 > > > --- a/drivers/dma/pch_dma.c > > > +++ b/drivers/dma/pch_dma.c > > > @@ -735,8 +735,7 @@ static irqreturn_t pd_irq(int irq, void *devid) > > > return ret0 | ret2; > > > } > > > > > > -#ifdef CONFIG_PM > > > -static void pch_dma_save_regs(struct pch_dma *pd) > > > +static void __maybe_unused pch_dma_save_regs(struct pch_dma *pd) > > > { > > > struct pch_dma_chan *pd_chan; > > > struct dma_chan *chan, *_c; > > > @@ -759,7 +758,7 @@ static void pch_dma_save_regs(struct pch_dma *pd) > > > } > > > } > > > > > > -static void pch_dma_restore_regs(struct pch_dma *pd) > > > +static void __maybe_unused pch_dma_restore_regs(struct pch_dma *pd) > > > { > > > struct pch_dma_chan *pd_chan; > > > struct dma_chan *chan, *_c; > > > @@ -782,40 +781,25 @@ static void pch_dma_restore_regs(struct pch_dma *pd) > > > } > > > } > > > > > > -static int pch_dma_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused pch_dma_suspend(struct device *dev) > > > { > > > - struct pch_dma *pd = pci_get_drvdata(pdev); > > > + struct pch_dma *pd = dev_get_drvdata(dev); > > > > > > if (pd) > > > pch_dma_save_regs(pd); > > > > > > - pci_save_state(pdev); > > > - pci_disable_device(pdev); > > > - pci_set_power_state(pdev, pci_choose_state(pdev, state)); > > > - > > > return 0; > > > } > > > > > > -static int pch_dma_resume(struct pci_dev *pdev) > > > +static int __maybe_unused pch_dma_resume(struct device *dev) > > > { > > > - struct pch_dma *pd = pci_get_drvdata(pdev); > > > - int err; > > > - > > > - pci_set_power_state(pdev, PCI_D0); > > > - pci_restore_state(pdev); > > > - > > > - err = pci_enable_device(pdev); > > > - if (err) { > > > - dev_dbg(&pdev->dev, "failed to enable device\n"); > > > - return err; > > > - } > > > + struct pch_dma *pd = dev_get_drvdata(dev); > > > > > > if (pd) > > > pch_dma_restore_regs(pd); > > > > > > return 0; > > > } > > > -#endif > > > > > > static int pch_dma_probe(struct pci_dev *pdev, > > > const struct pci_device_id *id) > > > @@ -993,15 +977,14 @@ static const struct pci_device_id pch_dma_id_table[] = { > > > { 0, }, > > > }; > > > > > > +static SIMPLE_DEV_PM_OPS(pch_dma_pm_ops, pch_dma_suspend, pch_dma_resume); > > > + > > > static struct pci_driver pch_dma_driver = { > > > .name = DRV_NAME, > > > .id_table = pch_dma_id_table, > > > .probe = pch_dma_probe, > > > .remove = pch_dma_remove, > > > -#ifdef CONFIG_PM > > > - .suspend = pch_dma_suspend, > > > - .resume = pch_dma_resume, > > > -#endif > > > + .driver.pm = &pch_dma_pm_ops, > > > }; > > > > > > module_pci_driver(pch_dma_driver); > > > -- > > > 2.27.0 > > > > -- > > ~Vinod > > > > -- > With Best Regards, > Andy Shevchenko _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees