From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8E6C433E0 for ; Thu, 6 Aug 2020 11:03:04 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D785B2250E for ; Thu, 6 Aug 2020 11:03:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gLHgg2FD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D785B2250E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 6756022843; Thu, 6 Aug 2020 07:24:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U5pSkefpj-Gz; Thu, 6 Aug 2020 07:24:42 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 9E2892152E; Thu, 6 Aug 2020 07:24:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 78F39C0050; Thu, 6 Aug 2020 07:24:42 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1F870C004C for ; Thu, 6 Aug 2020 07:24:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 0857386CC9 for ; Thu, 6 Aug 2020 07:24:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jBEahmP4MLQa for ; Thu, 6 Aug 2020 07:24:40 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 047A686C76 for ; Thu, 6 Aug 2020 07:24:40 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id s26so24434277pfm.4 for ; Thu, 06 Aug 2020 00:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XxdgRFlQigk4lLEnKCMOhpL5rmLS0bgdeVzH2zzhbYk=; b=gLHgg2FDEjjPLyXBuhI/MzcN+g8tUjZ6ANigM+BEjYlSOioVM7Q9mJoOou77/wLgP8 q3C36bh00vAMR7Mp/11TiYzH7VLQ2jMkFJtu6v2kMh+VLDOSgOEtGHAMW/s9lQ81uO+T L2DaDX7s1IYVTYdWEySZujl4UvhM8Wedfmaa5CJGbWShekQ8rroNHX8kwQmWWtf024vt KquJx56ldPRmTa2VbMawPrCO/bME6t0aq3G/aJwcphoKKU3tugxrpsYV9oP5m5ltuACw nzrPTPcOm3YiygFmsRLUSOiudU9l5EpOuVHAcpHhmr9RANsg9iUqu9pckY1beFS+dIiy 3b9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XxdgRFlQigk4lLEnKCMOhpL5rmLS0bgdeVzH2zzhbYk=; b=e1g/IEftnMyZsUNcK1WYJn4/v1p3dElW9tMev/RVe+vJ8gobMwh8ve/hiD/3IuBV9z EILU2PnMq7JBB1gzW5bg04bScpGrHCYu8jDETh05AxoxKlsGYAGELURB0pBWA8K0WLgQ X+epwPNyPA/4cmPmY8L2JtWhawpH3o0HPn9BpN0WGJdDdGQIfnb68lZaiSoC9Z1vfx8w sD+c1V85Qx0edyScMMbE6B3B6E/Wjbq56dCH7eLVJOSowSIIZEkRaGhQoiEEYTkRKRII l7Syo/neb5zTKUzTcPdQHngxGtvi734QE9lVVI+x/9ziEzJOM6CSLNTkt+P1tlfnJzFg ydwA== X-Gm-Message-State: AOAM531QAexw7qFsWdyGVInIBev83oK+QjPpJMd35TnYghH3mdmyT3O1 Di928++9IWD9qERH3SmD1OE= X-Google-Smtp-Source: ABdhPJy5IRLInbKEewuJcoFWlYSZ7y95C3u9BHwPJBs5gSkClT1546uXOobVCr9Tbi0huxbgv3FyPg== X-Received: by 2002:a62:d084:: with SMTP id p126mr5801419pfg.287.1596698679368; Thu, 06 Aug 2020 00:24:39 -0700 (PDT) Received: from varodek.iballbatonwifi.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id t28sm5665205pgn.81.2020.08.06.00.24.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 00:24:38 -0700 (PDT) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Benjamin Herrenschmidt , Bartlomiej Zolnierkiewicz , Thierry Reding , Thierry Reding Date: Thu, 6 Aug 2020 12:52:54 +0530 Message-Id: <20200806072256.585705-1-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Cc: linux-fbdev@vger.kernel.org, Vaibhav Gupta , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: [Linux-kernel-mentees] [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups. X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Linux Kernel Mentee: Remove Legacy Power Management. The original goal of the patch series is to upgrade the power management framework of radeonfb fbdev driver. This has been done by upgrading .suspend() and .resume() callbacks. The upgrade makes sure that the involvement of PCI Core does not change the order of operations executed in a driver. Thus, does not change its behavior. During this process, it was found that "#if defined(CONFIG_PM)" at line 1434 is redundant. This was introduced in the commit 42ddb453a0cd ("radeon: Conditionally compile PM code"). ------------ Before 42ddb453a0cd: $ git show 65122f7e80b5:drivers/video/aty/radeon_pm.c | grep -n "#ifdef\|#if\|#else\|#endif\|#elif\|#ifndef" Based on output in terminal: 547:#ifdef CONFIG_PM |-- 959:#ifdef CONFIG_PPC_PMAC |-- 972:#endif |-- 1291:#ifdef CONFIG_PPC_OF |-- 1301:#endif /* CONFIG_PPC_OF */ |-- 1943:#ifdef CONFIG_PPC_OF |-- 2206:#if 0 /* Not ready yet */ |-- 2508:#endif /* 0 */ |-- 2510:#endif /* CONFIG_PPC_OF */ |-- 2648:#ifdef CONFIG_PPC_PMAC |-- 2654:#endif /* CONFIG_PPC_PMAC */ |-- 2768:#ifdef CONFIG_PPC_PMAC |-- 2774:#endif /* CONFIG_PPC_PMAC */ |-- 2791:#ifdef CONFIG_PPC_OF__disabled |-- 2801:#endif /* CONFIG_PPC_OF */ 2803:#endif /* CONFIG_PM */ ------------ After 42ddb453a0cd: $ git show 42ddb453a0cd:drivers/video/aty/radeon_pm.c | grep -n "#ifdef\|#if\|#else\|#endif\|#elif\|#ifndef" Based on output in terminal: 547:#ifdef CONFIG_PM |-- 959:#ifdef CONFIG_PPC_PMAC |-- 972:#endif |-- 1291:#ifdef CONFIG_PPC_OF |-- 1301:#endif /* CONFIG_PPC_OF */ |-- 1430:#if defined(CONFIG_PM) |-- 1431:#if defined(CONFIG_X86) || defined(CONFIG_PPC_PMAC) |-- 1944:#endif |-- 1946:#ifdef CONFIG_PPC_OF |-- 1947:#ifdef CONFIG_PPC_PMAC |-- 2208:#endif |-- 2209:#endif |-- 2211:#if 0 /* Not ready yet */ |-- 2513:#endif /* 0 */ |-- 2515:#endif /* CONFIG_PPC_OF */ |-- 2653:#ifdef CONFIG_PPC_PMAC |-- 2659:#endif /* CONFIG_PPC_PMAC */ |-- 2773:#ifdef CONFIG_PPC_PMAC |-- 2779:#endif /* CONFIG_PPC_PMAC */ |-- 2796:#ifdef CONFIG_PPC_OF__disabled |-- 2806:#endif /* CONFIG_PPC_OF */ 2808:#endif /* CONFIG_PM */ ------------ This also affected the CONFIG_PPC_OF container (line 1943 at commit 65122f7e80b5) The patch-series fixes it along with PM upgrade. All patches are compile-tested only. Test tools: - Compiler: gcc (GCC) 10.1.0 - allmodconfig build: make -j$(nproc) W=1 all Vaibhav Gupta (2): video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container fbdev: radeonfb:use generic power management drivers/video/fbdev/aty/radeon_base.c | 10 ++++--- drivers/video/fbdev/aty/radeon_pm.c | 38 ++++++++++++++++++++------- drivers/video/fbdev/aty/radeonfb.h | 3 +-- 3 files changed, 35 insertions(+), 16 deletions(-) -- 2.27.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees