From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4E8C433E1 for ; Mon, 17 Aug 2020 08:12:26 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2079207FB for ; Mon, 17 Aug 2020 08:12:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JKjiPQoA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2079207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 44DAC877DC; Mon, 17 Aug 2020 08:12:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xrXew5JBugLM; Mon, 17 Aug 2020 08:12:24 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 2295187865; Mon, 17 Aug 2020 08:12:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 08839C07FF; Mon, 17 Aug 2020 08:12:16 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id AE848C0051 for ; Mon, 17 Aug 2020 08:12:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9CF3987AF3 for ; Mon, 17 Aug 2020 08:12:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y+Wrxtuo65m1 for ; Mon, 17 Aug 2020 08:12:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by hemlock.osuosl.org (Postfix) with ESMTPS id 0D1FE879DA for ; Mon, 17 Aug 2020 08:12:14 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id h12so7745009pgm.7 for ; Mon, 17 Aug 2020 01:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0Ghot5mUmzxhW3ypl42NBWLIYbTdm3HropjEkPH7sRo=; b=JKjiPQoA8xRWgSC4jFWJ/H+ejS9pqU3A5WcqYemhAfZhAWAJKDlAUHLesyWDdFj2GQ wBegAJ70p1u3qOmM3HV60revcvoeAIz57T5FpWzkNrUw0twmLYOtlGPGm1JqOife83zQ tTK5Yde7EA4tkpoXUIwJRSh4Cz3AtzIkZPucHyoAqkyTwdsqgtNAVKStIUFikLk1VPZU htsKXbMRjqDaqU45FNmA7XAeDCDuYonlPjAy5DHJSbMEw9KtYGUCAVtf3pq354B5ePt0 f46cK1FCrsV3NwCQwLVEtLteV2saRhOJYp2pvh8BaiQu+aQ5TqCBq9UxRlpIE5k98xzz ucsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0Ghot5mUmzxhW3ypl42NBWLIYbTdm3HropjEkPH7sRo=; b=R6VQAIjiIpi8A9pCRP4WuaIur/NxD9k0Iqx8z4Fk/rNLX4N4nAcKE0f9A10PxTJHdT PT+YwMEXMbr9pWghbktmEc5ye0WB2Gfobx/lwtlm2L8GJkjGP+ELJZ9ZAO3nJawFx3fy 9+1rF9ss4pUIS+aJ+h6ioOlAd4v/Ys/uvlNqOPOVsPHyHIr+7uiC+5Fop/C0tg7umquC 6/9ZId46pIMvBsfrUzKFYHE9dBQrdRyeVMxTfpMTsH9DRUrVV0eSgrXsCyykY8nuC7sh Ggwbn+dw+YM8S7e5yBE/RJ/Ie3cmUXMccD66IxWTBtQuEcnuxjPC4WuOoGeo289Tia9M 8fAA== X-Gm-Message-State: AOAM533tiER+tG+ys7tL/u6CjO0AaOeKQGpsB5CNnsl33cN/ATT2PMQ6 gt3a4JssH3UQwVIjHRWN9CU= X-Google-Smtp-Source: ABdhPJxtuLAvAlefhtLISvQFkrPKKRd160qLw2UoVo6UAkSiv8dcAKW3WNrZx1zMQPSgSgwD+ersPA== X-Received: by 2002:a62:6d03:: with SMTP id i3mr10618083pfc.6.1597651933513; Mon, 17 Aug 2020 01:12:13 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id u62sm18541511pfb.4.2020.08.17.01.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:12:13 -0700 (PDT) Date: Mon, 17 Aug 2020 13:40:32 +0530 From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Don Brace , "James E.J. Bottomley" , "Martin K. Petersen" Message-ID: <20200817081032.GH5869@gmail.com> References: <20200730070233.221488-1-vaibhavgupta40@gmail.com> <20200730110930.664486-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200730110930.664486-1-vaibhavgupta40@gmail.com> Cc: linux-kernel-mentees@lists.linuxfoundation.org, esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH v2] scsi: smartpqi: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, Jul 30, 2020 at 04:39:30PM +0530, Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a single > "struct dev_pm_ops" variable to take the unnecessary load from the driver. > This also avoids the need for the driver to directly call most of the PCI > helper functions and device power state control functions, as through > the generic framework PCI Core takes care of the necessary operations, > and drivers are required to do only device-specific jobs. > > Signed-off-by: Vaibhav Gupta > --- > drivers/scsi/smartpqi/smartpqi_init.c | 44 +++++++++++++++++++-------- > 1 file changed, 31 insertions(+), 13 deletions(-) > > diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c > index cd157f11eb22..7061bd26897a 100644 > --- a/drivers/scsi/smartpqi/smartpqi_init.c > +++ b/drivers/scsi/smartpqi/smartpqi_init.c > @@ -8059,11 +8059,11 @@ static void pqi_process_module_params(void) > pqi_process_lockup_action_param(); > } > > -static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t state) > +static int pqi_suspend_late(struct device *dev, pm_message_t state) > { > struct pqi_ctrl_info *ctrl_info; > > - ctrl_info = pci_get_drvdata(pci_dev); > + ctrl_info = dev_get_drvdata(dev); > > pqi_disable_events(ctrl_info); > pqi_cancel_update_time_worker(ctrl_info); > @@ -8081,20 +8081,33 @@ static __maybe_unused int pqi_suspend(struct pci_dev *pci_dev, pm_message_t stat > if (state.event == PM_EVENT_FREEZE) > return 0; > > - pci_save_state(pci_dev); > - pci_set_power_state(pci_dev, pci_choose_state(pci_dev, state)); > - > ctrl_info->controller_online = false; > ctrl_info->pqi_mode_enabled = false; > > return 0; > } > > -static __maybe_unused int pqi_resume(struct pci_dev *pci_dev) > +static __maybe_unused int pqi_suspend(struct device *dev) > +{ > + return pqi_suspend_late(dev, PMSG_SUSPEND); > +} > + > +static __maybe_unused int pqi_hibernate(struct device *dev) > +{ > + return pqi_suspend_late(dev, PMSG_HIBERNATE); > +} > + > +static __maybe_unused int pqi_freeze(struct device *dev) > +{ > + return pqi_suspend_late(dev, PMSG_FREEZE); > +} > + > +static __maybe_unused int pqi_resume(struct device *dev) > { > int rc; > struct pqi_ctrl_info *ctrl_info; > > + struct pci_dev *pci_dev = to_pci_dev(dev); > ctrl_info = pci_get_drvdata(pci_dev); > > if (pci_dev->current_state != PCI_D0) { > @@ -8115,9 +8128,6 @@ static __maybe_unused int pqi_resume(struct pci_dev *pci_dev) > return 0; > } > > - pci_set_power_state(pci_dev, PCI_D0); > - pci_restore_state(pci_dev); > - > return pqi_ctrl_init_resume(ctrl_info); > } > > @@ -8480,16 +8490,24 @@ static const struct pci_device_id pqi_pci_id_table[] = { > > MODULE_DEVICE_TABLE(pci, pqi_pci_id_table); > > +static const struct dev_pm_ops pqi_pm_ops = { > +#ifdef CONFIG_PM_SLEEP > + .suspend = pqi_suspend, > + .resume = pqi_resume, > + .freeze = pqi_freeze, > + .thaw = pqi_resume, > + .poweroff = pqi_hibernate, > + .restore = pqi_resume, > +#endif > +}; > + > static struct pci_driver pqi_pci_driver = { > .name = DRIVER_NAME_SHORT, > .id_table = pqi_pci_id_table, > .probe = pqi_pci_probe, > .remove = pqi_pci_remove, > .shutdown = pqi_shutdown, > -#if defined(CONFIG_PM) > - .suspend = pqi_suspend, > - .resume = pqi_resume, > -#endif > + .driver.pm = &pqi_pm_ops > }; > > static int __init pqi_init(void) > -- > 2.27.0 > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees