From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2700FC433DF for ; Thu, 20 Aug 2020 06:07:31 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D80D3207DE for ; Thu, 20 Aug 2020 06:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rtRjDmt5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D80D3207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9281D8671C; Thu, 20 Aug 2020 06:07:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1_pgINqij1G5; Thu, 20 Aug 2020 06:07:29 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 64BD2866AD; Thu, 20 Aug 2020 06:07:29 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5999FC088E; Thu, 20 Aug 2020 06:07:29 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id D1C44C07FF for ; Thu, 20 Aug 2020 06:07:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9E2082048D for ; Thu, 20 Aug 2020 06:07:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mcWAbYBR1Izd for ; Thu, 20 Aug 2020 06:07:27 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by silver.osuosl.org (Postfix) with ESMTPS id DD9632047B for ; Thu, 20 Aug 2020 06:07:26 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id j13so519943pjd.4 for ; Wed, 19 Aug 2020 23:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TEwV+gAKUnRj1mZL3fDfuQy8JyNw5xNO138gnCj19os=; b=rtRjDmt5UUfqpo78XbWEZ0IEW77Ap958XcFh9IZO8Hib9H8QEMwK7C51gmFTGrZfCM CZHHmTNMZGdFyOsts960HDKghxtIW9DtASK5kkSFqmo6fCQq/w9uqgthLq9JtGhJ5wYL /vOu79veUaG9At6gwBacYEywMAZFFN5FT4ssaCys8bp2kfpuOkJ8ulLy1HLY3ythM9Nq SKqAvKtK6TxUqGdXKHyCk5PSx/jPiby4IO8AQDusBcqJvdb61eeeBT5X4Ds/LXIWtFL7 LuvYF5/yGBnQtzSrJsD7k3FT2z7u0YPd8WxI5cpOpYmdcZEEt+MoquiOY/sCNvEi0Dyi 4vzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TEwV+gAKUnRj1mZL3fDfuQy8JyNw5xNO138gnCj19os=; b=kwZ29eS5VNIx79d1v4Z767cYttOrO0KTeSN+EobquABNt+n1EWYs1hKWmTt4igwlui T542ybAGG13KyyNhrrYeDGkzpO9BGwnHbfeoncxmUhoBBmtYF1bf/gF0qdYUYZjZYZji Z6nNOkl71x9grtz/p/wPehQAEUfkYQ9bmcZKibNvVuVsFyfptLaajmb5VtWUrn14qg83 TQVWzEtE6BykMfR+649n/j7l4XEbFF3BIuJltIPEIVwmCwFD7wve6flAWC9AIMDMMcn4 jgQxxxjh89TdOBiZWW3uhnsjFRdhRaFggqN862KoX+RHylzrnIAxKfzMdZYNnXZiZp1A qqKw== X-Gm-Message-State: AOAM531TC/6rsXhw8vSbyoYAKnGKT+8YS5UR/sX0fpOYIp2GP4Cp7G0q 7b9IaoYH9WCMnqSJGp52ICo= X-Google-Smtp-Source: ABdhPJysPg7llFDXEbdNkggy0Zx6PGaskljQ8fbdAgXP/6VPUKIjhm441S5NYlkXYmxsHbjfymoimw== X-Received: by 2002:a17:902:b589:: with SMTP id a9mr1395800pls.98.1597903646343; Wed, 19 Aug 2020 23:07:26 -0700 (PDT) Received: from localhost ([2001:e42:102:1532:160:16:113:140]) by smtp.gmail.com with ESMTPSA id g1sm1250773pfr.97.2020.08.19.23.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 23:07:25 -0700 (PDT) From: Coiby Xu X-Google-Original-From: Coiby Xu Date: Thu, 20 Aug 2020 14:07:13 +0800 To: syzbot Message-ID: <20200820060713.smilfw3otuunnepe@Rk> References: <000000000000c57f2d05ac4c5b8e@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <000000000000c57f2d05ac4c5b8e@google.com> Cc: johan.hedberg@gmail.com, rafael@kernel.org, marcel@holtmann.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, abhishekpandit@chromium.org, kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, davem@davemloft.net Subject: Re: [Linux-kernel-mentees] BUG: corrupted list in kobject_add_internal X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Fri, Aug 07, 2020 at 09:47:20AM -0700, syzbot wrote: >Hello, > >syzbot found the following issue on: > >HEAD commit: 5a30a789 Merge tag 'x86-urgent-2020-08-02' of git://git.ke.. >git tree: upstream >console output: https://syzkaller.appspot.com/x/log.txt?x=1660c858900000 >kernel config: https://syzkaller.appspot.com/x/.config?x=c0cfcf935bcc94d2 >dashboard link: https://syzkaller.appspot.com/bug?extid=dd768a260f7358adbaf9 >compiler: gcc (GCC) 10.1.0-syz 20200507 >syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14b73afc900000 >C reproducer: https://syzkaller.appspot.com/x/repro.c?x=124893a4900000 > >The issue was bisected to: > >commit 4f40afc6c76451daff7d0dcfc8a3d113ccf65bfc >Author: Abhishek Pandit-Subedi >Date: Wed Mar 11 15:54:01 2020 +0000 > > Bluetooth: Handle BR/EDR devices during suspend > >bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11cb1e0a900000 >final oops: https://syzkaller.appspot.com/x/report.txt?x=13cb1e0a900000 >console output: https://syzkaller.appspot.com/x/log.txt?x=15cb1e0a900000 > >IMPORTANT: if you fix the issue, please add the following tag to the commit: >Reported-by: syzbot+dd768a260f7358adbaf9@syzkaller.appspotmail.com >Fixes: 4f40afc6c764 ("Bluetooth: Handle BR/EDR devices during suspend") > >debugfs: Directory '200' with parent 'hci0' already present! >list_add double add: new=ffff88808e9b6418, prev=ffff88808e9b6418, next=ffff8880a973ef00. >------------[ cut here ]------------ >kernel BUG at lib/list_debug.c:29! >invalid opcode: 0000 [#1] PREEMPT SMP KASAN >CPU: 1 PID: 6882 Comm: kworker/u5:1 Not tainted 5.8.0-rc7-syzkaller #0 >Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >Workqueue: hci0 hci_rx_work >RIP: 0010:__list_add_valid.cold+0x26/0x3c lib/list_debug.c:29 >Code: 57 ff ff ff 4c 89 e1 48 c7 c7 20 92 93 88 e8 b1 f1 c1 fd 0f 0b 48 89 f2 4c 89 e1 48 89 ee 48 c7 c7 60 93 93 88 e8 9a f1 c1 fd <0f> 0b 48 89 f1 48 c7 c7 e0 92 93 88 4c 89 e6 e8 86 f1 c1 fd 0f 0b >RSP: 0018:ffffc90001777830 EFLAGS: 00010282 >RAX: 0000000000000058 RBX: ffff8880a973ef00 RCX: 0000000000000000 >RDX: ffff888094f1c200 RSI: ffffffff815d4ef7 RDI: fffff520002eeef8 >RBP: ffff88808e9b6418 R08: 0000000000000058 R09: ffff8880ae7318e7 >R10: 0000000000000000 R11: 0000000000000000 R12: ffff8880a973ef00 >R13: ffff888087315270 R14: ffff88808e9b6430 R15: ffff88808e9b6418 >FS: 0000000000000000(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000 >CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >CR2: 00007ffdcd6db747 CR3: 000000009ba09000 CR4: 00000000001406e0 >DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 >Call Trace: > __list_add include/linux/list.h:67 [inline] > list_add_tail include/linux/list.h:100 [inline] > kobj_kset_join lib/kobject.c:196 [inline] > kobject_add_internal+0x18d/0x940 lib/kobject.c:246 > kobject_add_varg lib/kobject.c:390 [inline] > kobject_add+0x150/0x1c0 lib/kobject.c:442 > device_add+0x35a/0x1be0 drivers/base/core.c:2633 > hci_conn_add_sysfs+0x84/0xe0 net/bluetooth/hci_sysfs.c:53 > hci_conn_complete_evt net/bluetooth/hci_event.c:2607 [inline] > hci_event_packet+0xe0b/0x86f5 net/bluetooth/hci_event.c:6033 > hci_rx_work+0x22e/0xb10 net/bluetooth/hci_core.c:4705 > process_one_work+0x94c/0x1670 kernel/workqueue.c:2269 > worker_thread+0x64c/0x1120 kernel/workqueue.c:2415 > kthread+0x3b5/0x4a0 kernel/kthread.c:291 > ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:293 >Modules linked in: >---[ end trace b1bcc552c32d25e9 ]--- >RIP: 0010:__list_add_valid.cold+0x26/0x3c lib/list_debug.c:29 >Code: 57 ff ff ff 4c 89 e1 48 c7 c7 20 92 93 88 e8 b1 f1 c1 fd 0f 0b 48 89 f2 4c 89 e1 48 89 ee 48 c7 c7 60 93 93 88 e8 9a f1 c1 fd <0f> 0b 48 89 f1 48 c7 c7 e0 92 93 88 4c 89 e6 e8 86 f1 c1 fd 0f 0b >RSP: 0018:ffffc90001777830 EFLAGS: 00010282 >RAX: 0000000000000058 RBX: ffff8880a973ef00 RCX: 0000000000000000 >RDX: ffff888094f1c200 RSI: ffffffff815d4ef7 RDI: fffff520002eeef8 >RBP: ffff88808e9b6418 R08: 0000000000000058 R09: ffff8880ae7318e7 >R10: 0000000000000000 R11: 0000000000000000 R12: ffff8880a973ef00 >R13: ffff888087315270 R14: ffff88808e9b6430 R15: ffff88808e9b6418 >FS: 0000000000000000(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000 >CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 >CR2: 00007ffdcd6db747 CR3: 0000000009a79000 CR4: 00000000001406e0 >DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 >DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > >--- >This report is generated by a bot. It may contain errors. >See https://goo.gl/tpsmEJ for more information about syzbot. >syzbot engineers can be reached at syzkaller@googlegroups.com. > >syzbot will keep track of this issue. See: >https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >For information about bisection process see: https://goo.gl/tpsmEJ#bisection >syzbot can test patches for this issue, for details see: >https://goo.gl/tpsmEJ#testing-patches > >-- >You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group. >To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bugs+unsubscribe@googlegroups.com. >To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/000000000000c57f2d05ac4c5b8e%40google.com. This problem occurs because the HCI_EV_CONN_COMPLETE event packet is sent twice for the same HCI connection, struct hci_ev_conn_complete complete; memset(&complete, 0, sizeof(complete)); complete.status = 0; complete.handle = HCI_HANDLE_1; memset(&complete.bdaddr, 0xaa, 6); *(uint8_t*)&complete.bdaddr.b[5] = 0x10; complete.link_type = ACL_LINK; complete.encr_mode = 0; hci_send_event_packet(vhci_fd, HCI_EV_CONN_COMPLETE, &complete, sizeof(complete)); which leads to kobject_add being called twice. Thus duplicate (struct hci_conn *conn)->dev.kobj.entry is inserted into (struct hci_conn *conn)->dev.kobj.kset->list. But if it's the HCI connection creator's responsibility to not send the HCI_EV_CONN_COMPLETE event packet twice, then it's not a valid bug. Or should we make the kernel more robust by defending against this case? -- Best regards, Coiby _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees