From: Himadri Pandya <himadrispandya@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Himadri Pandya <himadrispandya@gmail.com>
Subject: [Linux-kernel-mentees] [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd()
Date: Sun, 23 Aug 2020 13:50:42 +0530 [thread overview]
Message-ID: <20200823082042.20816-1-himadrispandya@gmail.com> (raw)
Initialize the buffer before passing it to usb_read_cmd() function(s) to
fix the uninit-was-stored issue in asix_read_cmd().
Fixes: KMSAN: kernel-infoleak in raw_ioctl
Reported by: syzbot+a7e220df5a81d1ab400e@syzkaller.appspotmail.com
Signed-off-by: Himadri Pandya <himadrispandya@gmail.com>
---
drivers/net/usb/asix_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index e39f41efda3e..a67ea1971b78 100644
--- a/drivers/net/usb/asix_common.c
+++ b/drivers/net/usb/asix_common.c
@@ -17,6 +17,8 @@ int asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
BUG_ON(!dev);
+ memset(data, 0, size);
+
if (!in_pm)
fn = usbnet_read_cmd;
else
--
2.17.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next reply other threads:[~2020-08-23 8:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-23 8:20 Himadri Pandya [this message]
2020-08-23 9:26 ` [Linux-kernel-mentees] [PATCH] net: usb: Fix uninit-was-stored issue in asix_read_cmd() Dmitry Vyukov via Linux-kernel-mentees
2020-08-23 10:19 ` Greg Kroah-Hartman
2020-08-23 10:31 ` Dmitry Vyukov via Linux-kernel-mentees
2020-08-23 10:56 ` Greg Kroah-Hartman
2020-08-23 10:58 ` Greg Kroah-Hartman
2020-08-23 12:38 ` Himadri Pandya
2020-08-24 8:55 ` Dmitry Vyukov via Linux-kernel-mentees
2020-08-25 6:51 ` Greg Kroah-Hartman
2020-08-25 6:54 ` Greg Kroah-Hartman
2020-08-25 14:39 ` Alan Stern
2020-08-25 14:44 ` Greg Kroah-Hartman
2020-08-25 15:44 ` Greg Kroah-Hartman
2020-08-24 18:16 ` Jakub Kicinski
2020-08-25 6:36 ` Himadri Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200823082042.20816-1-himadrispandya@gmail.com \
--to=himadrispandya@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).