From: Kees Cook <keescook@chromium.org> To: Lukas Bulwahn <lukas.bulwahn@gmail.com> Cc: kernel-hardening@lists.openwall.com, maennich@google.com, linux-kernel@vger.kernel.org, re.emese@gmail.com, linux-spdx@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>, Linux-kernel-mentees@lists.linuxfoundation.org, tglx@linutronix.de Subject: Re: [Linux-kernel-mentees] [PATCH] scripts: Add intended executable mode and SPDX license Date: Mon, 31 Aug 2020 12:20:45 -0700 [thread overview] Message-ID: <202008311219.8ECE17B6B@keescook> (raw) In-Reply-To: <alpine.DEB.2.21.2008310714560.8556@felia> On Mon, Aug 31, 2020 at 07:45:25AM +0200, Lukas Bulwahn wrote: > > > On Sun, 30 Aug 2020, Andrew Morton wrote: > > > On Thu, 27 Aug 2020 14:54:05 +0530 Mrinal Pandey <mrinalmni@gmail.com> wrote: > > > > > commit b72231eb7084 ("scripts: add spdxcheck.py self test") added the file > > > spdxcheck-test.sh to the repository without the executable flag and license > > > information. > > > > The x bit shouldn't matter. > > > > If someone downloads and applies patch-5.9.xz (which is a supported way > > of obtaining a kernel) then patch(1) will erase the x bit anyway. > > > > Andrew, Kees, > > thanks for the feedback. > > As his mentor, I see two valuable tasks for Mrinal to work on: > > 1. Document this knowledge how scripts should be called, not relying on > the executable bit, probably best somewhere here: > ./Documentation/kbuild/makefiles.rst, a new section on using dedicated > scripts in chapter 3 ("The kbuild files"). > > https://www.kernel.org/doc/html/latest/kbuild/makefiles.html#the-kbuild-files Yes, that would be excellent. > 2. Determine if there are places in the build Makefiles that do rely on > the executable bit and fix those script invocations. (Kees' idea of remove > all executable bits and see...) I think this has value, yes. I don't think patches to remove the x bits are needed, but any cases where they are depended on need to be fixed. And I think "3" could be "wire up or remove spdx shell script" -- Kees Cook _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-08-31 19:20 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-27 9:24 Mrinal Pandey 2020-08-27 9:34 ` Lukas Bulwahn 2020-08-27 9:43 ` Greg KH 2020-08-27 9:49 ` Lukas Bulwahn 2020-08-27 10:00 ` Greg KH 2020-08-27 18:14 ` Kees Cook 2020-08-31 0:44 ` Andrew Morton 2020-08-31 5:45 ` Lukas Bulwahn 2020-08-31 19:20 ` Kees Cook [this message] -- strict thread matches above, loose matches on Subject: below -- 2020-08-27 6:05 Mrinal Pandey 2020-08-27 6:13 ` Mrinal Pandey 2020-08-27 6:16 ` Lukas Bulwahn 2020-08-27 6:26 ` Mrinal Pandey 2020-08-27 7:24 ` Lukas Bulwahn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202008311219.8ECE17B6B@keescook \ --to=keescook@chromium.org \ --cc=Linux-kernel-mentees@lists.linuxfoundation.org \ --cc=akpm@linux-foundation.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spdx@vger.kernel.org \ --cc=lukas.bulwahn@gmail.com \ --cc=maennich@google.com \ --cc=re.emese@gmail.com \ --cc=tglx@linutronix.de \ --subject='Re: [Linux-kernel-mentees] [PATCH] scripts: Add intended executable mode and SPDX license' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).