archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <>
	kernel list <>,
Subject: [Linux-kernel-mentees] Help wanted in LED subsystem
Date: Fri, 25 Sep 2020 12:47:39 +0200	[thread overview]
Message-ID: <20200925104739.GA26609@amd> (raw)

[-- Attachment #1.1: Type: text/plain, Size: 2594 bytes --]


In linux-next, I published TODO list for LED subsystem. Is that
something linux-kernel-mentees could help with?

Best regards,

+++ b/drivers/leds/TODO
@@ -0,0 +1,58 @@
+-*- org -*-
+* On/off LEDs should have max_brightness of 1
+* Get rid of enum led_brightness
+It is really an integer, as maximum is configurable. Get rid of it, or
+make it into typedef or something.
+* Review atomicity requirements in LED subsystem
+Calls that may and that may not block are mixed in same structure, and
+semantics is sometimes non-intuitive. (For example blink callback may
+not sleep.) Review the requirements for any bugs and document them
+* LED names are still a mess
+No two LEDs have same name, so the names are probably unusable for the
+userland. Nudge authors into creating common LED names for common
+? Perhaps check for known LED names during boot, and warn if there are
+LEDs not on the list?
+* Split drivers into subdirectories
+The number of drivers is getting big, and driver for on/off LED on a
+i/o port is really quite different from camera flash LED, which is
+really different from driver for RGB color LED that can run its own
+microcode. Split the drivers somehow.
+* Figure out what to do with RGB leds
+Multicolor is a bit too abstract. Yes, we can have
+Green-Magenta-Ultraviolet LED, but so far all the LEDs we support are
+RGB, and not even RGB-White or RGB-Yellow variants emerged.
+Multicolor is not a good fit for RGB LED. It does not really know
+about LED color.  In particular, there's no way to make LED "white".
+Userspace is interested in knowing "this LED can produce arbitrary
+color", which not all multicolor LEDs can.
+	Proposal: let's add "rgb" to led_colors in drivers/leds/led-core.c,
+	add corresponding device tree defines, and use that, instead of
+	multicolor for RGB LEDs.
+	We really need to do that now; "white" stuff can wait.
+RGB LEDs are quite common, and it would be good to be able to turn LED
+white and to turn it into any arbitrary color. It is essential that
+userspace is able to set arbitrary colors, and it might be good to
+have that ability from kernel, too... to allow full-color triggers.
+* Command line utility to manipulate the LEDs?
+/sys interface is not really suitable to use by hand, should we have
+an utility to perform LED control?

(cesky, pictures)

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

Linux-kernel-mentees mailing list

             reply	other threads:[~2020-09-25 10:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 10:47 Pavel Machek [this message]
2020-09-25 14:28 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200925104739.GA26609@amd \ \ \ \ \
    --subject='Re: [Linux-kernel-mentees] Help wanted in LED subsystem' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).