archive mirror
 help / color / mirror / Atom feed
From: Dwaipayan Ray <>
Subject: [Linux-kernel-mentees] [PATCH RFC 1/2] checkpatch: fix multi-statement macro checks
Date: Thu,  1 Oct 2020 02:33:32 +0530	[thread overview]
Message-ID: <> (raw) generates errors which are false positive for
certain multi-statemenent macros.

The specific case investigated was whitespace separated statement
terminated by a semicolon. Checkpatch wrongly classifies such
as a multi-statement macro.

For example, commit 4649079b9de1 ("tracing: Make ftrace packed
events have align of 1") when analyzed with checkpatch generates:

ERROR: Macros with multiple statements should be enclosed in a do -
while loop
+#define __field_packed(type, container, item)    type item;

The error is misleading in this case and should not be produced.
The solution undertaken is to exclude any macro which doesn't
have any non-WSP character after the first and only semicolon(;)
present in it. This shall allow macros of the form "type item;",
"type item[size];", etc. to not generate the multi-statement macro

Signed-off-by: Dwaipayan Ray <>
 scripts/ | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/ b/scripts/
index 9e65d21456f1..72c4072307ea 100755
--- a/scripts/
+++ b/scripts/
@@ -5346,6 +5346,7 @@ sub process {
 			    $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&	# for (...) bar()
 			    $dstat !~ /^do\s*{/ &&					# do {...
 			    $dstat !~ /^\(\{/ &&						# ({...
+			    $dstat !~ /^[^;]*;\s*$/ &&				# space separated statement;
 			    $ctx !~ /^.\s*#\s*define\s+TRACE_(?:SYSTEM|INCLUDE_FILE|INCLUDE_PATH)\b/)
 				if ($dstat =~ /^\s*if\b/) {

Linux-kernel-mentees mailing list

             reply	other threads:[~2020-09-30 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 21:03 Dwaipayan Ray [this message]
2020-09-30 21:03 ` [Linux-kernel-mentees] [PATCH RFC 2/2] checkpatch: fix multi-statement macro checks Dwaipayan Ray
2020-10-01  8:22   ` Lukas Bulwahn
2020-10-01 10:24     ` Dwaipayan Ray
2020-10-01  8:14 ` [Linux-kernel-mentees] [PATCH RFC 1/2] " Lukas Bulwahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).