From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2DFFC4741F for ; Thu, 1 Oct 2020 12:30:51 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C93B21481 for ; Thu, 1 Oct 2020 12:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UClizyI0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C93B21481 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 1A96786951; Thu, 1 Oct 2020 12:30:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NIxrudY+o0xl; Thu, 1 Oct 2020 12:30:50 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id B30EC86940; Thu, 1 Oct 2020 12:30:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A1FF1C0889; Thu, 1 Oct 2020 12:30:50 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 13663C0051 for ; Thu, 1 Oct 2020 12:30:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 00FB720497 for ; Thu, 1 Oct 2020 12:30:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dh4zciD0l5iz for ; Thu, 1 Oct 2020 12:30:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by silver.osuosl.org (Postfix) with ESMTPS id 4746B2048F for ; Thu, 1 Oct 2020 12:30:48 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id t14so3911935pgl.10 for ; Thu, 01 Oct 2020 05:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=08PYeurcX5Vq/35NZf/krIMx9TNkE2AMAtJDR5OrRSQ=; b=UClizyI08VIm/vQ8nJqeIAbyEYMxRxqGpcI9FusZBz7DvsVF7ubCMQvbUve487fviP WVkSGVTBZgEnW2uqwsS2/nUzU4MJCNzuNvGBqzbLtgUNDl+gRAoigTtp1ujGLy5LVPik /NyG17ybIW2fvkdWYQWWgfdH/nBL7XXtU4FxHU1G9G344V6VFYGlMRFQW1zkBlP7C3Fs dxIzMfom1Kd8OoeolMSkORkB+cxShrLeYaNny2m2r1/6oK52SDi69U9JCLsAreMlGicF YZOvIPjoCMRNh9JudNtQkLtJp7Mv3Rw32vPomHMAnlFTowUAP+nYPRc43Tl/fsKYTCwH CF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=08PYeurcX5Vq/35NZf/krIMx9TNkE2AMAtJDR5OrRSQ=; b=SkxNqqcTKXsCQuc2BwxSnX+JR1tHRAWi1SNtThdbGYPudUaFHJ6kBPUOtaBz20jWu1 S+9H2j881WU5QwP1dIZvspUct5Af4VoJzKubU/BjUBhjz5ZaJc9twTqdoHCEW37nkwKR qf1XkyezmjvDeFvnixUIIK4atQiKuPwRvtzSeZjTKdsSy7B/bBnlf/uMPmsHiYvBt5xi XdJfp54xijvMkZvzYd+WhH1ZTjSOe2Yt1DgxZX3N13wqdpzXVXxiBIQrhBrd2KFUSdSI Kz2ckllcvtcTeCIYrB4zbkJeGSv0IRqmZ900jS8gMYQ5962u369iz61Pjngmht2wVydJ SXLw== X-Gm-Message-State: AOAM531cem8EbLZqT1PCISj+42DObsvZzYlhj85mtAEwuvj0xI6V1a2D 5bNTGJ+Nf6lc2Vuakl3B/7Y= X-Google-Smtp-Source: ABdhPJxR7bQaE+TCO8waq1FrQFlsa8qiJ19vieCYYeJwvWOnmGAIFrqiOfw1z33AhlDcElu7bocMWA== X-Received: by 2002:a62:19c1:0:b029:13c:1611:6529 with SMTP id 184-20020a6219c10000b029013c16116529mr6783201pfz.9.1601555447756; Thu, 01 Oct 2020 05:30:47 -0700 (PDT) Received: from varodek.localdomain ([171.61.143.130]) by smtp.gmail.com with ESMTPSA id m13sm5695199pjl.45.2020.10.01.05.30.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2020 05:30:47 -0700 (PDT) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , Adaptec OEM Raid Solutions , Hannes Reinecke , Bradley Grove , John Garry , Don Brace , James Smart , Dick Kennedy , Kashyap Desai , Sumit Saxena , Shivasharan S , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Jack Wang Date: Thu, 1 Oct 2020 17:55:00 +0530 Message-Id: <20201001122511.1075420-18-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201001122511.1075420-1-vaibhavgupta40@gmail.com> References: <20201001122511.1075420-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Cc: linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com, esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, megaraidlinux.pdl@broadcom.com Subject: [Linux-kernel-mentees] [PATCH v3 17/28] scsi: pm_8001: Drop PCI Wakeup calls from .resume X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" The driver calls pci_enable_wake(...., false) in pm8001_pci_resume(), and there is no corresponding pci_enable_wake(...., true) in pm8001_pci_suspend(). Either it should do enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this driver doesn't support enable-wake and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from pm8001_pci__resume(). Signed-off-by: Vaibhav Gupta --- drivers/scsi/pm8001/pm8001_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index 9e99262a2b9d..ee27ecb17560 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -1248,7 +1248,6 @@ static int pm8001_pci_resume(struct pci_dev *pdev) "operating state [D%d]\n", pdev, pm8001_ha->name, device_state); pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); rc = pci_enable_device(pdev); if (rc) { -- 2.28.0 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees