linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	Adam Radford <aradford@gmail.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
	Hannes Reinecke <hare@suse.com>,
	Bradley Grove <linuxdrivers@attotech.com>,
	John Garry <john.garry@huawei.com>,
	Don Brace <don.brace@microsemi.com>,
	James Smart <james.smart@broadcom.com>,
	Dick Kennedy <dick.kennedy@broadcom.com>,
	Kashyap Desai <kashyap.desai@broadcom.com>,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
	Jack Wang <jinpu.wang@cloud.ionos.com>
Cc: linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
	esc.storagedev@microsemi.com, linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	megaraidlinux.pdl@broadcom.com
Subject: [Linux-kernel-mentees] [PATCH v3 22/28] scsi: 3w-sas: Drop PCI Wakeup calls from .resume
Date: Thu,  1 Oct 2020 17:55:05 +0530	[thread overview]
Message-ID: <20201001122511.1075420-23-vaibhavgupta40@gmail.com> (raw)
In-Reply-To: <20201001122511.1075420-1-vaibhavgupta40@gmail.com>

The driver calls pci_enable_wake(...., false) in twl_resume(), and
there is no corresponding pci_enable_wake(...., true) in twl_suspend().
Either it should do enable-wake the device in .suspend() or should not
invoke pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
twl_resume().

Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
---
 drivers/scsi/3w-sas.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c
index dda6fa857709..0b4888199699 100644
--- a/drivers/scsi/3w-sas.c
+++ b/drivers/scsi/3w-sas.c
@@ -1795,7 +1795,6 @@ static int twl_resume(struct pci_dev *pdev)
 
 	printk(KERN_WARNING "3w-sas: Resuming host %d.\n", tw_dev->host->host_no);
 	pci_set_power_state(pdev, PCI_D0);
-	pci_enable_wake(pdev, PCI_D0, 0);
 	pci_restore_state(pdev);
 
 	retval = pci_enable_device(pdev);
-- 
2.28.0

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-10-01 12:31 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 12:24 [Linux-kernel-mentees] [PATCH v3 00/28] scsi: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 01/28] scsi: megaraid_sas: Drop PCI wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 02/28] scsi: megaraid_sas: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 03/28] scsi: megaraid_sas: update function description Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 04/28] scsi: aacraid: Drop pci_enable_wake() from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 05/28] scsi: aacraid: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 06/28] scsi: aic7xxx: " Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 07/28] scsi: aic79xx: " Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 08/28] scsi: arcmsr: Drop PCI wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 09/28] scsi: arcmsr: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 10/28] scsi: esas2r: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 11/28] scsi: esas2r: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 12/28] scsi: hisi_sas_v3_hw: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 13/28] scsi: hisi_sas_v3_hw: use generic power management Vaibhav Gupta
2020-10-27 17:11   ` John Garry
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 14/28] scsi: mpt3sas_scsih: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 15/28] scsi: mpt3sas_scsih: use generic power management Vaibhav Gupta
2020-10-01 12:24 ` [Linux-kernel-mentees] [PATCH v3 16/28] scsi: lpfc: " Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 17/28] scsi: pm_8001: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:53   ` Jinpu Wang
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 18/28] scsi: pm_8001: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 19/28] scsi: hpsa: " Vaibhav Gupta
2020-10-27 16:16   ` Don.Brace--- via Linux-kernel-mentees
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 20/28] scsi: 3w-9xxx: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 21/28] scsi: 3w-9xxx: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` Vaibhav Gupta [this message]
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 23/28] scsi: 3w-sas: " Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 24/28] scsi: mvumi: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 25/28] scsi: mvumi: use generic power management Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 26/28] scsi: mvumi: update function description Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 27/28] scsi: pmcraid: Drop PCI Wakeup calls from .resume Vaibhav Gupta
2020-10-01 12:25 ` [Linux-kernel-mentees] [PATCH v3 28/28] scsi: pmcraid: use generic power management Vaibhav Gupta
2020-10-01 12:33 ` [Linux-kernel-mentees] [PATCH v3 00/28] scsi: " Vaibhav Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001122511.1075420-23-vaibhavgupta40@gmail.com \
    --to=vaibhavgupta40@gmail.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=aacraid@microsemi.com \
    --cc=aradford@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn@helgaas.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=don.brace@microsemi.com \
    --cc=esc.storagedev@microsemi.com \
    --cc=hare@suse.com \
    --cc=helgaas@kernel.org \
    --cc=james.smart@broadcom.com \
    --cc=jejb@linux.ibm.com \
    --cc=jinpu.wang@cloud.ionos.com \
    --cc=john.garry@huawei.com \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxdrivers@attotech.com \
    --cc=martin.petersen@oracle.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=vaibhav.varodek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).