From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: yashsri421@gmail.com, Dwaipayan Ray <dwaipayanray1@gmail.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v3] checkpatch: improve email parsing
Date: Thu, 5 Nov 2020 21:08:57 +0100 [thread overview]
Message-ID: <20201105200857.GC1333458@kroah.com> (raw)
In-Reply-To: <f83c2eeafdebc6307ee6e515e4d6652b2606a068.camel@perches.com>
On Thu, Nov 05, 2020 at 09:41:15AM -0800, Joe Perches wrote:
> (adding stable and Greg KH for additional review)
> On Thu, 2020-11-05 at 17:29 +0530, Dwaipayan Ray wrote:
> > checkpatch doesn't report warnings for many common mistakes
> > in emails. Some of which are trailing commas and incorrect
> > use of email comments.
>
> I presume you've tested this against the git tree.
>
> Can you send me a file with the BAD_SIGN_OFF messages generated
> and if possible the git SHA-1s of the commits?
>
> > At the same time several false positives are reported due to
> > incorrect handling of mail comments. The most common of which
> > is due to the pattern:
> >
> > <stable@vger.kernel.org> # X.X
> >
> > Improve email parsing in checkpatch.
> >
> > Some general comment rules are defined:
> >
> > - Multiple name comments should not be allowed.
> > - Comments inside address should not be allowed.
> > - In general comments should be enclosed within parentheses.
> > Exception for stable@vger.kernel.org # X.X
>
> not just vger.kernel.org, but this should also allow stable@kernel.org
> and only allow cc: and not any other -by: type for that email address.
>
> A process preference question for Greg and the stable team:
>
> The most common stable forms are
>
> stable@vger.kernel.org # version info
That is what is documented it should be, yes.
> then
> stable@vger.kernel.org [ version info ]
Really? Ick, no wonder my email parsing scripts choke on that :)
> with some other relatively infrequently used outlier styles, some
> that use parentheses, but this is not frequent.
The one with '#' should be preferred. If not, we need to change our
documentation.
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-11-05 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 11:59 [Linux-kernel-mentees] [PATCH v3] checkpatch: improve email parsing Dwaipayan Ray
2020-11-05 17:41 ` Joe Perches
2020-11-05 20:08 ` Greg KH [this message]
[not found] ` <CABJPP5BTRtAjdNQdRCx-3HjmyJ0AnoXBzB95YiPRMoF0njOOaA@mail.gmail.com>
2020-11-06 0:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105200857.GC1333458@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).