Linux Kernel Mentees Archive on lore.kernel.org
 help / color / Atom feed
* Re: [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after *
@ 2020-01-16 10:40 Markus Elfring
  2020-01-16 10:56 ` Jaskaran Singh
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Elfring @ 2020-01-16 10:40 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees

> In certain cases, there is no space added after the Pointer type.

Will such a pretty-printing detail matter also for the clarification of
a topic like “Make change influence configurable for coding style rules”?
https://github.com/coccinelle/coccinelle/issues/37

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after *
  2020-01-16 10:40 [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after * Markus Elfring
@ 2020-01-16 10:56 ` Jaskaran Singh
  2020-01-16 10:59   ` Julia Lawall
  2020-01-16 13:02   ` [Linux-kernel-mentees] [Cocci] " Markus Elfring
  0 siblings, 2 replies; 6+ messages in thread
From: Jaskaran Singh @ 2020-01-16 10:56 UTC (permalink / raw)
  To: Markus Elfring; +Cc: linux-kernel-mentees, cocci

On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote:
> > In certain cases, there is no space added after the Pointer type.
> 
> Will such a pretty-printing detail matter also for the clarification
> of
> a topic like “Make change influence configurable for coding style
> rules”?
> https://github.com/coccinelle/coccinelle/issues/37
> 

Not sure what you mean. If you mean to say that the result should
conform to the Linux coding style (i.e. the result should be "const
char * const * y" with spaces et al intact), that seems like something
for a different patch, right? Whether you want Coccinelle to conform to
Linux coding style or not, the space should be added either way.

Cheers,
Jaskaran.

> Regards,
> Markus

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after *
  2020-01-16 10:56 ` Jaskaran Singh
@ 2020-01-16 10:59   ` Julia Lawall
  2020-01-16 11:31     ` Jaskaran Singh
  2020-01-16 13:02   ` [Linux-kernel-mentees] [Cocci] " Markus Elfring
  1 sibling, 1 reply; 6+ messages in thread
From: Julia Lawall @ 2020-01-16 10:59 UTC (permalink / raw)
  To: Jaskaran Singh; +Cc: linux-kernel-mentees, Markus Elfring, cocci

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]



On Thu, 16 Jan 2020, Jaskaran Singh wrote:

> On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote:
> > > In certain cases, there is no space added after the Pointer type.
> >
> > Will such a pretty-printing detail matter also for the clarification
> > of
> > a topic like “Make change influence configurable for coding style
> > rules”?
> > https://github.com/coccinelle/coccinelle/issues/37
> >
>
> Not sure what you mean. If you mean to say that the result should
> conform to the Linux coding style (i.e. the result should be "const
> char * const * y" with spaces et al intact), that seems like something
> for a different patch, right? Whether you want Coccinelle to conform to
> Linux coding style or not, the space should be added either way.


The option --smpl-spacing should address this issue, by preservign the
spacing illustrated in the semantic patch.  I don't know if it does that
in this case.

julia

>
> Cheers,
> Jaskaran.
>
> > Regards,
> > Markus
>
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after *
  2020-01-16 10:59   ` Julia Lawall
@ 2020-01-16 11:31     ` Jaskaran Singh
  2020-01-16 11:36       ` Jaskaran Singh
  0 siblings, 1 reply; 6+ messages in thread
From: Jaskaran Singh @ 2020-01-16 11:31 UTC (permalink / raw)
  To: Julia Lawall; +Cc: linux-kernel-mentees, Markus Elfring, cocci

On Thu, 2020-01-16 at 11:59 +0100, Julia Lawall wrote:
> 
> On Thu, 16 Jan 2020, Jaskaran Singh wrote:
> 
> > On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote:
> > > > In certain cases, there is no space added after the Pointer
> > > > type.
> > > 
> > > Will such a pretty-printing detail matter also for the
> > > clarification
> > > of
> > > a topic like “Make change influence configurable for coding style
> > > rules”?
> > > https://github.com/coccinelle/coccinelle/issues/37
> > > 
> > 
> > Not sure what you mean. If you mean to say that the result should
> > conform to the Linux coding style (i.e. the result should be "const
> > char * const * y" with spaces et al intact), that seems like
> > something
> > for a different patch, right? Whether you want Coccinelle to
> > conform to
> > Linux coding style or not, the space should be added either way.
> 
> The option --smpl-spacing should address this issue, by preservign
> the
> spacing illustrated in the semantic patch.  I don't know if it does
> that
> in this case.
> 

Hm, can't say that it does. Here's what I get with --smpl-spacing on
case https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06696.html

before:

 void main() {
-	const char * const * x;
+	const char *const*y  ;
 }

after:

 void main() {
-	const char * const * x;
+	const char *const *y  ;
 }

Cheers,
Jaskaran.

> julia
> 
> > Cheers,
> > Jaskaran.
> > 
> > > Regards,
> > > Markus
> > 
> > _______________________________________________
> > Cocci mailing list
> > Cocci@systeme.lip6.fr
> > https://systeme.lip6.fr/mailman/listinfo/cocci

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after *
  2020-01-16 11:31     ` Jaskaran Singh
@ 2020-01-16 11:36       ` Jaskaran Singh
  0 siblings, 0 replies; 6+ messages in thread
From: Jaskaran Singh @ 2020-01-16 11:36 UTC (permalink / raw)
  To: Jaskaran Singh; +Cc: Julia Lawall, linux-kernel-mentees, Markus Elfring, cocci

On Thu, 2020-01-16 at 17:01 +0530, Jaskaran Singh wrote:
> On Thu, 2020-01-16 at 11:59 +0100, Julia Lawall wrote:
> > On Thu, 16 Jan 2020, Jaskaran Singh wrote:
> > 
> > > On Thu, 2020-01-16 at 11:40 +0100, Markus Elfring wrote:
> > > > > In certain cases, there is no space added after the Pointer
> > > > > type.
> > > > 
> > > > Will such a pretty-printing detail matter also for the
> > > > clarification
> > > > of
> > > > a topic like “Make change influence configurable for coding
> > > > style
> > > > rules”?
> > > > https://github.com/coccinelle/coccinelle/issues/37
> > > > 
> > > 
> > > Not sure what you mean. If you mean to say that the result should
> > > conform to the Linux coding style (i.e. the result should be
> > > "const
> > > char * const * y" with spaces et al intact), that seems like
> > > something
> > > for a different patch, right? Whether you want Coccinelle to
> > > conform to
> > > Linux coding style or not, the space should be added either way.
> > 
> > The option --smpl-spacing should address this issue, by preservign
> > the
> > spacing illustrated in the semantic patch.  I don't know if it does
> > that
> > in this case.
> > 
> 
> Hm, can't say that it does. Here's what I get with --smpl-spacing on
> case https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06696.html
> 

Whoops, incorrect link
https://www.mail-archive.com/cocci@systeme.lip6.fr/msg06695.html

Cheers,
Jaskaran.

> before:
> 
>  void main() {
> -	const char * const * x;
> +	const char *const*y  ;
>  }
> 
> after:
> 
>  void main() {
> -	const char * const * x;
> +	const char *const *y  ;
>  }
> 
> Cheers,
> Jaskaran.
> 
> > julia
> > 
> > > Cheers,
> > > Jaskaran.
> > > 
> > > > Regards,
> > > > Markus
> > > 
> > > _______________________________________________
> > > Cocci mailing list
> > > Cocci@systeme.lip6.fr
> > > https://systeme.lip6.fr/mailman/listinfo/cocci

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Linux-kernel-mentees] [Cocci] parsing_c: Add space for tokens after *
  2020-01-16 10:56 ` Jaskaran Singh
  2020-01-16 10:59   ` Julia Lawall
@ 2020-01-16 13:02   ` " Markus Elfring
  1 sibling, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-01-16 13:02 UTC (permalink / raw)
  To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees

>> https://github.com/coccinelle/coccinelle/issues/37
>
> Not sure what you mean.

I suggest to take another look also at the circumstances for the placement
of white-space characters (around asterisks).
I guess that we come along different pretty-printing preferences.

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-16 10:40 [Linux-kernel-mentees] [Cocci] [PATCH] parsing_c: Add space for tokens after * Markus Elfring
2020-01-16 10:56 ` Jaskaran Singh
2020-01-16 10:59   ` Julia Lawall
2020-01-16 11:31     ` Jaskaran Singh
2020-01-16 11:36       ` Jaskaran Singh
2020-01-16 13:02   ` [Linux-kernel-mentees] [Cocci] " Markus Elfring

Linux Kernel Mentees Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kernel-mentees/0 linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ https://lore.kernel.org/linux-kernel-mentees \
		linux-kernel-mentees@lists.linuxfoundation.org
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxfoundation.lists.linux-kernel-mentees


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git