From: Joe Perches <joe@perches.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org,
Ujjwal Kumar <ujjwalkumar0501@gmail.com>
Subject: Re: [Linux-kernel-mentees] [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS
Date: Wed, 14 Oct 2020 00:35:32 -0700 [thread overview]
Message-ID: <4d55bf3eb55ea91639438eb949268b9a42140759.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2010140908240.6186@felia>
On Wed, 2020-10-14 at 09:17 +0200, Lukas Bulwahn wrote:
> $ clang-format-10 --version
> Ubuntu clang-format version
> 10.0.1-++20200928083909+ef32c611aa2-1~exp1~20200928185400.194
>
> $ clang-format-10 --help | grep 'dry-run'
> --dry-run - If set, do not actually make the formatting
> changes
> --ferror-limit=<uint> - Set the maximum number of clang-format
> errors to emit before stopping (0 = no limit). Used only with --dry-run or -n
> -n - Alias for --dry-run
OK, maybe so.
However I think the clang-format --dry-run output doesn't
currently contain particularly useful information. Maybe
later versions are better than version 10.
For instance:
$ /usr/bin/clang-format-10 --version
clang-format version 10.0.0-4ubuntu1
$ /usr/bin/clang-format-10 --dry-run drivers/net/ethernet/intel/igb/igb_main.c 2>&1 | head -25
drivers/net/ethernet/intel/igb/igb_main.c:54:40: warning: code should be clang-formatted [-Wclang-format-violations]
static const char igb_driver_string[] =
^
drivers/net/ethernet/intel/igb/igb_main.c:56:36: warning: code should be clang-formatted [-Wclang-format-violations]
static const char igb_copyright[] =
^
drivers/net/ethernet/intel/igb/igb_main.c:100:3: warning: code should be clang-formatted [-Wclang-format-violations]
{0, }
^
drivers/net/ethernet/intel/igb/igb_main.c:100:5: warning: code should be clang-formatted [-Wclang-format-violations]
{0, }
^
drivers/net/ethernet/intel/igb/igb_main.c:163:58: warning: code should be clang-formatted [-Wclang-format-violations]
static int igb_ndo_set_vf_vlan(struct net_device *netdev,
^
drivers/net/ethernet/intel/igb/igb_main.c:164:28: warning: code should be clang-formatted [-Wclang-format-violations]
int vf, u16 vlan, u8 qos, __be16 vlan_proto);
^
drivers/net/ethernet/intel/igb/igb_main.c:189:50: warning: code should be clang-formatted [-Wclang-format-violations]
SET_SYSTEM_SLEEP_PM_OPS(igb_suspend, igb_resume)
^
drivers/net/ethernet/intel/igb/igb_main.c:190:21: warning: code should be clang-formatted [-Wclang-format-violations]
SET_RUNTIME_PM_OPS(igb_runtime_suspend, igb_runtime_resume,
^
drivers/net/ethernet/intel/igb/igb_main.c:190:61: warning: code should be clang-formatted [-Wclang-format-violations]
vs
$ ./scripts/checkpatch.pl -f drivers/net/ethernet/intel/igb/igb_main.c 2>&1 | head -25
WARNING: externs should be avoided in .c files
#113: FILE: drivers/net/ethernet/intel/igb/igb_main.c:113:
+int igb_open(struct net_device *);
WARNING: function definition argument 'struct net_device *' should also have an identifier name
#113: FILE: drivers/net/ethernet/intel/igb/igb_main.c:113:
+int igb_open(struct net_device *);
WARNING: externs should be avoided in .c files
#114: FILE: drivers/net/ethernet/intel/igb/igb_main.c:114:
+int igb_close(struct net_device *);
WARNING: function definition argument 'struct net_device *' should also have an identifier name
#114: FILE: drivers/net/ethernet/intel/igb/igb_main.c:114:
+int igb_close(struct net_device *);
CHECK: Alignment should match open parenthesis
#191: FILE: drivers/net/ethernet/intel/igb/igb_main.c:191:
+ SET_RUNTIME_PM_OPS(igb_runtime_suspend, igb_runtime_resume,
+ igb_runtime_idle)
CHECK: Please use a blank line after function/struct/union/enum declarations
#193: FILE: drivers/net/ethernet/intel/igb/igb_main.c:193:
+};
+static void igb_shutdown(struct pci_dev *);
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-14 7:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 12:01 [Linux-kernel-mentees] [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS Ujjwal Kumar
2020-10-13 12:13 ` Ujjwal Kumar
2020-10-13 15:27 ` Joe Perches
2020-10-14 5:46 ` Lukas Bulwahn
2020-10-14 6:01 ` Joe Perches
2020-10-14 6:21 ` Lukas Bulwahn
2020-10-14 6:27 ` Joe Perches
2020-10-14 6:36 ` Lukas Bulwahn
2020-10-14 6:39 ` Joe Perches
2020-10-14 6:47 ` Lukas Bulwahn
2020-10-14 6:58 ` Joe Perches
2020-10-14 7:17 ` Lukas Bulwahn
2020-10-14 7:35 ` Joe Perches [this message]
2020-10-14 17:45 ` Miguel Ojeda
2020-10-14 18:05 ` Joe Perches
2020-10-14 18:32 ` Miguel Ojeda
2020-10-14 18:37 ` Joe Perches
2020-10-14 11:14 ` Ujjwal Kumar
2020-10-16 9:05 ` Ujjwal Kumar
2020-10-16 10:10 ` Lukas Bulwahn
2020-10-16 10:24 ` Dwaipayan Ray
2020-10-16 10:33 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d55bf3eb55ea91639438eb949268b9a42140759.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=ujjwalkumar0501@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).