Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)

Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)

[Markus Elfring]

Would you like to avoid any abbreviations in the patch subject?


> These types would not match previously.

I imagine that this information can be improved for a nicer patch description,
can't it?

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)

[Jaskaran Singh]

On Wed, 2020-02-05 at 19:55 +0100, Markus Elfring wrote:
> Would you like to avoid any abbreviations in the patch subject?
> 

I used abbreviations to keep the patch subject short but still clear.

Would the following be a better subject?

"tests: Add test case to match const pointer variants"

Cheers,
Jaskaran.

> 
> > These types would not match previously.
> 
> I imagine that this information can be improved for a nicer patch
> description,
> can't it?
> 
> Regards,
> Markus

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [Linux-kernel-mentees] [Cocci] [PATCH 2/2] tests: Add test case for matching pointers to const pointers (and variants)

[Julia Lawall]

On Thu, 6 Feb 2020, Jaskaran Singh wrote:

> On Wed, 2020-02-05 at 19:55 +0100, Markus Elfring wrote:
> > Would you like to avoid any abbreviations in the patch subject?
> >
>
> I used abbreviations to keep the patch subject short but still clear.
>
> Would the following be a better subject?
>
> "tests: Add test case to match const pointer variants"

OK for me.

julia

>
> Cheers,
> Jaskaran.
>
> >
> > > These types would not match previously.
> >
> > I imagine that this information can be improved for a nicer patch
> > description,
> > can't it?
> >
> > Regards,
> > Markus
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants

[Markus Elfring]

> Would the following be a better subject?

I find the alternative succinct.

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants

[Markus Elfring]

> Would the following be a better subject?

The alternative is nicer.


Will other implementation details become also more interesting?

The information “Align C AST and Cocci AST” was provided.
https://lore.kernel.org/cocci/20200205130327.6812-2-jaskaransingh7654321@gmail.com/
https://systeme.lip6.fr/pipermail/cocci/2020-February/006840.html

* Should the potential for differences in these “AST” be checked any more?

* How can such items be compared safely?


Is there a need to extend the test format?
https://github.com/coccinelle/coccinelle/issues/134

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants

[Jaskaran Singh]

On Fri, 2020-02-07 at 07:07 +0100, Markus Elfring wrote:
> > Would the following be a better subject?
> 
> The alternative is nicer.
> 
> 
> Will other implementation details become also more interesting?
> 
> The information “Align C AST and Cocci AST” was provided.
> https://lore.kernel.org/cocci/20200205130327.6812-2-jaskaransingh7654321@gmail.com/
> https://systeme.lip6.fr/pipermail/cocci/2020-February/006840.html
> 
> * Should the potential for differences in these “AST” be checked any
> more?
> 

An effort is already being made to do this by me and Julia :)

> * How can such items be compared safely?
> 

Not sure what you mean. If you mean how the two ASTs can be compared,
it's just a process of data collection and debugging.

Cheers,
Jaskaran.

> 
> Is there a need to extend the test format?
> https://github.com/coccinelle/coccinelle/issues/134
> 
> Regards,
> Markus

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [Linux-kernel-mentees] [Cocci] [2/2] tests: Add test case to match const pointer variants

[Markus Elfring]

>> * Should the potential for differences in these “AST” be checked any more?
>
> An effort is already being made to do this by me and Julia :)

I am curious how this collaboration will evolve further.


>> * How can such items be compared safely?
>
> Not sure what you mean. If you mean how the two ASTs can be compared,
> it's just a process of data collection and debugging.

Which programming interfaces do you use for this purpose at the moment?

Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees