linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
* [Linux-kernel-mentees] [PATCH] block/scsi-ioctl: Prevent kernel-infoleak in scsi_put_cdrom_generic_arg()
@ 2020-07-27 16:19 Peilin Ye
  2020-07-27 16:25 ` Jens Axboe
  2020-07-27 19:00 ` [Linux-kernel-mentees] [PATCH v2] " Peilin Ye
  0 siblings, 2 replies; 4+ messages in thread
From: Peilin Ye @ 2020-07-27 16:19 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Arnd Bergmann, linux-kernel, linux-block, linux-kernel-mentees,
	Peilin Ye, Dan Carpenter

scsi_put_cdrom_generic_arg() is copying uninitialized stack memory to
userspace due to the compiler not initializing holes in statically
allocated structures. Fix it by initializing `cgc32` using memset().

Cc: stable@vger.kernel.org
Fixes: f3ee6e63a9df ("compat_ioctl: move CDROM_SEND_PACKET handling into scsi")
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
---
 block/scsi_ioctl.c | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
index ef722f04f88a..1b7f85634751 100644
--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -692,16 +692,19 @@ static int scsi_put_cdrom_generic_arg(const struct cdrom_generic_command *cgc,
 {
 #ifdef CONFIG_COMPAT
 	if (in_compat_syscall()) {
-		struct compat_cdrom_generic_command cgc32 = {
-			.buffer		= (uintptr_t)(cgc->buffer),
-			.buflen		= cgc->buflen,
-			.stat		= cgc->stat,
-			.sense		= (uintptr_t)(cgc->sense),
-			.data_direction	= cgc->data_direction,
-			.quiet		= cgc->quiet,
-			.timeout	= cgc->timeout,
-			.reserved[0]	= (uintptr_t)(cgc->reserved[0]),
-		};
+		struct compat_cdrom_generic_command cgc32;
+
+		memset(&cgc32, 0, sizeof(cgc32));
+
+		cgc32.buffer	= (uintptr_t)(cgc->buffer);
+		cgc32.buflen	= cgc->buflen;
+		cgc32.stat	= cgc->stat;
+		cgc32.sense	= (uintptr_t)(cgc->sense);
+		cgc32.data_direction	= cgc->data_direction;
+		cgc32.quiet	= cgc->quiet;
+		cgc32.timeout	= cgc->timeout;
+		cgc32.reserved[0]	= (uintptr_t)(cgc->reserved[0]);
+
 		memcpy(&cgc32.cmd, &cgc->cmd, CDROM_PACKET_SIZE);
 
 		if (copy_to_user(arg, &cgc32, sizeof(cgc32)))
-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-09  9:51 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 16:19 [Linux-kernel-mentees] [PATCH] block/scsi-ioctl: Prevent kernel-infoleak in scsi_put_cdrom_generic_arg() Peilin Ye
2020-07-27 16:25 ` Jens Axboe
2020-07-27 19:00 ` [Linux-kernel-mentees] [PATCH v2] " Peilin Ye
2020-09-09  9:50   ` [Linux-kernel-mentees] [PATCH v3] " Peilin Ye

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).