Linux Kernel Mentees Archive on
 help / color / Atom feed
From: Joe Perches <>
To: Dwaipayan Ray <>
Subject: Re: [Linux-kernel-mentees] [PATCH RFC] checkpatch: extend same_email_address check to load mailmap entries
Date: Wed, 23 Sep 2020 08:08:56 -0700
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, 2020-09-23 at 16:41 +0530, Dwaipayan Ray wrote:
> > .mailmap entries are used when a person no longer has
> > access to a particular email and a mapping is created to
> > allow these old/invalid email addresses to be converted
> > to a current/valid email address.
> > 
> > The idea here is that a person may have a .gitconfig or
> > equivalent that still uses an old/invalid email address
> > but uses a Signed-off-by: for a current/valid one, so
> > a warning _should_ be emitted for this case.
> > 
> > At least for checkpatch, mismatches in email addresses
> > should not be papered over by assuming equivalence between
> > multiple email addresses.
> > 
> > So this should be a separate test and not used in a function
> > named
> > "same_email_address".  These are specifically _not_
> > the same email
> > addresses.
> > 
> > 
> Hi,
> Thanks for the clarification.
> So instead of eliminating the warning completely will it be a
> better alternative to display a more descriptive warning
> on the lines of:
>    invalid/obsolete email address used in signoff by
>    author $author"
> Or is it better to ignore the mailmap extension in checkpatch
> and just display warnings for either mismatch in name/
> mismatch in email.
> Like, you had mentioned one in:
> In that case, same name, but different mail address was
> reported as a different warning.
> So, I believe two cases can be handled better:
> 1) Same name, different email
> 2) Same email, different name
> For case 2, it might also be possible to ignore the warning
> completely.

Maybe both.

I suggest seeing if extensions to email addresses like:

could be compared to:

and comment blocks like:

	"First Last" (via mailing list) <local_part@domain.tld>
could be compared to:
	"First Last" <local_part@domain.tlc> (MAINTAINER)

Still, I think all of these should emit warnings or
--strict checks messages.

The idea is to notify that some oddity has occurred
rather than silently accept it.

Linux-kernel-mentees mailing list

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 10:02 Dwaipayan Ray
2020-09-23 10:17 ` Joe Perches
2020-09-23 11:11   ` Dwaipayan Ray
2020-09-23 15:08     ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux Kernel Mentees Archive on

Archives are clonable:
	git clone --mirror linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ \
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone