From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19AACC433E0 for ; Mon, 13 Jul 2020 14:56:54 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D39592075D for ; Mon, 13 Jul 2020 14:56:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="nPfmEe2x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D39592075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 92E2E25ED0; Mon, 13 Jul 2020 14:56:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a4TzR60sqXZg; Mon, 13 Jul 2020 14:56:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 85C4525CFB; Mon, 13 Jul 2020 14:56:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 70EC2C088E; Mon, 13 Jul 2020 14:56:52 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3A3BBC0733 for ; Mon, 13 Jul 2020 14:56:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 32498893BD for ; Mon, 13 Jul 2020 14:56:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O7KmVnYvoRfs for ; Mon, 13 Jul 2020 14:56:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by hemlock.osuosl.org (Postfix) with ESMTPS id DBC13893BA for ; Mon, 13 Jul 2020 14:56:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594652210; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=BoC4UrrrSi+4R2yXzSqO6//sG28fBFPCPeK9i2qx488=; b=nPfmEe2xEoe3TAeWJJVUX6uk73DCuey7tBKm9/o1ElwLcfDzFIYStWTxvFasTwYk+lM1ND/H NyYIX8WeXFHA/YOIRbeTjyBiJwqLLPJ/K4PPjSVigLBeQAU8BXZ2trbTWTpkdtoId/edaoiu 9+baieigpnPGkFc6Nkth+nw6P1I= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1ODQyZiIsICJsaW51eC1rZXJuZWwtbWVudGVlc0BsaXN0cy5saW51eGZvdW5kYXRpb24ub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n18.prod.us-west-2.postgun.com with SMTP id 5f0c762b512812c070421145 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 13 Jul 2020 14:56:43 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 84904C433CB; Mon, 13 Jul 2020 14:56:42 +0000 (UTC) Received: from x230.qca.qualcomm.com (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id BE99DC433C6; Mon, 13 Jul 2020 14:56:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BE99DC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Vaibhav Gupta References: <20200629072525.156154-1-vaibhavgupta40@gmail.com> <87a703xys7.fsf@codeaurora.org> Date: Mon, 13 Jul 2020 17:56:36 +0300 In-Reply-To: (Vaibhav Gupta's message of "Mon, 13 Jul 2020 20:15:56 +0530") Message-ID: <875zarxy3f.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , netdev@vger.kernel.org, Bjorn Helgaas , Jakub Kicinski , linux-kernel-mentees@lists.linuxfoundation.org, "David S. Miller" , Stanislav Yakovlev Subject: Re: [Linux-kernel-mentees] [PATCH v1 0/2] ipw2x00: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Vaibhav Gupta writes: > On Mon, Jul 13, 2020, 8:12 PM Kalle Valo wrote: > > Vaibhav Gupta writes: > > > Linux Kernel Mentee: Remove Legacy Power Management. > > > > The purpose of this patch series is to remove legacy power > management callbacks > > from amd ethernet drivers. > > > > The callbacks performing suspend() and resume() operations are > still calling > > pci_save_state(), pci_set_power_state(), etc. and handling the > power management > > themselves, which is not recommended. > > > > The conversion requires the removal of the those function calls > and change the > > callback definition accordingly and make use of dev_pm_ops > structure. > > > > All patches are compile-tested only. > > > > Vaibhav Gupta (2): > > ipw2100: use generic power management > > ipw2200: use generic power management > > > > drivers/net/wireless/intel/ipw2x00/ipw2100.c | 31 > +++++--------------- > > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 30 > +++++-------------- > > amd ethernet drivers? That must be a copy paste error. But no need > to > resend because of this. > > > Yes. I am genuinely sorry for this. My two patch-series had same > changes, so I copy-pasted the cover letter. Forgot to replace the > name. No worries. But PLEASE don't send HTML email, lists filter those out: Content-Type: text/html; charset="UTF-8" -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees