archive mirror
 help / color / mirror / Atom feed
From: "Ayush" <>
To: "Lukas Bulwahn" <>
Subject: Re: [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve"
Date: Mon, 07 Sep 2020 14:27:50 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

September 7, 2020 1:09 PM, "Lukas Bulwahn" <> wrote:
> I think you should extend this whole check to work properly with line
> breaks. You can see how this is implemented currently in
> just a few lines above, right?

I have written the conditions for handling line breaks.

I will be sending the patch to the mailing list after this mail.

> Can you provide a full list of findings in v5.4..v5.8
> where all the different commit 1234567890ab ("Revert "..."") variants
> in the commit message appear?
> Then, we can use those commits directly as test cases for your extension?

Actually, I have made a list for some of the similar commits which are correct but will give GIT_COMMIT_ID error on them. I have tested my patch with 30+ commits.

Here is the list of commits:

Some doubts I still have:
- commit
1234567890ab ("Revert "foo bar"")

is not allowed as per the rules, right? 

- if the commit mentioned has double-quotes like:
commit 1234567890ab ("Revert "foo "lorem ipsum" bar"")


For now, is giving an error in such cases too. But there can be `n` cases like these, we 
can have so many quotes nested, so I think it's better to avoid this pattern, please give your opinions on this.

Linux-kernel-mentees mailing list

  parent reply	other threads:[~2020-09-07 14:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200810125354.xeijyh3v5upatrez@salamander>
2020-08-17  9:43 ` [Linux-kernel-mentees] Regarding "Linux Kernel: Evaluate and Improve" Lukas Bulwahn
2020-08-21 16:18 ` Ayush
2020-08-22  8:06   ` Lukas Bulwahn
2020-08-24 10:06   ` Ayush
2020-08-27  5:28     ` Lukas Bulwahn
2020-08-30 18:51     ` Ayush
2020-08-31  5:14       ` Lukas Bulwahn
2020-09-06  9:59       ` Ayush
2020-09-07  7:38         ` Lukas Bulwahn
2020-09-07 14:27         ` Ayush [this message]
2020-09-07 16:43           ` Lukas Bulwahn
2020-09-09  9:14           ` Ayush
2020-09-09  9:52             ` Lukas Bulwahn
2020-09-09 16:01             ` Ayush
2020-09-10  6:04               ` Lukas Bulwahn
2020-08-26 13:51   ` Ayush

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).