From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF92C2BA1A for ; Fri, 24 Apr 2020 09:42:26 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 789A420736 for ; Fri, 24 Apr 2020 09:42:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 789A420736 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sipsolutions.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 5AA7620013; Fri, 24 Apr 2020 09:42:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Np4LjwzXECD; Fri, 24 Apr 2020 09:42:25 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 9FDAD20430; Fri, 24 Apr 2020 09:42:25 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8E7F8C089E; Fri, 24 Apr 2020 09:42:25 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0766DC0175 for ; Fri, 24 Apr 2020 09:42:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 043FB87B36 for ; Fri, 24 Apr 2020 09:42:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 14dM0q3YZghC for ; Fri, 24 Apr 2020 09:42:23 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sipsolutions.net (s3.sipsolutions.net [144.76.43.62]) by hemlock.osuosl.org (Postfix) with ESMTPS id 495FE821AB for ; Fri, 24 Apr 2020 09:42:23 +0000 (UTC) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1jRuWW-00FRFQ-N1; Fri, 24 Apr 2020 11:21:28 +0200 Message-ID: <8d6fd8bfa0fb66f8ee4bfd34738a349bb1b7ee59.camel@sipsolutions.net> From: Johannes Berg To: madhuparnabhowmik10@gmail.com, davem@davemloft.net, kuba@kernel.org Date: Fri, 24 Apr 2020 11:21:27 +0200 In-Reply-To: <20200409082849.27372-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102909_206741_272D703E) References: <20200409082849.27372-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102909_206741_272D703E) User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Cc: paulmck@kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, joel@joelfernandes.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH 2/4] net: mac80211: scan.c: Fix RCU list related warnings. X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On Thu, 2020-04-09 at 13:58 +0530, madhuparnabhowmik10@gmail.com wrote: > From: Madhuparna Bhowmik > > This patch fixes the following warning: > > WARNING: suspicious RCU usage > [ 84.530619] 5.6.0+ #4 Not tainted > [ 84.530637] ----------------------------- > [ 84.530658] net/mac80211/scan.c:454 RCU-list traversed in non-reader section!! > > As local->mtx is held in __ieee80211_scan_completed() Yeah, but is that really the right lock? I think it should be RTNL or iflist_mtx for the interface list. (Not that this is necessarily a good idea - we perhaps should clean up and significantly reduce the number of locks used here.) johannes _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees