Linux Kernel Mentees Archive on lore.kernel.org
 help / color / Atom feed
* [Linux-kernel-mentees] [RFC PATCH] Documentation: perf: fix kernel-doc warnings in imx-ddr.rst
@ 2019-11-07 18:57 Daniel W. S. Almeida
  2019-11-12 16:46 ` Jonathan Corbet
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel W. S. Almeida @ 2019-11-07 18:57 UTC (permalink / raw)
  To: Frank.li, corbet, shawnguo, s.hauer, kernel, festevam, linux-imx
  Cc: linux-doc, linux-kernel, linux-kernel-mentees,
	Daniel W. S. Almeida, linux-arm-kernel

From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>

Unexpected indentation errors were reported due to missing blank lines.
Now fixed. No change in content otherwise.

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
 Documentation/admin-guide/perf/imx-ddr.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/admin-guide/perf/imx-ddr.rst b/Documentation/admin-guide/perf/imx-ddr.rst
index 517a205abad6..75c8b46ba6f9 100644
--- a/Documentation/admin-guide/perf/imx-ddr.rst
+++ b/Documentation/admin-guide/perf/imx-ddr.rst
@@ -18,6 +18,7 @@ The "format" directory describes format of the config (event ID) and config1
 devices/imx8_ddr0/format/. The "events" directory describes the events types
 hardware supported that can be used with perf tool, see /sys/bus/event_source/
 devices/imx8_ddr0/events/.
+
   e.g.::
         perf stat -a -e imx8_ddr0/cycles/ cmd
         perf stat -a -e imx8_ddr0/read/,imx8_ddr0/write/ cmd
@@ -31,16 +32,19 @@ in the driver.
   Filter is defined with two configuration parts:
   --AXI_ID defines AxID matching value.
   --AXI_MASKING defines which bits of AxID are meaningful for the matching.
+
         0:corresponding bit is masked.
         1: corresponding bit is not masked, i.e. used to do the matching.
 
   AXI_ID and AXI_MASKING are mapped on DPCR1 register in performance counter.
   When non-masked bits are matching corresponding AXI_ID bits then counter is
   incremented. Perf counter is incremented if
+
           AxID && AXI_MASKING == AXI_ID && AXI_MASKING
 
   This filter doesn't support filter different AXI ID for axid-read and axid-write
   event at the same time as this filter is shared between counters.
+
   e.g.::
         perf stat -a -e imx8_ddr0/axid-read,axi_mask=0xMMMM,axi_id=0xDDDD/ cmd
         perf stat -a -e imx8_ddr0/axid-write,axi_mask=0xMMMM,axi_id=0xDDDD/ cmd
@@ -48,5 +52,6 @@ in the driver.
   NOTE: axi_mask is inverted in userspace(i.e. set bits are bits to mask), and
   it will be reverted in driver automatically. so that the user can just specify
   axi_id to monitor a specific id, rather than having to specify axi_mask.
+
   e.g.::
         perf stat -a -e imx8_ddr0/axid-read,axi_id=0x12/ cmd, which will monitor ARID=0x12
-- 
2.24.0

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Linux-kernel-mentees] [RFC PATCH] Documentation: perf: fix kernel-doc warnings in imx-ddr.rst
  2019-11-07 18:57 [Linux-kernel-mentees] [RFC PATCH] Documentation: perf: fix kernel-doc warnings in imx-ddr.rst Daniel W. S. Almeida
@ 2019-11-12 16:46 ` Jonathan Corbet
  2019-11-12 18:45   ` Daniel W. S. Almeida
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2019-11-12 16:46 UTC (permalink / raw)
  To: Daniel W. S. Almeida
  Cc: linux-doc, festevam, s.hauer, Frank.li, linux-kernel, linux-imx,
	kernel, shawnguo, linux-arm-kernel, linux-kernel-mentees

On Thu,  7 Nov 2019 15:57:55 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> wrote:

> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
> 
> Unexpected indentation errors were reported due to missing blank lines.
> Now fixed. No change in content otherwise.
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>

So this is in no way your fault, but this particular file has been the
subject of some merge conflicts in linux-next already, so it's probably
best not to mess with it further at the moment.   Could I ask you to
resubmit the patch after the 5.5 merge window?

Thanks,

jon
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Linux-kernel-mentees] [RFC PATCH] Documentation: perf: fix kernel-doc warnings in imx-ddr.rst
  2019-11-12 16:46 ` Jonathan Corbet
@ 2019-11-12 18:45   ` Daniel W. S. Almeida
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel W. S. Almeida @ 2019-11-12 18:45 UTC (permalink / raw)
  To: Jonathan Corbet
  Cc: linux-doc, festevam, s.hauer, Frank.li, linux-kernel, linux-imx,
	kernel, shawnguo, linux-arm-kernel, linux-kernel-mentees

[-- Attachment #1.1: Type: text/plain, Size: 292 bytes --]

> So this is in no way your fault, but this particular file has been the
> subject of some merge conflicts in linux-next already, so it's probably
> best not to mess with it further at the moment. Could I ask you to
> resubmit the patch after the 5.5 merge window?

Yes that is fine!
Thanks.

[-- Attachment #1.2: Type: text/html, Size: 1252 bytes --]

<blockquote></blockquote><blockquote><font style="font-size:14.5px"><font style="font-family:Nylas-Pro, Helvetica, &quot;Lucidia Grande&quot;, sans-serif">So this is in no way your fault, but this particular file has been the&nbsp;</font></font></blockquote><blockquote><font style="font-size:14.5px"><font style="font-family:Nylas-Pro, Helvetica, &quot;Lucidia Grande&quot;, sans-serif">subject of some merge conflicts in linux-next already, so it's probably&nbsp;</font></font></blockquote><blockquote><font style="font-size:14.5px"><font style="font-family:Nylas-Pro, Helvetica, &quot;Lucidia Grande&quot;, sans-serif">best not to mess with it further at the moment. Could I ask you to&nbsp;</font></font></blockquote><blockquote><font style="font-size:14.5px"><font style="font-family:Nylas-Pro, Helvetica, &quot;Lucidia Grande&quot;, sans-serif">resubmit the patch after the 5.5 merge window?&nbsp;</font></font></blockquote><br><div><font style="font-size:14.5px"><font style="font-family:Nylas-Pro, Helvetica, &quot;Lucidia Grande&quot;, sans-serif">Yes that is fine!</font></font></div><br><div><font style="font-size:14.5px"><font style="font-family:Nylas-Pro, Helvetica, &quot;Lucidia Grande&quot;, sans-serif">Thanks.</font></font></div><br>

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 18:57 [Linux-kernel-mentees] [RFC PATCH] Documentation: perf: fix kernel-doc warnings in imx-ddr.rst Daniel W. S. Almeida
2019-11-12 16:46 ` Jonathan Corbet
2019-11-12 18:45   ` Daniel W. S. Almeida

Linux Kernel Mentees Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-kernel-mentees/0 linux-kernel-mentees/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-kernel-mentees linux-kernel-mentees/ https://lore.kernel.org/linux-kernel-mentees \
		linux-kernel-mentees@lists.linuxfoundation.org
	public-inbox-index linux-kernel-mentees

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxfoundation.lists.linux-kernel-mentees


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git