From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C5AC433E7 for ; Mon, 12 Oct 2020 17:01:37 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B530D2080A for ; Mon, 12 Oct 2020 17:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="amdduy/5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B530D2080A Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2AEB1870BD; Mon, 12 Oct 2020 17:01:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ab9miK6yTgwj; Mon, 12 Oct 2020 17:01:27 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 75999874E8; Mon, 12 Oct 2020 17:01:27 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 25152C0052; Mon, 12 Oct 2020 17:01:27 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CB1ABC0051 for ; Mon, 12 Oct 2020 17:01:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B139B863D9 for ; Mon, 12 Oct 2020 17:01:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id It6tDN-Kb1yf for ; Mon, 12 Oct 2020 17:01:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 244F88638F for ; Mon, 12 Oct 2020 17:01:25 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id b69so18301447qkg.8 for ; Mon, 12 Oct 2020 10:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCRnYr7OZAuZAcdtj6bDyVf0ewb/ybkGa09HFzED0TU=; b=amdduy/5giPhWx4Exy0dTCamqr4kHfG6bp/NqOssiw3ST1GYnr3Epc7jyoGwczCGwx ob2IxQJ3LnTu0FeI3CBERY8VhE5ghjeLw6nxfKCOwJgnZ63JM7a9RQGyfTX7RK6frkBN ++QDmhxK6sGeNsdyKp8jAl2jBl8tjMc12k2PT0mTnronwtFkGfUfb/bo3NqGYBSn8RPR I6NvqQFBTRmtuJVzq3pYLm2q3MaY5ZUqtL1qtunE0JqghspVgIKuitQeub+b/MVK57H7 lOjx4TdIl54QELX1hY3MoQKJOhgiGHZnyK413yvG8HPPT/KvZsMPxyTBpr3XHlh+GlFs 2SiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCRnYr7OZAuZAcdtj6bDyVf0ewb/ybkGa09HFzED0TU=; b=T/hoP2n1jvXrcSNaf6PAemq+fvr665oeqNzqSp6XJ/hvCp4vC7fjMstyKG9ysiIAes Ni9sAa1TwgpqrQ2jFr3y4V5GtA9E+GUUunTk8ysdgtIfgC36nwkQ0XHLbCuCmAWiKulj LZG49z2W52gB+1IUjmZi+LL6dQkzQ7A+4PEZg0PrNKIlN7pInT6yySaxhNQ68gbgpT6M Vw2PHZv/vEPYD1MerbHrxnEPv6L9wJAnB5lZYaoxkeeVL0DBkzq6Tze0emAkAVhaU6Gk 5aH181+BFaMYH2fMzxMc49KO6G7p5PE8GjEBFHKYaeATFLrl/s92uErM3xxeA2QUM/go R0rw== X-Gm-Message-State: AOAM530ZqE5dZwiNTclH2fBfURqtzdvDzF6e4d+Nz5ktGExqjfkaZCpw 8lWX9wbj9IzwJokDTZyw6j72z95u72Mj1UduhbV+1p6g6IGb X-Google-Smtp-Source: ABdhPJwNxnFYa442C2prZ8SKmIsypu1vM6VnLP7chsBuR59gKD8ojMwpsExA7LPkwV9GP4CiZRXYKU6Fc061JyERYco= X-Received: by 2002:ac8:5649:: with SMTP id 9mr10724059qtt.109.1602521635386; Mon, 12 Oct 2020 09:53:55 -0700 (PDT) MIME-Version: 1.0 References: <20201003144807.13036-1-98.arpi@gmail.com> <20201003145115.13145-1-98.arpi@gmail.com> <1028a9d3-4be1-077b-b7dc-1818ba06c528@gmail.com> In-Reply-To: <1028a9d3-4be1-077b-b7dc-1818ba06c528@gmail.com> Date: Mon, 12 Oct 2020 09:53:18 -0700 Message-ID: To: Arpitha Raghunandan <98.arpi@gmail.com> Cc: Marco Elver , Theodore Ts'o , Brendan Higgins , Andreas Dilger , linux-kernel-mentees@lists.linuxfoundation.org, KUnit Development Subject: Re: [Linux-kernel-mentees] [RFC v3 2/2] fs: ext4: Modify inode-test.c to use KUnit parameterized testing X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Iurii Zaikin via Linux-kernel-mentees Reply-To: Iurii Zaikin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Thanks for modernizing the test! > >> +#define NUMBER_OF_TESTCASES 16 If you move the test case array outside the function body, you won't need this because you'll be able to use ARRAY_SIZE. Although it could be argued that the get_test_case_parameters interface should provide the array length to go with the array itself. > >> +struct timestamp_expectation *get_test_parameters(void) static? _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees