linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov via Linux-kernel-mentees <linux-kernel-mentees@lists.linuxfoundation.org>
To: Brooke Basile <brookebasile@gmail.com>
Cc: syzbot <syzbot+4d2d56175b934b9a7bf9@syzkaller.appspotmail.com>,
	USB list <linux-usb@vger.kernel.org>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [Linux-kernel-mentees] INFO: trying to register non-static key in ath9k_htc_rxep
Date: Wed, 23 Sep 2020 20:32:15 +0200	[thread overview]
Message-ID: <CAAeHK+zboT311GNtX0N=Yp_Qph1Gn0XRTJb35HK540GKnOe8LA@mail.gmail.com> (raw)
In-Reply-To: <8f8706c4-090d-20fe-a4c9-40d99d3a0e1c@gmail.com>

On Wed, Sep 23, 2020 at 8:28 PM Brooke Basile <brookebasile@gmail.com> wrote:
>
> On 9/23/20 2:06 PM, Andrey Konovalov wrote:
> > On Wed, Sep 23, 2020 at 7:42 PM Brooke Basile <brookebasile@gmail.com> wrote:
> >>
> >> On 9/22/20 3:38 AM, Dmitry Vyukov wrote:
> >>> On Tue, Sep 22, 2020 at 9:26 AM Greg Kroah-Hartman
> >>> <gregkh@linuxfoundation.org> wrote:
> >>>>
> >>>> On Tue, Sep 22, 2020 at 08:49:39AM +0200, Dmitry Vyukov wrote:
> >>>>> On Tue, Sep 22, 2020 at 8:21 AM syzbot
> >>>>> <syzbot+4d2d56175b934b9a7bf9@syzkaller.appspotmail.com> wrote:
> >>>>>>
> >>>>>> Hello,
> >>>>>>
> >>>>>> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
> >>>>>>
> >>>>>> Reported-and-tested-by: syzbot+4d2d56175b934b9a7bf9@syzkaller.appspotmail.com
> >>>>>>
> >>>>>> Tested on:
> >>>>>>
> >>>>>> commit:         98477740 Merge branch 'rcu/urgent' of git://git.kernel.org..
> >>>>>> git tree:       upstream
> >>>>>> kernel config:  https://syzkaller.appspot.com/x/.config?x=2c523334171d074
> >>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=4d2d56175b934b9a7bf9
> >>>>>> compiler:       gcc (GCC) 10.1.0-syz 20200507
> >>>>>>
> >>>>>> Note: testing is done by a robot and is best-effort only.
> >>>>>
> >>>>> Hi Brooke,
> >>>>>
> >>>>> As far as I understand, UBS is currently completely broken on upstream
> >>>>> HEAD, so testing any USB bugs on upstream HEAD will lead to false
> >>>>> positive results only.
> >>>>
> >>>> Broken in what way?  I don't see any bug reports here...
> >>>
> >>> I mean this "USB driver ID matching broke":
> >>> https://groups.google.com/g/syzkaller/c/VKfxh__m05w/m/ArzTtar-AgAJ
> >>> syzkaller can't test usb, nor reproduce any existing bugs on the upstream tree.
> >>>
> >>
> >> Hi Dmitry,
> >>
> >> Thanks for the heads up and for the link to the thread with the information.
> >>
> >> I recently fixed the following bug:
> >> https://syzkaller.appspot.com/bug?id=cabffad18eb74197f84871802fd2c5117b61febf
> >>
> >> I tested this on my local syzkaller instance before sending it in to
> >> syzbot and the kernel panic was resolved, however I did get "-busid- is
> >> not in match_busid table... skip!" in dmesg-- should this be taken as a
> >> false positive as well?
> >
> > Hi Brooke,
> >
> > Yes, this line means that the kernel is broken and testing USB
> > programs with syzkaller is impossible.
> >
> > Thanks!
> >
> Gotcha, I'll hold off on working on USB bugs for now then.
>
> The above patch has already been applied to the ath-next tree:
>         https://patchwork.kernel.org/patch/11769845/
>
> Should I have the patch reverted or is it safe to assume that any
> regressions will be caught in the -next tree?

If you believe the patch fixes the issue, then it makes sense to keep
it. If it actually doesn't, syzbot will report the bug again once the
patch is in the mainline.

Thanks!
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

      reply	other threads:[~2020-09-23 18:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <13659a4e-ad71-0cef-4bfa-3eb4b8c73f4b@gmail.com>
     [not found] ` <000000000000cce55c05afe0f8f0@google.com>
2020-09-22  6:49   ` Dmitry Vyukov via Linux-kernel-mentees
2020-09-22  7:26     ` Greg Kroah-Hartman
2020-09-22  7:38       ` Dmitry Vyukov via Linux-kernel-mentees
2020-09-23 17:42         ` Brooke Basile
2020-09-23 18:06           ` Andrey Konovalov via Linux-kernel-mentees
2020-09-23 18:28             ` Brooke Basile
2020-09-23 18:32               ` Andrey Konovalov via Linux-kernel-mentees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeHK+zboT311GNtX0N=Yp_Qph1Gn0XRTJb35HK540GKnOe8LA@mail.gmail.com' \
    --to=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=andreyknvl@google.com \
    --cc=brookebasile@gmail.com \
    --cc=dvyukov@google.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=syzbot+4d2d56175b934b9a7bf9@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --subject='Re: [Linux-kernel-mentees] INFO: trying to register non-static key in ath9k_htc_rxep' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).