From: Dwaipayan Ray <firstname.lastname@example.org>
To: Lukas Bulwahn <email@example.com>
Subject: Re: [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues
Date: Sat, 26 Sep 2020 17:01:34 +0530 [thread overview]
Message-ID: <CABJPP5B8mfAi3MMS4xWbArJe=FcMBTF9U8qvXmaicGj5WKiGBQ@mail.gmail.com> (raw)
> > Yes, that should help I think. Currently checkpatch is very vague
> > about Author sign offs, so subclassing it will really be helpful.
> > But at the same point I don't think it should become
> > too complex either.
> Agree, that is where the evaluation will help (what is really happening,
> what do we need to consider) and the severity comes into play (if we
> consider all subclasses of same severity, we do not need to differentiate
> between them.)
> > I have already prepared a patch for the basic two classes:
> > 1) same name, different address
> > 2) same address, different name
> > It would be great to have your feedback on this.
> Okay, I suggest to run this script on a larger set of commits and see.
> Probably, you can speed it your evaluation with checkpatch.pl by
> restricting it to the AUTHOR_SIGN_OFF type. I will try that over the
> weekend as well.
So I did run my script to evaluate the type of errors that were generated.
My results are from commits between v5.7 and v5.8
1) Same address, different name
There were 32 such instances. In general, there was no regularity in the
There were some cases with letter case mismatch. Like there was one
committer who used the names "Arend Van Spriel", and "Arend van Spriel".
I believe this error should not be generated and matching be made case
Apart from this, the rest of the cases in this category were some with missing
first or last names, using names in other languages or having commas in
one name, using initials etc. These should be warned about.
2) Same name, different address
There were 204 such instances. Most of them were of the form in which they
used a completely different email address.
Only one case was found with an email extension.
in commit 423d9118c624
So in general I think most email mismatches should be specified by a WARN
and for email extension there should be a --strict CHECK.
What do you think of this?
Linux-kernel-mentees mailing list
next prev parent reply other threads:[~2020-09-26 11:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 10:06 [Linux-kernel-mentees] checkpatch.pl investigation: NO_AUTHOR_SIGN_OFF issues Lukas Bulwahn
2020-09-18 10:29 ` Dwaipayan Ray
2020-09-18 10:44 ` Lukas Bulwahn
2020-09-21 9:07 ` Dwaipayan Ray
2020-09-21 9:12 ` Lukas Bulwahn
2020-09-21 9:15 ` Lukas Bulwahn
2020-09-22 13:21 ` Dwaipayan Ray
2020-09-22 18:38 ` Lukas Bulwahn
2020-09-22 19:08 ` Dwaipayan Ray
2020-09-23 7:32 ` Lukas Bulwahn
2020-09-23 7:38 ` Dwaipayan Ray
2020-09-23 7:42 ` Lukas Bulwahn
2020-09-25 4:18 ` Dwaipayan Ray
2020-09-25 7:20 ` Lukas Bulwahn
2020-09-25 7:29 ` Dwaipayan Ray
2020-09-25 7:35 ` Lukas Bulwahn
2020-09-26 11:31 ` Dwaipayan Ray [this message]
2020-09-28 13:30 ` Dwaipayan Ray
2020-09-28 14:09 ` Lukas Bulwahn
2020-09-28 14:20 ` Dwaipayan Ray
2020-09-28 15:09 ` Lukas Bulwahn
2020-09-28 15:06 ` Lukas Bulwahn
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).